| Message ID | 20150113212758.GA20469@intel.com |
|---|---|
| State | New |
| Headers | show |
On 01/13/15 14:27, H.J. Lu wrote: > -fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A > glibc has been filed, PR 17836, and a glibc patch has been submitted. > OK for trunk? > > Thanks. > > > H.J. > -- > * gcc.target/i386/fentry-override.c: Properly place {} in target > selector. Remove nonpic. > * gcc.target/i386/fentry.c: Likewise. Does this change the pass/fail result of the test on a system without an updated glibc? jeff
On Tue, Jan 13, 2015 at 11:15 PM, Jeff Law <law@redhat.com> wrote: > On 01/13/15 14:27, H.J. Lu wrote: >> >> -fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A >> glibc has been filed, PR 17836, and a glibc patch has been submitted. >> OK for trunk? >> >> Thanks. >> >> >> H.J. >> -- >> * gcc.target/i386/fentry-override.c: Properly place {} in target >> selector. Remove nonpic. >> * gcc.target/i386/fentry.c: Likewise. > > Does this change the pass/fail result of the test on a system without an > updated glibc? Yes, they pass with the current glibc since they are compile tests.
On 01/14/15 04:38, H.J. Lu wrote: > On Tue, Jan 13, 2015 at 11:15 PM, Jeff Law <law@redhat.com> wrote: >> On 01/13/15 14:27, H.J. Lu wrote: >>> >>> -fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A >>> glibc has been filed, PR 17836, and a glibc patch has been submitted. >>> OK for trunk? >>> >>> Thanks. >>> >>> >>> H.J. >>> -- >>> * gcc.target/i386/fentry-override.c: Properly place {} in target >>> selector. Remove nonpic. >>> * gcc.target/i386/fentry.c: Likewise. >> >> Does this change the pass/fail result of the test on a system without an >> updated glibc? > > Yes, they pass with the current glibc since they are compile tests. OK for trunk. Thanks, Jeff
diff --git a/gcc/testsuite/gcc.target/i386/fentry-override.c b/gcc/testsuite/gcc.target/i386/fentry-override.c index 0464454..4dd87a8 100644 --- a/gcc/testsuite/gcc.target/i386/fentry-override.c +++ b/gcc/testsuite/gcc.target/i386/fentry-override.c @@ -1,5 +1,5 @@ /* Test -mfentry override */ -/* { dg-do compile { target { *-*-linux* } && { nonpic || ! { ia32 } } } } */ +/* { dg-do compile { target { { *-*-linux* } && { ! { ia32 } } } } } */ /* { dg-options "-mfentry" } */ /* { dg-final { scan-assembler-not "__fentry__" } } */ /* Origin: Andi Kleen */ diff --git a/gcc/testsuite/gcc.target/i386/fentry.c b/gcc/testsuite/gcc.target/i386/fentry.c index d0d70c6..3548dd7 100644 --- a/gcc/testsuite/gcc.target/i386/fentry.c +++ b/gcc/testsuite/gcc.target/i386/fentry.c @@ -1,5 +1,5 @@ /* Test -mfentry */ -/* { dg-do compile { target { *-*-linux* } && { nonpic || ! { ia32 } } } } */ +/* { dg-do compile { target { { *-*-linux* } && { ! { ia32 } } } } } */ /* { dg-options "-fprofile -mfentry" } */ /* { dg-final { scan-assembler "__fentry__" } } */ /* Origin: Andi Kleen */
-fprofile -mfentry works with PIE if gcrt1.o is compiled with -fPIC. A glibc has been filed, PR 17836, and a glibc patch has been submitted. OK for trunk? Thanks. H.J. -- * gcc.target/i386/fentry-override.c: Properly place {} in target selector. Remove nonpic. * gcc.target/i386/fentry.c: Likewise. --- gcc/testsuite/gcc.target/i386/fentry-override.c | 2 +- gcc/testsuite/gcc.target/i386/fentry.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)