diff mbox

Fix PR libstdc++/64422

Message ID 20150102224739.GV3134@redhat.com
State New
Headers show

Commit Message

Jonathan Wakely Jan. 2, 2015, 10:47 p.m. UTC 
On 02/01/15 19:59 +0000, Jonathan Wakely wrote:
>On 2 January 2015 at 18:05, Bernd Edlinger wrote:
>>
>> Hi,
>>
>> On Fri, 2 Jan 2015 16:41:38, Paolo Carlini wrote:
>>>
>>> Hi,
>>>
>>> On 01/02/2015 04:33 PM, Jonathan Wakely wrote:
>>>> The misc-inst.cc change looks good but as this is a libstdc++ bug the
>>>> testcase should be under the libstdc++-v3/testsuite dir and the patch
>>>> should be CC'd to the libstdc++ list.
>>> ... and shouldn't be a dg-do run, I would add.
>>>
>>> Paolo.
>>
>> How about this?  I verified that the test case is still able to detect
>> the missing symbols.
>> Actually I was not quite sure where to add the test case. Is it OK here?
>
>It isn't testing the member types, so I think either in
>21_strings/basic_string/ or 21_strings/basic_string/modifiers/ (since
>all the missing symbols happen to be ones defined in the "modifiers"
>subclause).
>
>For some reason that I don't really know, we put the FSF copyright and
>GPLv3+exception copying permission statement in all libstdc++ tests,
>please see one of the existing tests for the exact wording.
>
>OK for trunk after moving it to one of those other directories and
>adding the copyright boilerplate - thanks very much for fixing it.

One small tweak to the commit, the copyright date on the new file
should be just 2015. Committed to trunk.
diff mbox

Patch

commit df6648533281d52cf9eadd6e0c319daf1c00a9bb
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Jan 2 22:44:39 2015 +0000

    	* testsuite/21_strings/basic_string/modifiers/64422.cc: Fix copyright
    	date.

diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/modifiers/64422.cc b/libstdc++-v3/testsuite/21_strings/basic_string/modifiers/64422.cc
index 4b37ba9..524261a 100644
--- a/libstdc++-v3/testsuite/21_strings/basic_string/modifiers/64422.cc
+++ b/libstdc++-v3/testsuite/21_strings/basic_string/modifiers/64422.cc
@@ -1,6 +1,6 @@ 
 // 2015-01-02  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 
-// Copyright (C) 2005-2015 Free Software Foundation, Inc.
+// Copyright (C) 2015 Free Software Foundation, Inc.
 //
 // This file is part of the GNU ISO C++ Library.  This library is free
 // software; you can redistribute it and/or modify it under the