diff mbox

[Build,Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

Message ID 20141126162732.GC3850@physik.fu-berlin.de
State New
Headers show

Commit Message

Tobias Burnus Nov. 26, 2014, 4:27 p.m. UTC
On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote:
> This patch adds a configure check for isl_schedule_constraints_compute_schedule,
> which is new in ISL 0.13 - and uses it for conditional compilation.

Repeating the test on a massively multicore system, it fails at stage2 with an
in-tree 0.14 because -lisl cannot be found at gcc/configure time. Hence,
HAVE_ISL_SCHED_CONSTRAINTS_COMPUTE_SCHEDULE is false and one gets later an
error because a 0.12.2 function is not available with ISL 0.14.

However, running the configure test case manually - or building with fewer
cores - works. As does removing "gcc" after the failure such that isl/ is
available.  Thus, it looks like a dependency problem.

It seems to be fixed by the attached patch.
OK for the trunk?

Tobias

Comments

Tobias Grosser Nov. 26, 2014, 4:29 p.m. UTC | #1
On 26.11.2014 17:27, Tobias Burnus wrote:
> On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote:
>> This patch adds a configure check for isl_schedule_constraints_compute_schedule,
>> which is new in ISL 0.13 - and uses it for conditional compilation.
>
> Repeating the test on a massively multicore system, it fails at stage2 with an
> in-tree 0.14 because -lisl cannot be found at gcc/configure time. Hence,
> HAVE_ISL_SCHED_CONSTRAINTS_COMPUTE_SCHEDULE is false and one gets later an
> error because a 0.12.2 function is not available with ISL 0.14.
>
> However, running the configure test case manually - or building with fewer
> cores - works. As does removing "gcc" after the failure such that isl/ is
> available.  Thus, it looks like a dependency problem.
>
> It seems to be fixed by the attached patch.
> OK for the trunk?

OK from the graphite site. This needs a buildsystem OK though.

Tobias
Jeff Law Nov. 26, 2014, 7:41 p.m. UTC | #2
On 11/26/14 09:27, Tobias Burnus wrote:
> On Wed, Nov 26, 2014 at 04:55:40PM +0100, Tobias Burnus wrote:
>> >This patch adds a configure check for isl_schedule_constraints_compute_schedule,
>> >which is new in ISL 0.13 - and uses it for conditional compilation.
> Repeating the test on a massively multicore system, it fails at stage2 with an
> in-tree 0.14 because -lisl cannot be found at gcc/configure time. Hence,
> HAVE_ISL_SCHED_CONSTRAINTS_COMPUTE_SCHEDULE is false and one gets later an
> error because a 0.12.2 function is not available with ISL 0.14.
>
> However, running the configure test case manually - or building with fewer
> cores - works. As does removing "gcc" after the failure such that isl/ is
> available.  Thus, it looks like a dependency problem.
>
> It seems to be fixed by the attached patch.
> OK for the trunk?
>
> Tobias
>
>
> g3.diff
>
>
> 2014-11-26  Tobias Burnus<burnus@net-b.de>
>
> 	PR middle-end/64017
> 	* Makefile.def: Make more dependent on mpfr, mpc and isl.
> 	* Makefile.in: Regenerate.
This is OK for the trunk.

jeff
diff mbox

Patch

2014-11-26  Tobias Burnus  <burnus@net-b.de>

	PR middle-end/64017
	* Makefile.def: Make more dependent on mpfr, mpc and isl.
	* Makefile.in: Regenerate.

diff --git a/Makefile.def b/Makefile.def
index ddcbf5b..7c8761a 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -308,6 +308,9 @@  dependencies = { module=all-build-libcpp; on=all-build-libiberty; };
 // Host modules specific to gcc.
 dependencies = { module=configure-gcc; on=configure-intl; };
 dependencies = { module=configure-gcc; on=all-gmp; };
+dependencies = { module=configure-gcc; on=all-mpfr; };
+dependencies = { module=configure-gcc; on=all-mpc; };
+dependencies = { module=configure-gcc; on=all-isl; };
 dependencies = { module=configure-gcc; on=all-lto-plugin; };
 dependencies = { module=configure-gcc; on=all-binutils; };
 dependencies = { module=configure-gcc; on=all-gas; };
diff --git a/Makefile.in b/Makefile.in
index 02d914c..182e1fd 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -48094,6 +48094,30 @@  configure-stage3-gcc: maybe-all-stage3-gmp
 configure-stage4-gcc: maybe-all-stage4-gmp
 configure-stageprofile-gcc: maybe-all-stageprofile-gmp
 configure-stagefeedback-gcc: maybe-all-stagefeedback-gmp
+configure-gcc: maybe-all-mpfr
+
+configure-stage1-gcc: maybe-all-stage1-mpfr
+configure-stage2-gcc: maybe-all-stage2-mpfr
+configure-stage3-gcc: maybe-all-stage3-mpfr
+configure-stage4-gcc: maybe-all-stage4-mpfr
+configure-stageprofile-gcc: maybe-all-stageprofile-mpfr
+configure-stagefeedback-gcc: maybe-all-stagefeedback-mpfr
+configure-gcc: maybe-all-mpc
+
+configure-stage1-gcc: maybe-all-stage1-mpc
+configure-stage2-gcc: maybe-all-stage2-mpc
+configure-stage3-gcc: maybe-all-stage3-mpc
+configure-stage4-gcc: maybe-all-stage4-mpc
+configure-stageprofile-gcc: maybe-all-stageprofile-mpc
+configure-stagefeedback-gcc: maybe-all-stagefeedback-mpc
+configure-gcc: maybe-all-isl
+
+configure-stage1-gcc: maybe-all-stage1-isl
+configure-stage2-gcc: maybe-all-stage2-isl
+configure-stage3-gcc: maybe-all-stage3-isl
+configure-stage4-gcc: maybe-all-stage4-isl
+configure-stageprofile-gcc: maybe-all-stageprofile-isl
+configure-stagefeedback-gcc: maybe-all-stagefeedback-isl
 configure-gcc: maybe-all-lto-plugin
 
 configure-stage1-gcc: maybe-all-stage1-lto-plugin