diff mbox

DW_AT_APPLE_* DWARF extensions.

Message ID 20141114144822.GN3565@embecosm.com
State New
Headers show

Commit Message

Andrew Burgess Nov. 14, 2014, 2:48 p.m. UTC 
* Jakub Jelinek <jakub@redhat.com> [2014-11-13 14:13:42 +0100]:

> On Thu, Nov 13, 2014 at 01:21:21PM +0100, Andrew Burgess wrote:
> > I had a look around and couldn't find anything helpful.  The best I
> > can offer would be the current path within the llvm source code where
> > these are defined.  Would that be sufficient?
>
> That is not useful.  The point is not to suggest where those constants come
> from but what they mean, see e.g. the
> http://www.dwarfstd.org/ShowIssue.php?issue=100909.2&type=open
> http://gcc.gnu.org/wiki/TemplateParmsDwarf
> etc. links that describe what the extensions do.
> If LLVM doesn't have any documentation of their extensions, then just
> /* Apple extensions.  */
> is good enough.

I agree, hence my comment about not finding anything useful :)

I've look again, and still can't find anything suitable, so could we
go with just "/* Apple extensions.  */" then?

Patch & Changelog below.

Thanks,
Andrew

2014-11-14  Shinichiro Hamaji  <shinichiro.hamaji@gmail.com>

	* dwarf2.def (DW_AT_APPLE_optimized, DW_AT_APPLE_flags)
	(DW_AT_APPLE_isa, DW_AT_APPLE_block)
	(DW_AT_APPLE_major_runtime_vers, DW_AT_APPLE_runtime_class)
	(DW_AT_APPLE_omit_frame_ptr, DW_AT_APPLE_property_name)
	(DW_AT_APPLE_property_getter, DW_AT_APPLE_property_setter)
	(DW_AT_APPLE_property_attribute, DW_AT_APPLE_objc_complete_type)
	(DW_AT_APPLE_property): New macros.

Comments

Jakub Jelinek Nov. 14, 2014, 5:18 p.m. UTC | #1 
On Fri, Nov 14, 2014 at 03:48:22PM +0100, Andrew Burgess wrote:
> * Jakub Jelinek <jakub@redhat.com> [2014-11-13 14:13:42 +0100]:
> 
> > On Thu, Nov 13, 2014 at 01:21:21PM +0100, Andrew Burgess wrote:
> > > I had a look around and couldn't find anything helpful.  The best I
> > > can offer would be the current path within the llvm source code where
> > > these are defined.  Would that be sufficient?
> >
> > That is not useful.  The point is not to suggest where those constants come
> > from but what they mean, see e.g. the
> > http://www.dwarfstd.org/ShowIssue.php?issue=100909.2&type=open
> > http://gcc.gnu.org/wiki/TemplateParmsDwarf
> > etc. links that describe what the extensions do.
> > If LLVM doesn't have any documentation of their extensions, then just
> > /* Apple extensions.  */
> > is good enough.
> 
> I agree, hence my comment about not finding anything useful :)
> 
> I've look again, and still can't find anything suitable, so could we
> go with just "/* Apple extensions.  */" then?
> 
> Patch & Changelog below.

Applied.

	Jakub
diff mbox

Patch

diff --git a/include/dwarf2.def b/include/dwarf2.def
index 71a37b3..878c5c6 100644
--- a/include/dwarf2.def
+++ b/include/dwarf2.def
@@ -406,6 +406,20 @@  DW_AT (DW_AT_upc_threads_scaled, 0x3210)
 DW_AT (DW_AT_PGI_lbase, 0x3a00)
 DW_AT (DW_AT_PGI_soffset, 0x3a01)
 DW_AT (DW_AT_PGI_lstride, 0x3a02)
+/* Apple extensions.  */
+DW_AT (DW_AT_APPLE_optimized, 0x3fe1)
+DW_AT (DW_AT_APPLE_flags, 0x3fe2)
+DW_AT (DW_AT_APPLE_isa, 0x3fe3)
+DW_AT (DW_AT_APPLE_block, 0x3fe4)
+DW_AT (DW_AT_APPLE_major_runtime_vers, 0x3fe5)
+DW_AT (DW_AT_APPLE_runtime_class, 0x3fe6)
+DW_AT (DW_AT_APPLE_omit_frame_ptr, 0x3fe7)
+DW_AT (DW_AT_APPLE_property_name, 0x3fe8)
+DW_AT (DW_AT_APPLE_property_getter, 0x3fe9)
+DW_AT (DW_AT_APPLE_property_setter, 0x3fea)
+DW_AT (DW_AT_APPLE_property_attribute, 0x3feb)
+DW_AT (DW_AT_APPLE_objc_complete_type, 0x3fec)
+DW_AT (DW_AT_APPLE_property, 0x3fed)
 DW_END_AT
 
 DW_FIRST_OP (DW_OP_addr, 0x03)