diff mbox

[libgfortran] PR 60324 Unbounded stack allocations in libgfortran

Message ID 20141113155707.GR29791@redhat.com
State New
Headers show

Commit Message

Marek Polacek Nov. 13, 2014, 3:57 p.m. UTC
On Thu, Nov 13, 2014 at 02:05:52PM +0200, Janne Blomqvist wrote:
> Thanks for the quick review, committed as r217480.

This broke bootstrap because of implicit declaration of free.

The following (untested) should fix it, ok for trunk?

2014-11-13  Marek Polacek  <polacek@redhat.com>

	* intrinsics/access.c: Include <stdlib.h>.
	* intrinsics/chdir.c: Likewise.
	* intrinsics/chmod.c: Likewise.

	Marek

Comments

Jakub Jelinek Nov. 13, 2014, 3:59 p.m. UTC | #1
On Thu, Nov 13, 2014 at 04:57:08PM +0100, Marek Polacek wrote:
> On Thu, Nov 13, 2014 at 02:05:52PM +0200, Janne Blomqvist wrote:
> > Thanks for the quick review, committed as r217480.
> 
> This broke bootstrap because of implicit declaration of free.
> 
> The following (untested) should fix it, ok for trunk?
> 
> 2014-11-13  Marek Polacek  <polacek@redhat.com>
> 
> 	* intrinsics/access.c: Include <stdlib.h>.
> 	* intrinsics/chdir.c: Likewise.
> 	* intrinsics/chmod.c: Likewise.

Ok, thanks.

	Jakub
diff mbox

Patch

diff --git gcc/intrinsics/access.c gcc/intrinsics/access.c
index 65a0a10..0c18da0 100644
--- gcc/intrinsics/access.c
+++ gcc/intrinsics/access.c
@@ -26,6 +26,7 @@  see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #include "libgfortran.h"
 
 #include <errno.h>
+#include <stdlib.h>
 #include <string.h>
 
 #ifdef HAVE_UNISTD_H
diff --git gcc/intrinsics/chdir.c gcc/intrinsics/chdir.c
index 87419a8..193e482 100644
--- gcc/intrinsics/chdir.c
+++ gcc/intrinsics/chdir.c
@@ -26,6 +26,7 @@  see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #include "libgfortran.h"
 
 #include <errno.h>
+#include <stdlib.h>
 #include <string.h>
 
 #ifdef HAVE_UNISTD_H
diff --git gcc/intrinsics/chmod.c gcc/intrinsics/chmod.c
index c42fa8c..bdcb676 100644
--- gcc/intrinsics/chmod.c
+++ gcc/intrinsics/chmod.c
@@ -28,6 +28,7 @@  see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #if defined(HAVE_SYS_STAT_H)
 
 #include <string.h>	/* For memcpy. */
+#include <stdlib.h>	/* For free.  */
 #include <sys/stat.h>	/* For stat, chmod and umask.  */