From patchwork Sun Sep 28 12:57:10 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Trippelsdorf X-Patchwork-Id: 394178 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 90286140119 for ; Sun, 28 Sep 2014 22:57:22 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=COFcFwlJVBiYHcsaV 6zGshTctaINCXQFP5SGHx8KD4qyGihlV0mXYn2fzqhVx1Ahhk1K2BS9HfyTIZRtq bgmJv7bTYHmtW0Xv4rQPQR2iJzfbAmSKRbilsOmfXafibEW1OFhgD/ST+p3hVp6p CjtYiLa630il7ExMWGkDD28KDI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=z2zOTWZ/1oasx4mWsw7dmf6 zDmM=; b=QIRrExKTtL+h+IL66NpgW69K3ZkGimHSuDmbQspBF4hfh8vFtXMKouF tHe0bi5O1WTpAaC+X0qkM6oVF/VxbMTcqthGCGSilqL0uZSwlT/tTdJ9DSJanR+o Bke7q23JEaBITUbeSBn3ycJORlmHjgKM1MvaQC0Y2QZ7SJO2xm9g= Received: (qmail 10926 invoked by alias); 28 Sep 2014 12:57:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10913 invoked by uid 89); 28 Sep 2014 12:57:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.3 required=5.0 tests=AWL, BAYES_00, KAM_MXURI, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mail.ud10.udmedia.de Received: from ud10.udmedia.de (HELO mail.ud10.udmedia.de) (194.117.254.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 28 Sep 2014 12:57:14 +0000 Received: (qmail 30940 invoked from network); 28 Sep 2014 14:57:11 +0200 Received: from unknown (HELO x4) (ud10?360p3@91.64.94.144) by mail.ud10.udmedia.de with ESMTPSA (DHE-RSA-AES256-SHA encrypted, authenticated); 28 Sep 2014 14:57:11 +0200 Date: Sun, 28 Sep 2014 14:57:10 +0200 From: Markus Trippelsdorf To: Steven Bosscher Cc: GCC Patches , Diego Novillo Subject: [PATCH v2] Fix signed integer overflow in gcc/data-streamer.c Message-ID: <20140928125710.GB302@x4> References: <20140928122218.GA302@x4> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: On 2014.09.28 at 14:36 +0200, Steven Bosscher wrote: > > Can you use HOST_WIDE_INT_1U for this? Sure. Thanks for the suggestion. (Fix now resembles similar idiom in data-streamer-in.c) 2014-09-28 Markus Trippelsdorf * data-streamer.c (bp_unpack_var_len_int): Avoid signed integer overflow. diff --git a/gcc/data-streamer.c b/gcc/data-streamer.c index 0e19c72162aa..785beb5165fa 100644 --- a/gcc/data-streamer.c +++ b/gcc/data-streamer.c @@ -110,7 +110,7 @@ bp_unpack_var_len_int (struct bitpack_d *bp) if ((half_byte & 0x8) == 0) { if ((shift < HOST_BITS_PER_WIDE_INT) && (half_byte & 0x4)) - result |= - ((HOST_WIDE_INT)1 << shift); + result |= - (HOST_WIDE_INT_1U << shift); return result; }