From patchwork Wed Jun 25 05:18:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 363828 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A8A941400D5 for ; Wed, 25 Jun 2014 15:18:49 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; q=dns; s= default; b=lQfNEqBNHhGt1vy3dBTFEwq39NkuJciPBc/MAFw2y4q3dFgH+l2+U cO79XYpcYxNtOnBVYHzD4p1+JrSh7EQQdcXuLM/osfu/NAiq1puQq6gpmML52s47 WuNnyNqRjcpp+jLlizrQgixHoNTdTheQo4UHCHB4Wpzx94mwFJKj+M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=default; bh=/VZj0HLV3Td+hJUU7Mf7bew6J+0=; b=jC415/jzmI90XhhCS/QnmWZJ9r0+ TDvhoCS1L9cqR+67+L+78/kqZ/NwXp9zCLTwmBy8lQP99lFw6wCbLiyFxapC2JPH ZSoveuUM/5mQhqw54oYlGlGDGwS5otRCagBDak2IyOyFRh4U15x1+vchMIGb4cg2 vvIh5C4zWi3caLo= Received: (qmail 6378 invoked by alias); 25 Jun 2014 05:18:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6361 invoked by uid 89); 25 Jun 2014 05:18:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 25 Jun 2014 05:18:38 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id DED59543377; Wed, 25 Jun 2014 07:18:34 +0200 (CEST) Date: Wed, 25 Jun 2014 07:18:34 +0200 From: Jan Hubicka To: Jan-Benedict Glaw Cc: Jan Hubicka , Nick Clifton , gcc-patches@gcc.gnu.org Subject: Re: [BUILDROBOT] v850 fallout (was: Turn DECL_SECTION_NAME into string) Message-ID: <20140625051834.GC30367@kam.mff.cuni.cz> References: <20140612043325.GA6864@kam.mff.cuni.cz> <20140625011226.GM31494@lug-owl.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140625011226.GM31494@lug-owl.de> User-Agent: Mutt/1.5.21 (2010-09-15) > Hi! > > I've been away for holidays and other stuff, so this is a bit late, > but nevermind... The stringification of DECL_SECTION_NAME had some > fallout, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272454 > > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -I. -I/home/jbglaw/repos/gcc/gcc -I/home/jbglaw/repos/gcc/gcc/. -I/home/jbglaw/repos/gcc/gcc/../include -I/home/jbglaw/repos/gcc/gcc/../libcpp/include -I/home/jbglaw/repos/gcc/gcc/../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I/home/jbglaw/repos/gcc/gcc/../libbacktrace -o v850.o -MT v850.o -MMD -MP -MF ./.deps/v850.TPo /home/jbglaw/repos/gcc/gcc/config/v850/v850.c > /home/jbglaw/repos/gcc/gcc/config/v850/v850.c: In function ‘tree_node* v850_handle_interrupt_attribute(tree_node**, tree_node*, tree_node*, int, bool*)’: > /home/jbglaw/repos/gcc/gcc/config/v850/v850.c:2088: warning: unknown conversion type character ‘E’ in format > /home/jbglaw/repos/gcc/gcc/config/v850/v850.c:2088: warning: too many arguments for format > /home/jbglaw/repos/gcc/gcc/config/v850/v850.c: In function ‘void v850_insert_attributes(tree_node*, tree_node**)’: > /home/jbglaw/repos/gcc/gcc/config/v850/v850.c:2647: error: cannot convert ‘tree_node*’ to ‘const char*’ for argument ‘2’ to ‘void set_decl_section_name(tree_node*, const char*)’ > make[1]: *** [v850.o] Error 1 The following patch should cure this: but perhaps tree GHS_default_section_names [(int) COUNT_OF_GHS_SECTION_KINDS]; tree GHS_current_section_names [(int) COUNT_OF_GHS_SECTION_KINDS]; Should be turned into strings. I do not see who is initializing these? Honza > > MfG, JBG > > -- > Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481 > Signature of: Alles sollte so einfach wie möglich gemacht sein. > the second : Aber nicht einfacher. (Einstein) Index: gcc/config/v850/v850.c =================================================================== --- gcc/config/v850/v850.c (revision 211693) +++ gcc/config/v850/v850.c (working copy) @@ -2644,7 +2644,7 @@ /* Only set the section name if specified by a pragma, because otherwise it will force those variables to get allocated storage in this module, rather than by the linker. */ - set_decl_section_name (decl, chosen_section); + set_decl_section_name (decl, DECL_IDENTIFIER_POINTER (chosen_section)); } } }