| Message ID | 20140604140138.GB11110@e103625-lin.cambridge.arm.com |
|---|---|
| State | New |
| Headers | show |
PING! On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: > Hello, > > The following test cases fail when -fPIC is passed as dejagnu multilib flag > since -fPIC causes the 'availability' of the functions to be overwritable. I > have fixed this by adding bind_pic_locally to these cases. > > gcc.dg/fail_always_inline.c > gcc.dg/inline-22.c > gcc.dg/inline_4.c > g++.dg/ipa/devirt-25.C > > Tested on: > > aarch64-none-elf > aarch64-none-linux-gnu > arm-none-linux-gnueabihf > x86_64-unknown-linux-gnu > > OK for trunk? > > Cheers > VP. > > ~~~ > > gcc/testsuite/ChangeLog: > > 2014-06-04 Vidya Praveen <vidyapraveen@arm.com> > > * gcc.dg/inline-22.c: Add bind_pic_locally. > * gcc.dg/inline_4.c: Ditto. > * gcc.dg/fail_always_inline.c: Ditto. > * g++.dg/ipa/devirt-25.C: Ditto. > > diff --git a/gcc/testsuite/g++.dg/ipa/devirt-25.C b/gcc/testsuite/g++.dg/ipa/devirt-25.C > index 7516479..387d529 100644 > --- a/gcc/testsuite/g++.dg/ipa/devirt-25.C > +++ b/gcc/testsuite/g++.dg/ipa/devirt-25.C > @@ -1,5 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-O3 -fdump-ipa-cp" } */ > +/* { dg-add-options bind_pic_locally } */ > > class ert_RefCounter { > protected: > diff --git a/gcc/testsuite/gcc.dg/fail_always_inline.c b/gcc/testsuite/gcc.dg/fail_always_inline.c > index 4b196ac..86645b8 100644 > --- a/gcc/testsuite/gcc.dg/fail_always_inline.c > +++ b/gcc/testsuite/gcc.dg/fail_always_inline.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-add-options bind_pic_locally } */ > > extern __attribute__ ((always_inline)) void > bar() { } /* { dg-warning "function might not be inlinable" } */ > diff --git a/gcc/testsuite/gcc.dg/inline-22.c b/gcc/testsuite/gcc.dg/inline-22.c > index 1785e1c..6795c5f 100644 > --- a/gcc/testsuite/gcc.dg/inline-22.c > +++ b/gcc/testsuite/gcc.dg/inline-22.c > @@ -1,5 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-funit-at-a-time -Wno-attributes" } */ > +/* { dg-add-options bind_pic_locally } */ > /* Verify we can inline without a complete prototype and with promoted > arguments. See also PR32492. */ > __attribute__((always_inline)) void f1() {} > diff --git a/gcc/testsuite/gcc.dg/inline_4.c b/gcc/testsuite/gcc.dg/inline_4.c > index dd4fadb..ebd57e9 100644 > --- a/gcc/testsuite/gcc.dg/inline_4.c > +++ b/gcc/testsuite/gcc.dg/inline_4.c > @@ -1,5 +1,6 @@ > /* { dg-do compile } */ > /* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo2 -fdisable-ipa-inline -Wno-attributes" } */ > +/* { dg-add-options bind_pic_locally } */ > int g; > __attribute__((always_inline)) void bar (void) > {
On 06/25/14 04:06, Vidya Praveen wrote: > PING! > > On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: >> Hello, >> >> The following test cases fail when -fPIC is passed as dejagnu multilib flag >> since -fPIC causes the 'availability' of the functions to be overwritable. I >> have fixed this by adding bind_pic_locally to these cases. >> >> gcc.dg/fail_always_inline.c >> gcc.dg/inline-22.c >> gcc.dg/inline_4.c >> g++.dg/ipa/devirt-25.C >> >> Tested on: >> >> aarch64-none-elf >> aarch64-none-linux-gnu >> arm-none-linux-gnueabihf >> x86_64-unknown-linux-gnu >> >> OK for trunk? >> >> Cheers >> VP. >> >> ~~~ >> >> gcc/testsuite/ChangeLog: >> >> 2014-06-04 Vidya Praveen <vidyapraveen@arm.com> >> >> * gcc.dg/inline-22.c: Add bind_pic_locally. >> * gcc.dg/inline_4.c: Ditto. >> * gcc.dg/fail_always_inline.c: Ditto. >> * g++.dg/ipa/devirt-25.C: Ditto. OK. jeff
diff --git a/gcc/testsuite/g++.dg/ipa/devirt-25.C b/gcc/testsuite/g++.dg/ipa/devirt-25.C index 7516479..387d529 100644 --- a/gcc/testsuite/g++.dg/ipa/devirt-25.C +++ b/gcc/testsuite/g++.dg/ipa/devirt-25.C @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O3 -fdump-ipa-cp" } */ +/* { dg-add-options bind_pic_locally } */ class ert_RefCounter { protected: diff --git a/gcc/testsuite/gcc.dg/fail_always_inline.c b/gcc/testsuite/gcc.dg/fail_always_inline.c index 4b196ac..86645b8 100644 --- a/gcc/testsuite/gcc.dg/fail_always_inline.c +++ b/gcc/testsuite/gcc.dg/fail_always_inline.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-add-options bind_pic_locally } */ extern __attribute__ ((always_inline)) void bar() { } /* { dg-warning "function might not be inlinable" } */ diff --git a/gcc/testsuite/gcc.dg/inline-22.c b/gcc/testsuite/gcc.dg/inline-22.c index 1785e1c..6795c5f 100644 --- a/gcc/testsuite/gcc.dg/inline-22.c +++ b/gcc/testsuite/gcc.dg/inline-22.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-funit-at-a-time -Wno-attributes" } */ +/* { dg-add-options bind_pic_locally } */ /* Verify we can inline without a complete prototype and with promoted arguments. See also PR32492. */ __attribute__((always_inline)) void f1() {} diff --git a/gcc/testsuite/gcc.dg/inline_4.c b/gcc/testsuite/gcc.dg/inline_4.c index dd4fadb..ebd57e9 100644 --- a/gcc/testsuite/gcc.dg/inline_4.c +++ b/gcc/testsuite/gcc.dg/inline_4.c @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -fdump-tree-optimized -fdisable-tree-einline=foo2 -fdisable-ipa-inline -Wno-attributes" } */ +/* { dg-add-options bind_pic_locally } */ int g; __attribute__((always_inline)) void bar (void) {