From patchwork Tue Apr 8 04:13:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 337568 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 78B67140113 for ; Tue, 8 Apr 2014 14:13:42 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=hL2KjeNacMcELhzhN4SrHs9kPlmmLM8nLkBMwoOFDUhAXD7YG1hzO +DZlG1+mpE0T9Vv7i7TEedfnnAO+wZ/jmlaJWqNRmYH0pkJeSkVpJfrYreOrOIwh Bl7S9FRLAmmVrESLvWjD0r10VF8aFRy4WCTSgGDpj3zNxs/hVV3QRQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=tWkj9rp12QTJyX7KZ7ndNdN64TQ=; b=RvqecXYnFn5D5R5t3QSq 5gnkKtz3A1/t6r7zKRa2FOokFtwRuOykc/TaoAT03wGCe56lNpYpiUcX22um4kl/ UNeL2XB4KuzTmf5/fU0nnC0SifvcN8L1aGKZfjN4W/bxmbirCLLKWehIdNOs/KGD wUO7YhmoB1gwNdFt8cCH7RM= Received: (qmail 18369 invoked by alias); 8 Apr 2014 04:13:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 18352 invoked by uid 89); 8 Apr 2014 04:13:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Apr 2014 04:13:30 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 5C2EC540C64; Tue, 8 Apr 2014 06:13:27 +0200 (CEST) Date: Tue, 8 Apr 2014 06:13:27 +0200 From: Jan Hubicka To: gcc-patches@gcc.gnu.org, mjambor@suse.cz Subject: Fix wrong code issue in ipa-devirt Message-ID: <20140408041327.GA25140@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Hi, while looking into devirtualization dumps, I noticed that I got one "false" typed out as "true". Not sure what I was thinking of. Martin, this may fix the wrong code issue you see in Firefox, hopefully. Will commit it after x86_64-linux testing finishes tomorrow. Honza * ipa-devirt.c (maybe_record_node): Set completep to false instead of true when node is not recorded. Index: ipa-devirt.c =================================================================== --- ipa-devirt.c (revision 209170) +++ ipa-devirt.c (working copy) @@ -650,7 +650,7 @@ maybe_record_node (vec & else if (completep && !type_in_anonymous_namespace_p (method_class_type (TREE_TYPE (target)))) - *completep = true; + *completep = false; } /* See if BINFO's type match OUTER_TYPE. If so, lookup