From patchwork Mon Apr 7 16:22:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Krebbel X-Patchwork-Id: 337490 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 21014140079 for ; Tue, 8 Apr 2014 02:22:36 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=fbFFGdvXOiRnxdhYE AkWqjWDA/Av7C8U7QuQIoxGt3VjnaV76epQ8bfWCeivabXuYL+ZuY1tvCJa4hkpK VSDqrC0IkaqkGYnzUXhmFP1Q1YcJjiLkhxec89LZr7VnxhU0suT/JeQ4PvuTAYCA 9T88jAwUSqukRGWLGkjNAz14eI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=hZQ0SPf4uSuDTWBlvvB8fK/ 6XvU=; b=d/qDA2WE2nm1HtaEk2QYMBCIr3nLr6RgaEtYziBqfhIbdeFSzTRU9yI ybM85KWe0eeDzDmGGlC5HUHGl+6eHKARM616FoZ3EhSML/tSMDQ41Xu8BounHtz4 rPnb0peeESLKU1jluzmUJb2xBWlhD1yZvt6e8iTxNnOHj6yy2FBg= Received: (qmail 28823 invoked by alias); 7 Apr 2014 16:22:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28801 invoked by uid 89); 7 Apr 2014 16:22:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e06smtp18.uk.ibm.com Received: from e06smtp18.uk.ibm.com (HELO e06smtp18.uk.ibm.com) (195.75.94.114) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 07 Apr 2014 16:22:23 +0000 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Apr 2014 17:22:20 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp18.uk.ibm.com (192.168.101.148) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 7 Apr 2014 17:22:17 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id AF3681B0805F for ; Mon, 7 Apr 2014 17:22:15 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s37GM5mN6226122 for ; Mon, 7 Apr 2014 16:22:05 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s37GMGNd017424 for ; Mon, 7 Apr 2014 10:22:16 -0600 Received: from bart (icon-9-164-133-216.megacenter.de.ibm.com [9.164.133.216]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id s37GMFFp017411; Mon, 7 Apr 2014 10:22:15 -0600 Received: by bart (sSMTP sendmail emulation); Mon, 07 Apr 2014 18:22:14 +0200 Date: Mon, 7 Apr 2014 18:22:14 +0200 From: Andreas Krebbel To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Adjust builtin-bswap-6/7 Message-ID: <20140407162214.GA25019@maggie> References: <20140404161818.GA26795@bart> <533EF13A.8010001@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040716-6892-0000-0000-000008626092 X-IsSubscribed: yes On Mon, Apr 07, 2014 at 04:19:06PM +0200, Richard Biener wrote: > The adjusted testcases now fail on x86_64/i?86 at least. See PR60776. They seem to require at least -O2 on x86 with that change. Ok to apply? diff --git a/gcc/testsuite/gcc.dg/builtin-bswap-6.c b/gcc/testsuite/gcc.dg/builtin-bswap-6.c index 6f0c782..f346c2f 100644 --- a/gcc/testsuite/gcc.dg/builtin-bswap-6.c +++ b/gcc/testsuite/gcc.dg/builtin-bswap-6.c @@ -1,7 +1,7 @@ /* { dg-do compile { target arm*-*-* alpha*-*-* i?86-*-* powerpc*-*-* rs6000-*-* x86_64-*-* s390*-*-* } } */ /* { dg-require-effective-target stdint_types } */ -/* { dg-options "-O -fdump-rtl-combine" } */ -/* { dg-options "-O -fdump-rtl-combine -march=z900" { target s390-*-* } } */ +/* { dg-options "-O2 -fdump-rtl-combine" } */ +/* { dg-options "-O2 -fdump-rtl-combine -march=z900" { target s390-*-* } } */ /* The test intentionally returns 1/2 instead of the obvious 0/1 to prevent GCC from calculating the return value with arithmetic diff --git a/gcc/testsuite/gcc.dg/builtin-bswap-7.c b/gcc/testsuite/gcc.dg/builtin-bswap-7.c index 0eecdd8..98529f2 100644 --- a/gcc/testsuite/gcc.dg/builtin-bswap-7.c +++ b/gcc/testsuite/gcc.dg/builtin-bswap-7.c @@ -1,7 +1,7 @@ /* { dg-do compile { target arm*-*-* alpha*-*-* ia64*-*-* x86_64-*-* s390x-*-* powerpc*-*-* rs6000-*-* } } */ /* { dg-require-effective-target stdint_types } */ /* { dg-require-effective-target lp64 } */ -/* { dg-options "-O -fdump-rtl-combine" } */ +/* { dg-options "-O2 -fdump-rtl-combine" } */ /* The test intentionally returns 1/2 instead of the obvious 0/1 to prevent GCC from calculating the return value with arithmetic