From patchwork Sun Dec 15 14:20:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 301352 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 684DF2C009F for ; Mon, 16 Dec 2013 01:21:15 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:cc:in-reply-to:subject:mime-version :content-type:content-transfer-encoding; q=dns; s=default; b=aJn pcSJZpfQRBdvS10dU7IwC9DxSPg5evifwLLvpDVUZoZQjmw/ESJOM1GtQUTjSbF9 xvEGUToGAYXkiAR4GfiL0u3X8HqAPevKFe4aX+t2yWiFrnFt5uUmT1iBqSyH9y5i AZNotWwtLsjlbAJ6egVlu/4Ce0HZva7/QSNT25cU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :message-id:from:to:cc:in-reply-to:subject:mime-version :content-type:content-transfer-encoding; s=default; bh=uiSlkn2cG YzQ9kunefSjCAQv0JU=; b=qpgzoT0zxscLfgSvkXhKxfmVLhxhY7VNuol0mZ+Mw INMbHWQyZK3BNBAbbDmtlm7d1jJwtkKD5o6qSet2oxz5+0ISjG8efVJbocYbMY5G iQzsWI603wwaEX1lqrW3wwnx54TcP6H/8wQTRgMu6b2/ImHLYMyREFlwf5LUgArJ +E= Received: (qmail 2298 invoked by alias); 15 Dec 2013 14:20:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2275 invoked by uid 89); 15 Dec 2013 14:20:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: ra.se.axis.com Received: from ra.se.axis.com (HELO ra.se.axis.com) (195.60.68.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2013 14:20:54 +0000 Received: from localhost (localhost [127.0.0.1]) by ra.se.axis.com (Postfix) with ESMTP id 1D90C3F20C2; Sun, 15 Dec 2013 15:20:51 +0100 (CET) Received: from ra.se.axis.com ([127.0.0.1]) by localhost (ra.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id l43HX0zmbIA9; Sun, 15 Dec 2013 15:20:50 +0100 (CET) Received: from boulder.se.axis.com (boulder.se.axis.com [10.0.2.104]) by ra.se.axis.com (Postfix) with ESMTP id 10BBF13A8D; Sun, 15 Dec 2013 15:20:50 +0100 (CET) Received: from boulder.se.axis.com (localhost [127.0.0.1]) by postfix.imss71 (Postfix) with ESMTP id DF47056E; Sun, 15 Dec 2013 15:20:49 +0100 (CET) Received: from thoth.se.axis.com (thoth.se.axis.com [10.0.2.173]) by boulder.se.axis.com (Postfix) with ESMTP id D3C6250F; Sun, 15 Dec 2013 15:20:49 +0100 (CET) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by thoth.se.axis.com (Postfix) with ESMTP id D02F93404E; Sun, 15 Dec 2013 15:20:49 +0100 (CET) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id rBFEKnh9018243; Sun, 15 Dec 2013 15:20:49 +0100 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id rBFEKmYh018239; Sun, 15 Dec 2013 15:20:48 +0100 Date: Sun, 15 Dec 2013 15:20:48 +0100 Message-Id: <201312151420.rBFEKmYh018239@ignucius.se.axis.com> From: Hans-Peter Nilsson To: jwakely.gcc@gmail.com CC: Yufeng.Zhang@arm.com, libstdc++@gcc.gnu.org, Renlin.Li@arm.com, gcc-patches@gcc.gnu.org In-reply-to: (message from Jonathan Wakely on Sun, 15 Dec 2013 11:38:43 +0100) Subject: Re: RFA: revert libstdc++ r205810: simulator workload increase caused regression MIME-Version: 1.0 > From: Jonathan Wakely > Date: Sun, 15 Dec 2013 11:38:43 +0100 > On Dec 15, 2013 6:57 AM, "Hans-Peter Nilsson" > wrote: > > > > From the revision range 205803:205810 (excluding:including) an > > on, my autotester for cris-elf reports a regression: > > > > Running /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp ... > > WARNING: program timed out. > > FAIL: 20_util/hash/chi2_quality.cc execution test > > > > This appears to have come from revision r205810.  I can't find > > the discussion > > http://gcc.gnu.org/ml/libstdc++/2013-10/msg00233.html > > > or approval leading to that commit. > > http://gcc.gnu.org/ml/libstdc++/2013-11/msg00098.html Aha, October and November; for gcc-patches I looked like a month back but for that list alone I only looked at December, sorry. An ill-formed test for the chi2 value to be math-implementation-dependent, IMHO (certainly not obvious to me), and it'd have been a service to others mentioning this oddness in the patch. I'll take the statement "pass for all arm target linking with glibc" at face value and not bring up soft-float variants on newlib and slower host machines (oops). The time-eater I noticed at the time I added the SAMPLES-for-simulators thingy is actually in test_document_words. Would it be ok to split up chi2_quality.cc in five, along the test_*() functions? Maybe with a comment or two about the sensitivity to the number of iterations in test_uniform_random() and test_bit_flip_set(). That will, if not take out the simulator timeout issue altogether, then at least make it specific to the part with test_document_words(). Before I thought of that, I started a run for arm-eabi (oops again, not glibc) with the following patch, presented without a ChangeLog entry for your disproval. brgds, H-P Index: libstdc++-v3/testsuite/20_util/hash/chi2_quality.cc =================================================================== --- libstdc++-v3/testsuite/20_util/hash/chi2_quality.cc (revision 205997) +++ libstdc++-v3/testsuite/20_util/hash/chi2_quality.cc (working copy) @@ -1,7 +1,11 @@ // { dg-options "-std=gnu++0x" } // Use smaller statistics when running on simulators, so it takes less time. -// { dg-options "-std=gnu++0x -DSAMPLES=30000" { target simulator } } +// There's also an issue with "VERIFY( chi2 < k*1.1 )" failing for +// test_uniform_random() and test_bit_flip_set() for SAMPLES=10000 +// and some target library implementations, where 30000 pass. +// { dg-options "-std=gnu++0x -DSAMPLES=30000" { target { { arm*-* } && simulator } } } +// { dg-options "-std=gnu++0x -DSAMPLES=10000" { target simulator } } // Copyright (C) 2010-2013 Free Software Foundation, Inc. //