| Message ID | 20131215121453.05107104@mailhost.lps.ens.fr |
|---|---|
| State | New |
| Headers | show |
On Sun, Dec 15, 2013 at 1:14 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote: >> OTOH, I can't test darwin properly, please provide the patch and I'll >> commit it for you. > > Basically the patch I have in my tree since the PR replace 'linux' with '*' (see below). > Since I can only test darwin, there is no guarantee that the tests pass on non-linux, > non-darwin platforms. So if you apply the patch below as such, it will be necessary to > watch out for fall-out. Let's ask Rainer for help with x86 solaris. Thanks, Uros.
Uros Bizjak <ubizjak@gmail.com> writes: > On Sun, Dec 15, 2013 at 1:14 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote: >>> OTOH, I can't test darwin properly, please provide the patch and I'll >>> commit it for you. >> >> Basically the patch I have in my tree since the PR replace 'linux' with >> *' (see below). >> Since I can only test darwin, there is no guarantee that the tests pass >> on non-linux, >> non-darwin platforms. So if you apply the patch below as such, it will be >> necessary to >> watch out for fall-out. > > Let's ask Rainer for help with x86 solaris. I've just applied Dominique's patch to r206061 and ran the four changed tests on i386-pc-solaris2.10: all of them passed, so from my POV the change is fine. Rainer
On Wed, Dec 18, 2013 at 11:44 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: >> On Sun, Dec 15, 2013 at 1:14 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote: >>>> OTOH, I can't test darwin properly, please provide the patch and I'll >>>> commit it for you. >>> >>> Basically the patch I have in my tree since the PR replace 'linux' with >>> *' (see below). >>> Since I can only test darwin, there is no guarantee that the tests pass >>> on non-linux, >>> non-darwin platforms. So if you apply the patch below as such, it will be >>> necessary to >>> watch out for fall-out. >> >> Let's ask Rainer for help with x86 solaris. > > I've just applied Dominique's patch to r206061 and ran the four changed > tests on i386-pc-solaris2.10: all of them passed, so from my POV the > change is fine. So, the proposed patch (with proper ChangeLog) is OK and preapproved. Thanks, Uros.
diff -up ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2a.c gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2a.c --- ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2a.c 2013-12-15 12:51:02.000000000 +0100 +++ gcc/testsuite/gcc.target/x86_64/abi/callabi/func-2a.c 2013-12-15 12:58:49.000000000 +0100 @@ -1,5 +1,5 @@ /* Test for cross x86_64<->w64 abi standard calls. */ -/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-do run { target i?86-*-* x86_64-*-* } } */ /* { dg-options "-O2 -mabi=ms -std=gnu99 -ffast-math -fno-builtin -maccumulate-outgoing-args" } */ /* { dg-additional-sources "func-2b.c" } */ diff -up ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2a.c gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2a.c --- ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2a.c 2013-12-15 12:51:02.000000000 +0100 +++ gcc/testsuite/gcc.target/x86_64/abi/callabi/func-indirect-2a.c 2013-12-15 12:59:12.000000000 +0100 @@ -1,5 +1,5 @@ /* Test for cross x86_64<->w64 abi standard calls via variable. */ -/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-do run { target i?86-*-* x86_64-*-* } } */ /* { dg-options "-O2 -mabi=ms -std=gnu99 -ffast-math -fno-builtin -maccumulate-outgoing-args" } */ /* { dg-additional-sources "func-indirect-2b.c" } */ diff -up ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4a.c gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4a.c --- ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4a.c 2013-12-15 12:51:02.000000000 +0100 +++ gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-4a.c 2013-12-15 12:59:36.000000000 +0100 @@ -1,5 +1,5 @@ /* Test for cross x86_64<->w64 abi va_list calls. */ -/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-do run { target i?86-*-* x86_64-*-* } } */ /* { dg-options "-O2 -mabi=ms -std=gnu99 -fno-builtin -maccumulate-outgoing-args" } */ /* { dg-additional-sources "vaarg-4b.c" } */ diff -up ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5a.c gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5a.c --- ../_clean/gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5a.c 2013-12-15 12:51:02.000000000 +0100 +++ gcc/testsuite/gcc.target/x86_64/abi/callabi/vaarg-5a.c 2013-12-15 13:00:00.000000000 +0100 @@ -1,5 +1,5 @@ /* Test for cross x86_64<->w64 abi va_list calls. */ -/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-do run { target i?86-*-* x86_64-*-* } } */ /* { dg-options "-O2 -mabi=ms -std=gnu99 -fno-builtin -maccumulate-outgoing-args" } */ /* { dg-additional-sources "vaarg-5b.c" } */