From patchwork Sun Nov 17 14:43:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 291829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 217AE2C00CD for ; Mon, 18 Nov 2013 01:43:51 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=uFdtZPOfbQ8q0eaIC t2wk9E9ciX/wuMncfUIX5fGvoO1Pr4lmc6TvioflXGqRpKwsf4IUX2DVBs2fZIII sPjFCaysJizOraqlzZd2vE9G1Xbiu/cdBGzhJsbabvoGh6XBo7I4Efu96k7DuoS9 FeYHGEla+dejWSx9oAbPW9BHMM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=bZavowDKQ2dK6/uiSZGmGr4 /OuQ=; b=GAciP5dcVl7u+dFeEYQ1wYkbyw0qYzJr7vZLiMkOnyFS5jYt/xf9rcR KjrYEfD3+tdDRVcU/49ZjOz3iGxqyUsr+oLIcm0S0hgshxV1uwr6k5aCsdHXzFAa aqNyX/iKjz2ahebcCCYHuMd4xmsHhyrM4tR9kiBY/NblGep9oDc8= Received: (qmail 32256 invoked by alias); 17 Nov 2013 14:43:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32242 invoked by uid 89); 17 Nov 2013 14:43:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_50, FREEMAIL_FROM, RDNS_NONE, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from Unknown (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 17 Nov 2013 14:43:37 +0000 Received: by mail-pa0-f44.google.com with SMTP id fb1so4007268pad.31 for ; Sun, 17 Nov 2013 06:43:29 -0800 (PST) X-Received: by 10.67.1.101 with SMTP id bf5mr16322861pad.50.1384699409811; Sun, 17 Nov 2013 06:43:29 -0800 (PST) Received: from bubble.grove.modra.org ([101.166.26.37]) by mx.google.com with ESMTPSA id hi5sm17261551pbb.43.2013.11.17.06.43.27 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 17 Nov 2013 06:43:29 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id F0306EA006D; Mon, 18 Nov 2013 01:13:24 +1030 (CST) Date: Mon, 18 Nov 2013 01:13:24 +1030 From: Alan Modra To: David Edelsohn Cc: GCC Patches Subject: Re: [PowerPC] libffi fixes and support for PowerPC64 ELFv2 Message-ID: <20131117144324.GT22514@bubble.grove.modra.org> Mail-Followup-To: David Edelsohn , GCC Patches References: <20131116114805.GJ22514@bubble.grove.modra.org> <20131117062503.GS22514@bubble.grove.modra.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes On Sun, Nov 17, 2013 at 07:53:59AM -0500, David Edelsohn wrote: > On Sun, Nov 17, 2013 at 1:25 AM, Alan Modra wrote: > > On Sat, Nov 16, 2013 at 10:18:05PM +1030, Alan Modra wrote: > >> The following six patches correspond to patches posted to the libffi > >> mailing list a few days ago to add support for PowerPC64 ELFv2. The > > > > The ChangeLog just became easier to write. :) > > > > * src/powerpc/ffitarget.h: Import from upstream. > > * src/powerpc/ffi.c: Likewise. > > * src/powerpc/linux64.S: Likewise. > > * src/powerpc/linux64_closure.S: Likewise. > > * doc/libffi.texi: Likewise. > > * testsuite/libffi.call/cls_double_va.c: Likewise. > > * testsuite/libffi.call/cls_longdouble_va.c: Likewise. > > > > OK to apply? > > Okay. > > Thanks, David Committed revision 204917. I'm also going to apply the following as obvious. The error I'm fixing here doesn't cause a runtime failure, but does mess with the processor return branch prediction. Index: ChangeLog =================================================================== --- ChangeLog (revision 204917) +++ ChangeLog (working copy) @@ -1,5 +1,7 @@ 2013-11-18 Alan Modra + * src/powerpc/ppc_closure.S: Don't bl .Luint128. + * src/powerpc/ffitarget.h: Import from upstream. * src/powerpc/ffi.c: Likewise. * src/powerpc/linux64.S: Likewise. Index: src/powerpc/ppc_closure.S =================================================================== --- src/powerpc/ppc_closure.S (revision 204916) +++ src/powerpc/ppc_closure.S (working copy) @@ -238,7 +238,7 @@ lwz %r3,112+0(%r1) lwz %r4,112+4(%r1) lwz %r5,112+8(%r1) - bl .Luint128 + b .Luint128 # The return types below are only used when the ABI type is FFI_SYSV. # case FFI_SYSV_TYPE_SMALL_STRUCT + 1. One byte struct.