| Message ID | 20131113152714.GH10643@virgil.suse |
|---|---|
| State | New |
| Headers | show |
On Wed, Nov 13, 2013 at 7:27 AM, Martin Jambor <mjambor@suse.cz> wrote: > Hi, > > the testcases I have added for IRA shrink wrapping preparation code > were not intended for -m32 on x86_64 and should not be tested with it, > thus I'm adding lp64 to the target requirements. > > Let me also briefly mention that I would like to make the testcases > also run on ppc64 and therefore I did not put them into > gcc.target/i386. > > I have tested the changes by running > > make -k check RUNTESTFLAGS="dg.exp=ira-shrinkwrap-prep-?.c > --target_board=unix/\{,32\}" and > RUNTESTFLAGS="dg.exp=pr10474.c --target_board=unix/\{,32\}" > > and examining the gcc.sum files. Since this was recommended by Richi > on IRC, I will commit the change in a few minutes. > > Thanks, > > Martin > > > 2013-11-13 Martin Jambor <mjambor@suse.cz> > > * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target > requirements. > * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise. Those 2 pass on x32. > * testsuite/gcc.dg/pr10474.c: Likewise. > This fails on x32. Should it pass on x32?
On Wed, Nov 13, 2013 at 12:41:54PM -0800, H.J. Lu wrote: > On Wed, Nov 13, 2013 at 7:27 AM, Martin Jambor <mjambor@suse.cz> wrote: > > Hi, > > > > the testcases I have added for IRA shrink wrapping preparation code > > were not intended for -m32 on x86_64 and should not be tested with it, > > thus I'm adding lp64 to the target requirements. > > > > Let me also briefly mention that I would like to make the testcases > > also run on ppc64 and therefore I did not put them into > > gcc.target/i386. > > > > I have tested the changes by running > > > > make -k check RUNTESTFLAGS="dg.exp=ira-shrinkwrap-prep-?.c > > --target_board=unix/\{,32\}" and > > RUNTESTFLAGS="dg.exp=pr10474.c --target_board=unix/\{,32\}" > > > > and examining the gcc.sum files. Since this was recommended by Richi > > on IRC, I will commit the change in a few minutes. > > > > Thanks, > > > > Martin > > > > > > 2013-11-13 Martin Jambor <mjambor@suse.cz> > > > > * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target > > requirements. > > * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise. > > Those 2 pass on x32. > > > * testsuite/gcc.dg/pr10474.c: Likewise. > > > > This fails on x32. Should it pass on x32? > I would assume all three should be ignored as UNSUPPORTED on x32 now. How exactly does it fail? Martin
On Wed, Nov 13, 2013 at 4:17 PM, Martin Jambor <mjambor@suse.cz> wrote: > On Wed, Nov 13, 2013 at 12:41:54PM -0800, H.J. Lu wrote: >> On Wed, Nov 13, 2013 at 7:27 AM, Martin Jambor <mjambor@suse.cz> wrote: >> > Hi, >> > >> > the testcases I have added for IRA shrink wrapping preparation code >> > were not intended for -m32 on x86_64 and should not be tested with it, >> > thus I'm adding lp64 to the target requirements. >> > >> > Let me also briefly mention that I would like to make the testcases >> > also run on ppc64 and therefore I did not put them into >> > gcc.target/i386. >> > >> > I have tested the changes by running >> > >> > make -k check RUNTESTFLAGS="dg.exp=ira-shrinkwrap-prep-?.c >> > --target_board=unix/\{,32\}" and >> > RUNTESTFLAGS="dg.exp=pr10474.c --target_board=unix/\{,32\}" >> > >> > and examining the gcc.sum files. Since this was recommended by Richi >> > on IRC, I will commit the change in a few minutes. >> > >> > Thanks, >> > >> > Martin >> > >> > >> > 2013-11-13 Martin Jambor <mjambor@suse.cz> >> > >> > * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target >> > requirements. >> > * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise. >> >> Those 2 pass on x32. >> >> > * testsuite/gcc.dg/pr10474.c: Likewise. >> > >> >> This fails on x32. Should it pass on x32? >> > > I would assume all three should be ignored as UNSUPPORTED on x32 now. The first 2 passed before this checkin. > How exactly does it fail? > I got FAIL: gcc.dg/pr10474.c scan-rtl-dump pro_and_epilogue "Performing shrink-wrapping" with make check-gcc RUNTESTFLAGS="--target_board='unix{-mx32}' dg.exp=pr10474.c" before your checkin.
diff --git a/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-1.c b/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-1.c index 16095e3..4fc00b2 100644 --- a/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-1.c +++ b/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-1.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target x86_64-*-* } } */ +/* { dg-do compile { target { x86_64-*-* && lp64 } } } */ /* { dg-options "-O3 -fdump-rtl-ira -fdump-rtl-pro_and_epilogue" } */ int __attribute__((noinline, noclone)) diff --git a/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c b/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c index 2b00c5b..bb725e1 100644 --- a/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c +++ b/gcc/testsuite/gcc.dg/ira-shrinkwrap-prep-2.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target x86_64-*-* } } */ +/* { dg-do compile { target { x86_64-*-* && lp64 } } } */ /* { dg-options "-O3 -fdump-rtl-ira -fdump-rtl-pro_and_epilogue" } */ int __attribute__((noinline, noclone)) diff --git a/gcc/testsuite/gcc.dg/pr10474.c b/gcc/testsuite/gcc.dg/pr10474.c index 4fcd75d..08324d8 100644 --- a/gcc/testsuite/gcc.dg/pr10474.c +++ b/gcc/testsuite/gcc.dg/pr10474.c @@ -1,4 +1,4 @@ -/* { dg-do compile { target x86_64-*-* } } */ +/* { dg-do compile { target { x86_64-*-* && lp64 } } } */ /* { dg-options "-O3 -fdump-rtl-pro_and_epilogue" } */ void f(int *i)
Hi, the testcases I have added for IRA shrink wrapping preparation code were not intended for -m32 on x86_64 and should not be tested with it, thus I'm adding lp64 to the target requirements. Let me also briefly mention that I would like to make the testcases also run on ppc64 and therefore I did not put them into gcc.target/i386. I have tested the changes by running make -k check RUNTESTFLAGS="dg.exp=ira-shrinkwrap-prep-?.c --target_board=unix/\{,32\}" and RUNTESTFLAGS="dg.exp=pr10474.c --target_board=unix/\{,32\}" and examining the gcc.sum files. Since this was recommended by Richi on IRC, I will commit the change in a few minutes. Thanks, Martin 2013-11-13 Martin Jambor <mjambor@suse.cz> * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target requirements. * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise. * testsuite/gcc.dg/pr10474.c: Likewise.