From patchwork Wed Jul 31 09:36:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan-Benedict Glaw X-Patchwork-Id: 263645 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0DC042C008A for ; Wed, 31 Jul 2013 19:37:11 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=NZo7wdTRPk6LrqgQO YA6C9izIQ5+Gk3cSsEKuXr8QY9WpqKSqtq7riaDqcZNX6z1LciwMuNJ0BGR8JwUA wa+5X9cAs/rb6hc09CnDGxdlhkOceQPnc5mPwIvB9kLeqfr7lRJPFr5jR+jFqdyi FcSs7U57TOjSz9yQJkP3JxK0yU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=dcT8k5ulL1MNZlBw3vPhqxJ vByU=; b=lbKAgKI7juGDz+aAGGpOkacdQw4VuKRfhkRI4PXzZVIN59ZX465qO9r aTHMTmbdTmjVgcrNDFirTIIJ+uab/vJJejTC7AuIqmN9kmp5KqmW5g99HPuVRuzw mIreZtQIY3Zov67wjiGfH/tdGY/cUWQLdz7HojcrGQS6M88mZxQM= Received: (qmail 1642 invoked by alias); 31 Jul 2013 09:37:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 1618 invoked by uid 89); 31 Jul 2013 09:37:02 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_50, KHOP_PGP_SIGNED, RDNS_NONE autolearn=no version=3.3.1 Received: from Unknown (HELO lug-owl.de) (195.71.106.12) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 31 Jul 2013 09:37:01 +0000 Received: by lug-owl.de (Postfix, from userid 1001) id 4D560F071E; Wed, 31 Jul 2013 11:36:53 +0200 (CEST) Date: Wed, 31 Jul 2013 11:36:53 +0200 From: Jan-Benedict Glaw To: David Malcolm Cc: Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: Build broken (was: [PATCH 02/11] Generate pass-instances.def) Message-ID: <20130731093653.GN5610@lug-owl.de> References: <1374851081-32153-1-git-send-email-dmalcolm@redhat.com> <1374851081-32153-3-git-send-email-dmalcolm@redhat.com> <51F6CA09.1070003@redhat.com> <1375231827.28238.14.camel@surprise> <20130731083410.GL5610@lug-owl.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20130731083410.GL5610@lug-owl.de> X-gpg-fingerprint: 250D 3BCF 7127 0D8C A444 A961 1DBD 5E75 8399 E1BB X-gpg-key: wwwkeys.de.pgp.net X-Echelon-Enable: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll X-TKUeV: howto poison arsenous mail psychological biological nuclear warfare test the bombastical terror of flooding the spy listeners explosion sex drugs and rock'n'roll User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Found: No On Wed, 2013-07-31 10:34:10 +0200, Jan-Benedict Glaw wrote: > On Tue, 2013-07-30 20:50:27 -0400, David Malcolm wrote: > [...] > > Committed to trunk as r201359, having double-checked that it > > bootstrapped by itself on top of what had gone before, and that the > > testsuite results were unaffected by it (on x86_64-unknown-linux-gnu). > > [...] > mawk -f ../../../../gcc/gcc/gen-pass-instances.awk \ > ../../../../gcc/gcc/passes.def > pass-instances.def [...] > It seems this does only happen on one of the three running build > clients. That one is using `mawk' instead of `gawk', what the two > other builders (which are not affected) use. The substr() was wrong, awk starts all its indices with 1, while the script used 0. gawk ignores this, mawk starts the substring at 1, but counts from 0 upwards. Fixed as trivial: 2013-07-31 Jan-Benedict Glaw * gen-pass-instances.awk: Fix offset of substr(). MfG, JBG Index: gcc/gen-pass-instances.awk =================================================================== --- gcc/gen-pass-instances.awk (revision 201363) +++ gcc/gen-pass-instances.awk (working copy) @@ -55,7 +55,7 @@ else pass_counts[pass_name] = 1; printf "%s, %s%s\n", - substr(line, 0, pass_starts_at + len_of_pass_name - 1), + substr(line, 1, pass_starts_at + len_of_pass_name - 1), pass_counts[pass_name], substr(line, pass_starts_at + len_of_pass_name); } else {