From patchwork Tue Feb 5 15:44:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 218282 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 5AB6E2C02A4 for ; Wed, 6 Feb 2013 02:45:20 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1360683920; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Date:From:To:Cc:Subject:Message-ID:Reply-To: MIME-Version:Content-Type:Content-Disposition:User-Agent: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=37VYUzFm857IVYaZ2DUf ZzCw6n8=; b=kMW1qi7tXKAXolgPJNYL4y9ESrN4SmvI8+6+G8HQmM7hMoIw4hiw GFROHck1jLCZt1ARw3TTkjMVEVLitRh/zhPPjDK++NvaL6y92qI4EM8Vblx2WjOX zbgf0G/hsZIUUeQ/4jeiH2bkvSFHf55U67GKKcDralV2uIp4NKwKbWg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:Reply-To:MIME-Version:Content-Type:Content-Disposition:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=BCmcAZhtzrC9snW8qgFDTT+jsRm4dIjwBEip2YAln2bKjjF6Kwt4OM3O+i16sK jdyq/93D+QaXxKAjtwEkY8s7AsmFCl94YupTaqF6JoxEe6G8RXWYNaZ3q5ga3CV9 7Y4kqSbrVn9KB35OfCDTPXumOgMmCfjsLvOYAcXLy7sd0=; Received: (qmail 5034 invoked by alias); 5 Feb 2013 15:44:55 -0000 Received: (qmail 4934 invoked by uid 22791); 5 Feb 2013 15:44:54 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Feb 2013 15:44:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r15Fiesx025781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 5 Feb 2013 10:44:40 -0500 Received: from zalov.redhat.com (vpn1-5-10.ams2.redhat.com [10.36.5.10]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r15FiZxs025321 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 5 Feb 2013 10:44:38 -0500 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.redhat.com (8.14.5/8.14.5) with ESMTP id r15FiY5u004302; Tue, 5 Feb 2013 16:44:34 +0100 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r15FiWdt004301; Tue, 5 Feb 2013 16:44:32 +0100 Date: Tue, 5 Feb 2013 16:44:31 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Remove unused tree_decl_with_vis field - thread_local Message-ID: <20130205154431.GN4385@tucnak.redhat.com> Reply-To: Jakub Jelinek MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi! Got a bugreport that gcc plugins can't be compiled with -std=c++11, seems the reason why not is badly named bitfield that is never used anyway. From what I've seen in CVS history, thread_local_flag was first removed by 2005-06-30 Steven Bosscher * tree.h (struct tree_decl): New field `tls_model'. (DECL_TLS_MODEL): New. (DECL_THREAD_LOCAL_P): Rename from DECL_THREAD_LOCAL, make it a predicate. (DECL_THREAD_LOCAL_P tests tls_model since then), but later on reappeared 2005-07-08 Daniel Berlin ... (struct tree_decl_minimal): New structure. (struct tree_decl_common): Ditto. (struct tree_decl_with_rtl): Ditto. (struct tree_decl_with_vis): Ditto. supposedly because that patch has been written already before the 2005-06-30 change and didn't take the removal into account properly. So, this patch just removes that unused bitfield. Ok for trunk? 2013-02-05 Jakub Jelinek * tree.h (struct tree_decl_with_vis): Remove thread_local field. Jakub --- gcc/tree.h.jj 2013-01-11 09:02:33.000000000 +0100 +++ gcc/tree.h 2013-02-05 15:27:30.331437092 +0100 @@ -3198,13 +3198,14 @@ struct GTY(()) tree_decl_with_vis { /* Belong to VAR_DECL exclusively. */ unsigned defer_output : 1; unsigned hard_register : 1; - unsigned thread_local : 1; unsigned common_flag : 1; unsigned in_text_section : 1; unsigned in_constant_pool : 1; unsigned dllimport_flag : 1; /* Don't belong to VAR_DECL exclusively. */ unsigned weak_flag : 1; + /* When SECTION_NAME is implied by -ffunction-section. */ + unsigned implicit_section_name_p : 1; unsigned seen_in_bind_expr : 1; unsigned comdat_flag : 1; @@ -3217,9 +3218,7 @@ struct GTY(()) tree_decl_with_vis { unsigned init_priority_p : 1; /* Used by C++ only. Might become a generic decl flag. */ unsigned shadowed_for_var_p : 1; - /* When SECTION_NAME is implied by -ffunsection-section. */ - unsigned implicit_section_name_p : 1; - /* 13 unused bits. */ + /* 14 unused bits. */ }; extern tree decl_debug_expr_lookup (tree);