Message ID | 20121018190834.1806A3BABA@mailhost.lps.ens.fr |
---|---|
State | New |
Headers | show |
On Oct 18, 2012, at 12:08 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote: > --- gcc/config/rs6000/rs6000.c 2012-10-18 00:34:51.000000000 +0200 > +++ ../work/gcc/config/rs6000/rs6000.c 2012-10-18 08:55:28.000000000 +0200 > @@ -1123,6 +1123,7 @@ static const struct attribute_spec rs600 > > > #ifndef OPTION_MASK_STRICT_ALIGN > #define OPTION_MASK_STRICT_ALIGN 0 > +#undef MASK_STRICT_ALIGN > #define MASK_STRICT_ALIGN 0 > #endif > #ifndef TARGET_PROFILE_KERNEL > > I don't know if it is the RIGHT FIX, but it worked. Given the context, I'd guess #ifndef MASK_STRICT_ALIGN would be the incantation people want.
On Thu, Oct 18, 2012 at 09:08:34PM +0200, Dominique Dhumieres wrote: > > 2012-10-17 Michael Meissner <meissner@linux.vnet.ibm.com> > > > > * config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to > > replace target_flags that gives us 63 possible switches. > > (x_rs6000_isa_flags): Save area for rs6000_isa_flags. > > (x_rs6000_isa_flags_explicit): Save area for > > ... > > Bootstrap failed on powerpc-apple-darwin9 with Just to let you know, I'm iterating on a patch right now. There were 3 bugs with my checkin: 1) The libobjc/encoding.c issue that Eric ran into. The file encoding.c includes compiler tm.h files, and then redefines stuff so that it doesn't need the target option structure. I have a bandaid to redefine TARGET_VSX, TARGET_ALTIVEC, and TARGET_64BIT, but this file really cries out for an Objective C user to reengineer and rewrite it so that it doesn't have to include compiler internal files. 2) The redefinition problem that Dominique found. This was caused by moving POWERPC_MASKS from rs6000.c to rs6000-cpus.def, where it more logically belongs. I think the right solution is to move the #ifdef to rs6000-cpus.def instead of keeping it in rs6000.c. 3) I forgot to update the -mdebug=reg support so it prints out the current options once I swtiched from using target_flags to rs6000_isa_flags. I discovered this today, when doing some future work (that needs new options). I'll send out the patch if my bootstrap finishes.
--- gcc/config/rs6000/rs6000.c 2012-10-18 00:34:51.000000000 +0200 +++ ../work/gcc/config/rs6000/rs6000.c 2012-10-18 08:55:28.000000000 +0200 @@ -1123,6 +1123,7 @@ static const struct attribute_spec rs600 #ifndef OPTION_MASK_STRICT_ALIGN #define OPTION_MASK_STRICT_ALIGN 0 +#undef MASK_STRICT_ALIGN #define MASK_STRICT_ALIGN 0 #endif