| Message ID | 20120920085318.GR1265@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Sep 20, 2012 at 10:53 AM, Marek Polacek <polacek@redhat.com> wrote: > While reading tree-ssa-threadupdate.c I noticed that we're casting > XNEWVEC's result. This isn't done anywhere else and the macro > does the cast internally anyway, thus there's no need to repeat that. > Also there was a typo in copyright years, so I fixed that as well > while at it. Regtested/bootstrapped on x86_64. Ok. Thanks, Richard. > 2012-09-19 Marek Polacek <polacek@redhat.com> > > * tree-ssa-threadupdate.c (mark_threaded_blocks): Don't cast XNEWVEC's > result. > (create_edge_and_update_destination_phis): Likewise. > > --- gcc/tree-ssa-threadupdate.c.mp 2012-09-19 20:12:49.711262969 +0200 > +++ gcc/tree-ssa-threadupdate.c 2012-09-19 20:17:42.427287843 +0200 > @@ -1,5 +1,5 @@ > /* Thread edges through blocks and update the control flow and SSA graphs. > - Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010, 201 > + Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010, 2011, 2012 > Free Software Foundation, Inc. > > This file is part of GCC. > @@ -362,7 +362,7 @@ create_edge_and_update_destination_phis > > if (rd->outgoing_edge->aux) > { > - e->aux = (edge *) XNEWVEC (edge, 2); > + e->aux = XNEWVEC (edge, 2); > THREAD_TARGET(e) = THREAD_TARGET (rd->outgoing_edge); > THREAD_TARGET2(e) = THREAD_TARGET2 (rd->outgoing_edge); > } > @@ -1143,7 +1143,7 @@ mark_threaded_blocks (bitmap threaded_bl > for (i = 0; i < VEC_length (edge, threaded_edges); i += 3) > { > edge e = VEC_index (edge, threaded_edges, i); > - edge *x = (edge *) XNEWVEC (edge, 2); > + edge *x = XNEWVEC (edge, 2); > > e->aux = x; > THREAD_TARGET (e) = VEC_index (edge, threaded_edges, i + 1); > > Marek
--- gcc/tree-ssa-threadupdate.c.mp 2012-09-19 20:12:49.711262969 +0200 +++ gcc/tree-ssa-threadupdate.c 2012-09-19 20:17:42.427287843 +0200 @@ -1,5 +1,5 @@ /* Thread edges through blocks and update the control flow and SSA graphs. - Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010, 201 + Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010, 2011, 2012 Free Software Foundation, Inc. This file is part of GCC. @@ -362,7 +362,7 @@ create_edge_and_update_destination_phis if (rd->outgoing_edge->aux) { - e->aux = (edge *) XNEWVEC (edge, 2); + e->aux = XNEWVEC (edge, 2); THREAD_TARGET(e) = THREAD_TARGET (rd->outgoing_edge); THREAD_TARGET2(e) = THREAD_TARGET2 (rd->outgoing_edge); } @@ -1143,7 +1143,7 @@ mark_threaded_blocks (bitmap threaded_bl for (i = 0; i < VEC_length (edge, threaded_edges); i += 3) { edge e = VEC_index (edge, threaded_edges, i); - edge *x = (edge *) XNEWVEC (edge, 2); + edge *x = XNEWVEC (edge, 2); e->aux = x; THREAD_TARGET (e) = VEC_index (edge, threaded_edges, i + 1);