| Message ID | 20120824140454.GA15563@bromo.med.uc.edu |
|---|---|
| State | New |
| Headers | show |
Jack Howarth <howarth@bromo.med.uc.edu> writes: > Currently the new testcase for gcc.target/i386/pr53249.c is failing > on darwin due to the absence of -mx32 support on that target. The following > patch skips this testcase on darwin. Tested on x86_64-apple-darwin12... This also fails on Solaris/x86 (cf. PR testsuite/53365) and i686-unknown-linux-gnu. I'd strongly prefer if HJ could devise a real fix instead of just skipping the test on an explicit list of systems. Rainer
On Fri, Aug 24, 2012 at 7:13 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > Jack Howarth <howarth@bromo.med.uc.edu> writes: > >> Currently the new testcase for gcc.target/i386/pr53249.c is failing >> on darwin due to the absence of -mx32 support on that target. The following >> patch skips this testcase on darwin. Tested on x86_64-apple-darwin12... > > This also fails on Solaris/x86 (cf. PR testsuite/53365) and > i686-unknown-linux-gnu. I'd strongly prefer if HJ could devise a real > fix instead of just skipping the test on an explicit list of systems. > x32 code generation is mostly platform independent, except for TLS support. We can limit x32 TLS tests to Linux.
Index: gcc/testsuite/gcc.target/i386/pr53249.c =================================================================== --- gcc/testsuite/gcc.target/i386/pr53249.c (revision 190647) +++ gcc/testsuite/gcc.target/i386/pr53249.c (working copy) @@ -1,4 +1,4 @@ -/* { dg-do compile { target { ! { ia32 } } } } */ +/* { dg-do compile { target { { ! { ia32 } } && { ! *-*-darwin* } } } } */ /* { dg-options "-O2 -mx32 -ftls-model=initial-exec -maddress-mode=short" } */ struct gomp_task
Currently the new testcase for gcc.target/i386/pr53249.c is failing on darwin due to the absence of -mx32 support on that target. The following patch skips this testcase on darwin. Tested on x86_64-apple-darwin12... http://gcc.gnu.org/ml/gcc-testresults/2012-08/msg02042.html Okay for gcc trunk? Jack 2012-08-24 Dominique d'Humieres <dominiq@lps.ens.ft> Jack Howarth <howarth@bromo.med.uc.edu> PR target/54257 * gcc.target/i386/pr53249.c: Skip on darwin.