Message ID | 20120713120054.GC3468@redhat.com |
---|---|
State | New |
Headers | show |
Ping. On Fri, Jul 13, 2012 at 02:00:54PM +0200, Marek Polacek wrote: > I think the comment at the start of the file is wrong, since > it speaks about varpool_finalize_variable, but there's no such > function (not even mentioned in CLs). I'd say the author meant > varpool_finalize_decl. > > 2012-07-13 Marek Polacek <polacek@redhat.com> > > * cgraphunit.c: Rename varpool_finalize_variable to > varpool_finalize_decl in a comment. > > --- gcc/cgraphunit.c.mp 2012-07-13 13:49:41.071591575 +0200 > +++ gcc/cgraphunit.c 2012-07-13 13:49:50.715613502 +0200 > @@ -34,7 +34,7 @@ along with GCC; see the file COPYING3. > (There is one exception needed for implementing GCC extern inline > function.) > > - - varpool_finalize_variable > + - varpool_finalize_decl > > This function has same behavior as the above but is used for static > variables. > > Marek
On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek <polacek@redhat.com> wrote: > Ping. Ok. Thanks, Richard. > On Fri, Jul 13, 2012 at 02:00:54PM +0200, Marek Polacek wrote: >> I think the comment at the start of the file is wrong, since >> it speaks about varpool_finalize_variable, but there's no such >> function (not even mentioned in CLs). I'd say the author meant >> varpool_finalize_decl. >> >> 2012-07-13 Marek Polacek <polacek@redhat.com> >> >> * cgraphunit.c: Rename varpool_finalize_variable to >> varpool_finalize_decl in a comment. >> >> --- gcc/cgraphunit.c.mp 2012-07-13 13:49:41.071591575 +0200 >> +++ gcc/cgraphunit.c 2012-07-13 13:49:50.715613502 +0200 >> @@ -34,7 +34,7 @@ along with GCC; see the file COPYING3. >> (There is one exception needed for implementing GCC extern inline >> function.) >> >> - - varpool_finalize_variable >> + - varpool_finalize_decl >> >> This function has same behavior as the above but is used for static >> variables. >> >> Marek
On Wed, Jul 25, 2012 at 01:43:59PM +0200, Richard Guenther wrote: > On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek <polacek@redhat.com> wrote: > > Ping. > > Ok. Sorry, can't commit myself. Thanks, Marek
On Fri, Jul 27, 2012 at 1:44 PM, Marek Polacek <polacek@redhat.com> wrote: > On Wed, Jul 25, 2012 at 01:43:59PM +0200, Richard Guenther wrote: >> On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek <polacek@redhat.com> wrote: >> > Ping. >> >> Ok. > > Sorry, can't commit myself. Thanks, Committed. Richard. > Marek
--- gcc/cgraphunit.c.mp 2012-07-13 13:49:41.071591575 +0200 +++ gcc/cgraphunit.c 2012-07-13 13:49:50.715613502 +0200 @@ -34,7 +34,7 @@ along with GCC; see the file COPYING3. (There is one exception needed for implementing GCC extern inline function.) - - varpool_finalize_variable + - varpool_finalize_decl This function has same behavior as the above but is used for static variables.