| Message ID | 20120531201209.GA31043@redhat.com |
|---|---|
| State | New |
| Headers | show |
Ping. On Thu, May 31, 2012 at 10:12:09PM +0200, Marek Polacek wrote: > The new mklog script prints three spaces after the date part, which > is wrong. Thus fixed by adjusting the split pattern. Tested manually. > > 2012-05-31 Marek Polacek <polacek@redhat.com> > > * mklog: Prevent printing three spaces after the date. > > --- gcc/contrib/mklog.mp 2012-05-31 22:03:07.492457065 +0200 > +++ gcc/contrib/mklog 2012-05-31 22:03:21.824493596 +0200 > @@ -29,7 +29,7 @@ > # Change these settings to reflect your profile. > $username = $ENV{'USER'}; > $name = `finger $username | grep -o 'Name: .*'`; > -@n = split(/:/, $name); > +@n = split(/: /, $name); > $name = @n[1]; chop($name); > $addr = $username . "\@my.domain.org"; > $date = `date +%Y-%m-%d`; chop ($date); > > Marek
On Thu, May 31, 2012 at 4:12 PM, Marek Polacek <polacek@redhat.com> wrote: > 2012-05-31 Marek Polacek <polacek@redhat.com> > > * mklog: Prevent printing three spaces after the date. OK. Diego.
On Wed, Jun 06, 2012 at 07:09:08AM -0400, Diego Novillo wrote: > On Thu, May 31, 2012 at 4:12 PM, Marek Polacek <polacek@redhat.com> wrote: > > > 2012-05-31 Marek Polacek <polacek@redhat.com> > > > > * mklog: Prevent printing three spaces after the date. > > OK. Sorry, I don't have commit rights, so I'm not able to apply this one myself. Thanks, Marek
On Wed, Jun 6, 2012 at 8:44 AM, Marek Polacek <polacek@redhat.com> wrote: > Sorry, I don't have commit rights, so I'm not able to apply this > one myself. Thanks, Committed rev 188265. Thanks for the fix. Diego.
--- gcc/contrib/mklog.mp 2012-05-31 22:03:07.492457065 +0200 +++ gcc/contrib/mklog 2012-05-31 22:03:21.824493596 +0200 @@ -29,7 +29,7 @@ # Change these settings to reflect your profile. $username = $ENV{'USER'}; $name = `finger $username | grep -o 'Name: .*'`; -@n = split(/:/, $name); +@n = split(/: /, $name); $name = @n[1]; chop($name); $addr = $username . "\@my.domain.org"; $date = `date +%Y-%m-%d`; chop ($date);