| Message ID | 20120418191126.456792461AF@ruffy.mtv.corp.google.com |
|---|---|
| State | New |
| Headers | show |
Hi Doug, > 2012-04-18 Doug Evans<dje@google.com> > > * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index. Approved - please apply. Cheers Nick
On Wed, Apr 18, 2012 at 12:11 PM, Doug Evans <dje@google.com> wrote: > Hi. > > This patch adds DW_OP_GNU_addr_index to dwarf2.h. > > Ok to commit? > > 2012-04-18 Doug Evans <dje@google.com> > > * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index. > > Index: include/dwarf2.h > =================================================================== > RCS file: /cvs/src/src/include/dwarf2.h,v > retrieving revision 1.28 > diff -u -p -r1.28 dwarf2.h > --- include/dwarf2.h 26 Jan 2012 22:57:17 -0000 1.28 > +++ include/dwarf2.h 18 Apr 2012 17:37:23 -0000 > @@ -578,6 +578,8 @@ enum dwarf_location_atom > DW_OP_GNU_reinterpret = 0xf9, > /* The GNU parameter ref extension. */ > DW_OP_GNU_parameter_ref = 0xfa, > + /* Extension for Fission. See http://gcc.gnu.org/wiki/DebugFission. */ > + DW_OP_GNU_addr_index = 0xfb, > /* HP extensions. */ > DW_OP_HP_unknown = 0xe0, /* Ouch, the same as GNU_push_tls_address. */ > DW_OP_HP_is_value = 0xe1, Ping. This is approved on the binutils side. I just need approval on the gcc side.
> Ping. > This is approved on the binutils side. > I just need approval on the gcc side. My understanding is that a patch to sync binutils/include and gcc/include falls under the "trivial and obvious" rule. True? -cary
On Wed, Apr 25, 2012 at 04:56:17PM -0700, Doug Evans wrote: > On Wed, Apr 18, 2012 at 12:11 PM, Doug Evans <dje@google.com> wrote: > > This patch adds DW_OP_GNU_addr_index to dwarf2.h. > > > > Ok to commit? > > > > 2012-04-18 Doug Evans <dje@google.com> > > > > * dwarf2.h (dwarf_location_atom): Add DW_OP_GNU_addr_index. Ok for GCC. Just a note, we should use 0xff as a GNU opcode escape or something similar (i.e. 0xff <uleb128> <operands> would be extended opcode) when we reach that, because we are close to running out of the available range (well, we could use some 0xeN values too). Jakub
Index: include/dwarf2.h =================================================================== RCS file: /cvs/src/src/include/dwarf2.h,v retrieving revision 1.28 diff -u -p -r1.28 dwarf2.h --- include/dwarf2.h 26 Jan 2012 22:57:17 -0000 1.28 +++ include/dwarf2.h 18 Apr 2012 17:37:23 -0000 @@ -578,6 +578,8 @@ enum dwarf_location_atom DW_OP_GNU_reinterpret = 0xf9, /* The GNU parameter ref extension. */ DW_OP_GNU_parameter_ref = 0xfa, + /* Extension for Fission. See http://gcc.gnu.org/wiki/DebugFission. */ + DW_OP_GNU_addr_index = 0xfb, /* HP extensions. */ DW_OP_HP_unknown = 0xe0, /* Ouch, the same as GNU_push_tls_address. */ DW_OP_HP_is_value = 0xe1,