From patchwork Thu Jan 19 22:45:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sterling Augustine X-Patchwork-Id: 136914 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 70721B6F99 for ; Fri, 20 Jan 2012 09:45:24 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1327617925; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Received:Received:To:Subject:Message-Id:Date: From:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=66ASm4h WVIJC2UqPhkJCntFNZN4=; b=EN+ryuTKYpqScwNK7DG/aRQvkRMwJY9+jXFWNch zUDpxPHuqJe6yJEt8fqLpoyMA69JF/aS4rpPIleqPVL6ezRLtuJL9PWbnmm6J3E5 Q8K0nNsVRX8CWXj5vSeZjqyAPeBL6ARRdGN/W6CXOEQO+q4TFBRSGE8jMeyLxxQs R+h0= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Received:Received:To:Subject:Message-Id:Date:From:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=B2/GTtzx1eP9w7E4LAwMvMLvUqHBHELZ1GAVVjI0NlE0IZgt+NZCGYnqICRFCE zmJJQPkvlvM1kMnlSYWOWjAmMC8ay+8dpa2nPFf518aUe7WsEIjo3QuwZT7lHK5i hQVMsmOmKYjeJDH6cVnIYPe1whC542bVMW/XgIfY/hz0I=; Received: (qmail 29549 invoked by alias); 19 Jan 2012 22:45:17 -0000 Received: (qmail 29538 invoked by uid 22791); 19 Jan 2012 22:45:15 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-yx0-f201.google.com (HELO mail-yx0-f201.google.com) (209.85.213.201) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 22:45:02 +0000 Received: by yenl2 with SMTP id l2so49607yen.2 for ; Thu, 19 Jan 2012 14:45:01 -0800 (PST) Received: by 10.101.146.14 with SMTP id y14mr2585318ann.6.1327013101433; Thu, 19 Jan 2012 14:45:01 -0800 (PST) Received: by 10.101.146.14 with SMTP id y14mr2585308ann.6.1327013101336; Thu, 19 Jan 2012 14:45:01 -0800 (PST) Received: from wpzn4.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id n75si434022yhe.3.2012.01.19.14.45.01 (version=TLSv1/SSLv3 cipher=AES128-SHA); Thu, 19 Jan 2012 14:45:01 -0800 (PST) Received: from sterling.mtv.corp.google.com (sterling.mtv.corp.google.com [172.18.111.14]) by wpzn4.hot.corp.google.com (Postfix) with ESMTP id 380B51E005A; Thu, 19 Jan 2012 14:45:01 -0800 (PST) Received: by sterling.mtv.corp.google.com (Postfix, from userid 135279) id C8231160ABD; Thu, 19 Jan 2012 14:45:00 -0800 (PST) To: reply@codereview.appspotmail.com,gcc-patches@gcc.gnu.org Subject: [google-main] Add DW_AT_GNU_pubtypes and DW_AT_GNU_pubnames to comdat type units. (issue5553069) Message-Id: <20120119224500.C8231160ABD@sterling.mtv.corp.google.com> Date: Thu, 19 Jan 2012 14:45:00 -0800 (PST) From: saugustine@google.com (Sterling Augustine) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org commit de9e01e3b50f75bcd47da9d32ab0691c65094df5 Author: Sterling Augustine Date: Thu Jan 19 14:31:14 2012 -0800 Add DW_AT_GNU_pubtypes and Add DW_AT_GNU_pubnames to comdat type dies. M gcc/dwarf2out.c Tested: Via make check-c and make check-c++. No new issues found. ChangeLog: 2012-01-19 Sterling Augustine * gcc/dwarf2out.c (break_out_comdat_types): Call add_AT_lineptr with DW_AT_GNU_pubnames and DW_AT_GNU_pubtypes. --- This patch is available for review at http://codereview.appspot.com/5553069 diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index 57f18ad..3e34354 100644 --- a/gcc/dwarf2out.c +++ b/gcc/dwarf2out.c @@ -7287,6 +7287,15 @@ break_out_comdat_types (dw_die_ref die) type_node->root_die = unit; type_node->next = comdat_type_list; comdat_type_list = type_node; + if (targetm.want_debug_pub_sections) + { + /* FIXME: Should use add_AT_pubnamesptr. This works because most + targets don't care what the base section is. */ + add_AT_lineptr (unit, DW_AT_GNU_pubnames, + debug_pubnames_section_label); + add_AT_lineptr (unit, DW_AT_GNU_pubtypes, + debug_pubtypes_section_label); + } /* Generate the type signature. */ generate_type_signature (c, type_node);