[RFC] Builtin infrastructure change

On Mon, Sep 26, 2011 at 04:40:01PM +0200, Richard Guenther wrote:
> On Wed, Sep 14, 2011 at 10:38 PM, Richard Henderson <rth@redhat.com> wrote:
> > On 09/13/2011 04:27 PM, Michael Meissner wrote:
> >> This patch touches a bunch of files, but most of the changes are fairly
> >> mechanical.  What this does is change the infrastructure of how machine
> >> independent builtin functions are handled.  At this point, there is no change
> >> to the compiler from a user perspective.  Instead of having two parallel arrays
> >> that have tree pointers for built-in functions:
> >>
> >>       built_in_decls
> >>       implicit_built_in_decls
> >>
> >> I have replaced these by two macros that call inline functions:
> >>
> >>       BUILT_IN_DECLS
> >>       IMPLICIT_BUILT_IN_DECLS
> >>
> >> and changed the other parts that want to modify the builtins.  By changing it
> >> to a functional approach instead of an array, we can more easily change the
> >> code underneath.
> > 
> > Why bother with the case change and poisoning?  Merely changing the type of
> > the symbol from object to function ought to be sufficient to catch all
> > users at compile time.
> >
> > I say this because I'm not keen on functions using all-caps names...
> 
> Yeah, I agree.
> 
> Richard.

I've reworked the patch to just change the arrays into functions, and it did
catch Jakub's on the 27th that touched the arrays when I merged up my tree to
subversion id 179369 yesterday.

Now, the reason why I was doing the abstraction was to answer some long
standing gripes that all of the builtin functions must be created when the
compiler starts up, and that takes extra space and memory.  At the moment, we
have 739 standard builtins, 1,002 builtins in the x86 port, and 954 builtins in
the PowerPC.  I am in the process of doing the next step that allocates all of
the standard builtins n a lazy fashion, and I'm wondering whether it will make
enough of a different to worry about.  With my current sources, I save about
716 kilobytes by not building the standard builtin declarations on a dummy
program.  I would expect then that the x86 might save 1.6 megabytes, and the
powerpc 1.5 megabytes.  At the moment, I am not building the function and
attributes on demand, so we might see a little more savings from that,
particularly with all of the machine builtins with all sorts of types.

Is this enough of a savings to continue on?  I'm of two minds about it, one is
that a savings is a savings, and it would help a little bit for overloaded
systems, and on the other hand, once you get to compiling larger programs, I'm
not sure you would notice.  If people don't think it is worthwhile, I can stop
work on lazy builtins.  I would like to submit the infrastructure change in any
case (unless the global reviewer and release managers are against it).

The way my new stuff works, is instead of creating the decl, it just marks the
identifier node, remembering the builtin function index in the identifier node
itself (using a combination of the RID keyword byte and the address_space byte
that is in every identifier).  Then when the lexer sees the identifier, it
calls the langhook to actually create the builtin and link it in.  Right now, I
need to track down to make sure this new declaration does not trigger the
implicit redeclaration warning, and add similar support to C++.

Here are the patches for just the infrastructure change that should be similar
to my previous patches.  Are there any other comments on these patches.

[gcc]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* tree.h (built_in_decls): Change builtin interface from being an
	array to an inline function for both normal and implicit builtin
	functions.  Change all read references to built_in_decls and
	implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl and built_in_set_implicit.
	(implicit_built_in_decls): Ditto.
	(struct built_in_decl_info): Ditto.
	(built_in_info): Ditto.
	(built_in_get_decl): Ditto.
	(built_in_set_decl): Ditto.
	(built_in_set_decl_add): Ditto.
	(built_in_set_implicit): Ditto.
	* tree.c (iterative_hash_expr): Ditto.
	(local_define_builtin): Ditto.
	(build_common_builtin_nodes): Ditto.
	* tree-complex.c (expand_complex_libcall): Ditto.
	* tree-loop-distribution.c (generate_memset_zero): Ditto.
	* builtins.c (built_in_info): Ditto.
	(built_in_decls): Ditto.
	(implicit_built_in_decls): Ditto.
	(mathfn_built_in_1): Ditto.
	(expand_builtin_cexpi): Ditto.
	(expand_builtin_mempcpy_args): Ditto.
	(expand_builtin_stpcpy): Ditto.
	(gimplify_va_arg_expr): Ditto.
	(expand_builtin_sync_operation): Ditto.
	(build_builtin_expect_predicate): Ditto.
	(fold_builtin_memory_op): Ditto.
	(fold_builtin_strcpy): Ditto.
	(fold_builtin_strncpy): Ditto.
	(fold_builtin_interclass_mathfn): Ditto.
	(fold_builtin_classify): Ditto.
	(fold_builtin_2): Ditto.
	(fold_builtin_strstr): Ditto.
	(fold_builtin_strpbrk): Ditto.
	(fold_builtin_strcat): Ditto.
	(fold_builtin_strncat): Ditto.
	(fold_builtin_strcspn): Ditto.
	(fold_builtin_fputs): Ditto.
	(fold_builtin_sprintf): Ditto.
	(fold_builtin_snprintf): Ditto.
	(expand_builtin_memory_chk): Ditto.
	(fold_builtin_stxcpy_chk): Ditto.
	(fold_builtin_strncpy_chk): Ditto.
	(fold_builtin_strcat_chk): Ditto.
	(fold_builtin_strncat_chk): Ditto.
	(fold_builtin_sprintf_chk_1): Ditto.
	(fold_builtin_printf): Ditto.
	(fold_builtin_fprintf): Ditto.
	(fold_call_stmt): Ditto.
	(set_builtin_user_assembler_name): Ditto.
	* tree-emults.c (emutls_common_1): Ditto.
	(lower_emutls_function_body): Ditto.
	* omp-low.c (scan_omp): Ditto.
	(lower_rec_input_clauses): Ditto.
	(lower_reduction_clauses): Ditto.
	(expand_parallel_call): Ditto.
	(expand_task_call): Ditto.
	(maybe_catch_exception): Ditto.
	(optimize_omp_library_calls): Ditto.
	(expand_omp_for_generic): Ditto.
	(expand_omp_for_static_chunk): Ditto.
	(expand_omp_sections): Ditto.
	(expand_omp_atomic_pipeline): Ditto.
	(expand_omp_atomic_mutex): Ditto.
	(lower_omp_single_simple): Ditto.
	(lower_omp_single_copy): Ditto.
	(lower_omp_single): Ditto.
	(lower_omp_master): Ditto.
	(lower_omp_ordered): Ditto.
	(lower_omp_critical): Ditto.
	* tree-ssa-ccp.c (optimize_stdarg_builtin): Ditto.
	* tree-ssa-math-opts.c (execute_optimize_bswap): Ditto.
	* tree-ssa-strlen.c (get_string_length): Ditto.
	* gimple-low.c (lower_function_body): Ditto.
	(lower_builtin_setjmp): Ditto.
	* c-decl.c (finish_decl): Ditto.
	(merge_decls): Ditto.
	* tree-eh.c (lower_resx): ditto.
	(lower_eh_dispatch): Ditto.
	* function.c (gimplify_parameters): Ditto.
	* c-typeck.c (build_function_call_vec): Ditto.
	* gimplify.c (build_stack_save_restore): Ditto.
	(gimplify_vla_decl): Ditto.
	(gimplify_modify_expr_to_memcpy): Ditto.
	(gimplify_modify_expr_to_memset): Ditto.
	(gimplify_variable_sized_compare): Ditto.
	(gimplify_function_tree): Ditto.
	* calls.c (emit_call_1): Ditto.
	* tree-nested.c (convert_nl_goto_reference): Ditto.
	(convert_tramp_reference_op): Ditto.
	(finalize_nesting_tree_1): Ditto.
	* tree-ssa-loop-prefetch.c (issue_prefetch_ref): Ditto.
	(tree_ssa_prefetch_arrays): Ditto.
	* tree-streamer-in.c (streamer_get_builtin_tree): Ditto.
	* langhooks.c (add_builtin_function_common): Ditto.
	(add_builtin_function_nobind): Ditto.
	(add_builtin_function): Ditto.
	(add_builtin_function_ext_scope): Ditto.
	* langhooks.h (add_builtin_function_nobind): Ditto.
	* config/sparc/sparc.c (sparc_gimplify_va_arg): Ditto.
	* config/i386/i386.c (ix86_gimplify_va_arg): Ditto.
	(ix86_veclibabi_svml): Ditto.
	(ix86_veclibabi_acml): Ditto.
	* config/vms/vms.c (vms_patch_builtins): Ditto.
	* config/ia64/ia64.c (ia64_init_builtins): Ditto.
	* config/rs6000/rs6000.c (rs6000_builtin_vectorized_libmass): Ditto.
	(rs6000_gimplify_va_arg): Ditto.
	(rs6000_init_builtins): Ditto.
	* config/darwin.c (darwin_override_options): Ditto.
	(darwin_patch_builtin): Ditto.
	(darwin_rename_builtins): Ditto.
	* config/pa/pa.c (pa_init_builtins): Ditto.

	* builtins.def (BUILT_IN_NONE): Make sure 0 is not a legitimate
	builtin function index.

	* config/rs6000/rs6000.c (rs6000_debug_reg_global): Print size of
	the function decl node if -mdebug=reg.

[gcc/ada]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* gcc-interface/utils.c (def_builtin_1): Change builtin interface
	from being an array to an inline function for both normal and
	implicit builtin functions.  Change all read references to
	built_in_decls and implicit_built_in_decls arrays to functions,
	and change write references to call built_in_set_decl,
	built_in_set_decl_add or built_in_set_implicit.
	* gcc-interface/trans.c (Exception_Handler_to_gnu_zcx): Ditto.
	(gnat_to_gnu): Ditto.

[gcc/c-family]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* c-common.c (def_builtin_1): Change builtin interface from being
	an array to an inline function for both normal and implicit
	builtin functions.  Change all read references to built_in_decls
	and implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl, built_in_set_decl_add, or
	built_in_set_implicit.
	(resolve_overloaded_builtin): Ditto.
	* c-omp.c (c_finish_omp_barrier): Ditto.
	(c_finish_omp_taskwait): Ditto.
	(c_finish_omp_taskyield): Ditto.
	(c_finish_omp_flush): Ditto.

[gcc/cp]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* decl.c (duplicate_decls): Change builtin interface from being an
	array to an inline function for both normal and implicit builtin
	functions.  Change all read references to built_in_decls and
	implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl, built_in_set_decl_add, or
	built_in_set_implicit.
	* except.c (build_eh_type_type): Ditto.
	* semantics.c (finish_omp_atomic): Ditto.
	(finish_omp_barrier): Ditto.
	(finish_omp_flush): Ditto.
	(finish_omp_taskwait): Ditto.

[gcc/fortran]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* trans.c (gfc_call_malloc): Change builtin interface from being
	an array to an inline function for both normal and implicit
	builtin functions.  Change all read references to built_in_decls
	and implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl, built_in_set_decl_add, or
	built_in_set_implicit.
	(gfc_allocate_using_malloc): Ditto.
	(gfc_call_free): Ditto.
	(gfc_deallocate_with_status): Ditto.
	(gfc_deallocate_scalar_with_status): Ditto.
	(gfc_call_realloc): Ditto.
	(gfc_unlikely): Ditto.
	(gfc_likely): Ditto.
	* f95-lang.c (gfc_define_builtin): Ditto.
	(gfc_init_builtin_functions): Ditto.
	* trans-decl.c (create_main_function): Ditto.
	* trans-intrinsic.c (builtin_decl_for_precision): Ditto.
	(gfc_build_intrinsic_lib_fndecls): Ditto.
	(gfc_conv_intrinsic_minmax): Ditto.
	(gfc_conv_intrinsic_leadz): Ditto.
	(gfc_conv_intrinsic_trailz): Ditto.
	(gfc_conv_intrinsic_popcnt_poppar): Ditto.
	(gfc_conv_intrinsic_isnan): Ditto.
	(gfc_conv_intrinsic_transfer): Ditto.
	(scalar_transfer): Ditto.
	(gfc_conv_intrinsic_repeat): Ditto.

[gcc/go]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* gofrontend/gogo-tree.cc (make_trampoline): Change builtin
	interface from being an array to an inline function for both
	normal and implicit builtin functions.  Change all read references
	to built_in_decls and implicit_built_in_decls arrays to functions,
	and change write references to call built_in_set_decl,
	built_in_set_decl_add, or built_in_set_implicit.

[gcc/java]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* class.c (build_static_field_ref): Change builtin interface from
	being an array to an inline function for both normal and implicit
	builtin functions.  Change all read references to built_in_decls
	and implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl, built_in_set_decl_add, or
	built_in_set_implicit.
	* decl.c (java_init_decl_processing): Ditto.
	* except.c (expand_end_java_handler): Ditto.
	* builtins.c (compareAndSwapInt_builtin): Ditto.
	(compareAndSwapLong_builtin): Ditto.
	(compareAndSwapObject_builtin): Ditto.
	(compareAndSwapObject_builtin): Ditto.
	(putVolatile_builtin): Ditto.
	(getVolatile_builtin): Ditto.
	(define_builtin): Ditto.
	(check_for_builtin): Ditto.
	* expr.c (rewrite_arglist_getcaller): Ditto.
	(expand_java_field_op): Ditto.

[gcc/lto]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* lto-lang.c (def_builtin_1): Change builtin interface from being
	an array to an inline function for both normal and implicit
	builtin functions.  Change all read references to built_in_decls
	and implicit_built_in_decls arrays to functions, and change write
	references to call built_in_set_decl, built_in_set_decl_add, or
	built_in_set_implicit.

[gcc/objc]
2011-09-30  Michael Meissner  <meissner@linux.vnet.ibm.com>

	* objc-next-runtime-abi-01.c (objc_build_exc_ptr): Change builtin
	interface from being an array to an inline function for both
	normal and implicit builtin functions.  Change all read references
	to built_in_decls and implicit_built_in_decls arrays to functions,
	and change write references to call built_in_set_decl,
	built_in_set_decl_add, or built_in_set_implicit.
	* objc-next-runtime-abi-02.c (objc_build_exc_ptr): Ditto.
	* objc-gnu-runtime-abi-01.c (objc_build_exc_ptr): Ditto.

[RFC] Builtin infrastructure change

Commit Message

Comments

Patch