From patchwork Thu Jul 21 16:30:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Diego Novillo X-Patchwork-Id: 106105 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A3409B6F76 for ; Fri, 22 Jul 2011 02:32:27 +1000 (EST) Received: (qmail 14648 invoked by alias); 21 Jul 2011 16:31:54 -0000 Received: (qmail 14438 invoked by uid 22791); 21 Jul 2011 16:31:48 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jul 2011 16:30:56 +0000 Received: from hpaq13.eem.corp.google.com (hpaq13.eem.corp.google.com [172.25.149.13]) by smtp-out.google.com with ESMTP id p6LGUtPj012544; Thu, 21 Jul 2011 09:30:55 -0700 Received: from tobiano.tor.corp.google.com (tobiano.tor.corp.google.com [172.29.41.6]) by hpaq13.eem.corp.google.com with ESMTP id p6LGUrZD004628; Thu, 21 Jul 2011 09:30:54 -0700 Received: by tobiano.tor.corp.google.com (Postfix, from userid 54752) id 3A76FAE1F0; Thu, 21 Jul 2011 12:30:53 -0400 (EDT) To: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org Subject: [google] Remove some XPASS/XFAIL markers (issue4809048) Message-Id: <20110721163053.3A76FAE1F0@tobiano.tor.corp.google.com> Date: Thu, 21 Jul 2011 12:30:53 -0400 (EDT) From: dnovillo@google.com (Diego Novillo) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch removes a few XPASSes from the testsuite. It also forces all the sse4_1-blendps* tests to compile with -O0. At the point of the latest merge from trunk (175879), these tests were flaky when compiled with -march=pentium3 -mtune=pentium4 -m32. We were discussing this on IRC, and Jakub could not reproduce with a recent trunk, so I expect this will be fixed by the next merge. Diego. gcc/testsuite/ChangeLog.google-integration 2011-07-21 Diego Novillo * gcc.dg/inline_3.c: Remove dg-excess-errors. * gcc.dg/inline_4.c: Likewise. * gcc.dg/unroll_2.c: Likewise. * gcc.dg/unroll_3.c: Likewise. * gcc.dg/unroll_4.c: Likewise. * gcc.dg/tree-ssa/20030807-7.c: Remove xfail. * gcc.target/i386/sse4_1-blendps-2.c: Compile with -O0. Add FIXME note. * gcc.target/i386/sse4_1-blendps.c: Likewise. libstdc++-v3/ChangeLog.google-integration: * testsuite/23_containers/vector/requirements/dr438/assign_neg.cc: Remove dg-excess-errors. * testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc: Likewise. * testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc: Likewise. * testsuite/23_containers/vector/requirements/dr438/insert_neg.cc: Likewise. --- This patch is available for review at http://codereview.appspot.com/4809048 diff --git a/gcc/testsuite/gcc.dg/inline_3.c b/gcc/testsuite/gcc.dg/inline_3.c index 17871c6..0b9ffed 100644 --- a/gcc/testsuite/gcc.dg/inline_3.c +++ b/gcc/testsuite/gcc.dg/inline_3.c @@ -20,4 +20,3 @@ int foo2 (void) /* { dg-final { scan-tree-dump-times "bar" 5 "optimized" } } */ /* { dg-final { cleanup-tree-dump "optimized" } } */ -/* { dg-excess-errors "extra notes" } */ diff --git a/gcc/testsuite/gcc.dg/inline_4.c b/gcc/testsuite/gcc.dg/inline_4.c index 1feefa1..a2fcac4 100644 --- a/gcc/testsuite/gcc.dg/inline_4.c +++ b/gcc/testsuite/gcc.dg/inline_4.c @@ -20,4 +20,3 @@ int foo2 (void) /* { dg-final { scan-tree-dump-times "bar" 4 "optimized" } } */ /* { dg-final { cleanup-tree-dump "optimized" } } */ -/* { dg-excess-errors "extra notes" } */ diff --git a/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c b/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c index ed6f7c0..f9f5fb7 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/20030807-7.c @@ -33,5 +33,5 @@ simplify_condition (cond_p) } /* There should be exactly one IF conditional. */ -/* { dg-final { scan-tree-dump-times "if " 1 "vrp1" { xfail *-*-* } } } */ +/* { dg-final { scan-tree-dump-times "if " 1 "vrp1" } } */ /* { dg-final { cleanup-tree-dump "vrp1" } } */ diff --git a/gcc/testsuite/gcc.dg/unroll_2.c b/gcc/testsuite/gcc.dg/unroll_2.c index 12912cf..9fdec57 100644 --- a/gcc/testsuite/gcc.dg/unroll_2.c +++ b/gcc/testsuite/gcc.dg/unroll_2.c @@ -30,4 +30,3 @@ int foo2(void) /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1 "loop2_unroll" } } */ /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */ -/* { dg-excess-errors "extra notes" } */ diff --git a/gcc/testsuite/gcc.dg/unroll_3.c b/gcc/testsuite/gcc.dg/unroll_3.c index d86ed55..cc9a4fb 100644 --- a/gcc/testsuite/gcc.dg/unroll_3.c +++ b/gcc/testsuite/gcc.dg/unroll_3.c @@ -30,4 +30,3 @@ int foo2(void) /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1 "loop2_unroll" } } */ /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */ -/* { dg-excess-errors "extra notes" } */ diff --git a/gcc/testsuite/gcc.dg/unroll_4.c b/gcc/testsuite/gcc.dg/unroll_4.c index 7c70157..4484f04 100644 --- a/gcc/testsuite/gcc.dg/unroll_4.c +++ b/gcc/testsuite/gcc.dg/unroll_4.c @@ -30,4 +30,3 @@ int foo2(void) /* { dg-final { scan-rtl-dump-times "Decided to peel loop completely" 1 "loop2_unroll" } } */ /* { dg-final { cleanup-rtl-dump "loop2_unroll" } } */ -/* { dg-excess-errors "extra notes" } */ diff --git a/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c b/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c index b66bbfd..d8f4a46 100644 --- a/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c +++ b/gcc/testsuite/gcc.target/i386/sse4_1-blendps-2.c @@ -1,6 +1,7 @@ /* { dg-do run } */ /* { dg-require-effective-target sse4 } */ -/* { dg-options "-O2 -msse4.1" } */ +/* FIXME - Forced -O0. This test is flaky as of trunk@175879. */ +/* { dg-options "-O0 -msse4.1" } */ #include "sse4_1-check.h" diff --git a/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c b/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c index 6234ffb..f6824ad 100644 --- a/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c +++ b/gcc/testsuite/gcc.target/i386/sse4_1-blendps.c @@ -1,5 +1,6 @@ /* { dg-do run } */ /* { dg-require-effective-target sse4 } */ +/* FIXME - Forced -O0. This test is flaky as of trunk@175879. */ /* { dg-options "-O0 -msse4.1" } */ #ifndef CHECK_H diff --git a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc index 6d226ba..53812d4 100644 --- a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/assign_neg.cc @@ -19,7 +19,6 @@ // { dg-do compile } // { dg-error "no matching" "" { target *-*-* } 1173 } -// { dg-excess-errors "" } #include diff --git a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc index 5cf3d52..7ac6ef0 100644 --- a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_1_neg.cc @@ -19,7 +19,6 @@ // { dg-do compile } // { dg-error "no matching" "" { target *-*-* } 1103 } -// { dg-excess-errors "" } #include diff --git a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc index 6645556..436acae 100644 --- a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/constructor_2_neg.cc @@ -19,7 +19,6 @@ // { dg-do compile } // { dg-error "no matching" "" { target *-*-* } 1103 } -// { dg-excess-errors "" } #include #include diff --git a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc index 6d46fa4..0aa9f16 100644 --- a/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc +++ b/libstdc++-v3/testsuite/23_containers/vector/requirements/dr438/insert_neg.cc @@ -19,7 +19,6 @@ // { dg-do compile } // { dg-error "no matching" "" { target *-*-* } 1214 } -// { dg-excess-errors "" } #include