From patchwork Fri Jun 3 16:25:25 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 98606 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A3342B6F9C for ; Sat, 4 Jun 2011 02:25:50 +1000 (EST) Received: (qmail 1475 invoked by alias); 3 Jun 2011 16:25:45 -0000 Received: (qmail 1461 invoked by uid 22791); 3 Jun 2011 16:25:42 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL, BAYES_00, TW_CX, TW_ZM, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Fri, 03 Jun 2011 16:25:28 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id 26510B005D for ; Fri, 3 Jun 2011 12:25:26 -0400 (EDT) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id p53GPPXm004388 for gcc-patches@gcc.gnu.org; Fri, 3 Jun 2011 12:25:25 -0400 Date: Fri, 3 Jun 2011 12:25:25 -0400 From: Jack Howarth To: gcc-patches@gcc.gnu.org Subject: [PATCH][PING][Revised] fix --enable-build-with-cxx on darwin] Message-ID: <20110603162525.GA4371@bromo.med.uc.edu> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Could someone commit this patch, which was already approved in http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00411.html The absence of this patch in gcc trunk prevents --enable-build-with-cxx from working on darwin. Thanks in advance. Jack ----- Forwarded message from Jack Howarth ----- X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bromo.med.uc.edu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=4.4 tests=AWL,BAYES_00, DNS_FROM_OPENWHOIS,FH_DATE_PAST_20XX,RCVD_IN_DNSWL_MED autolearn=no version=3.2.5 X-Original-To: howarth@bromo.med.uc.edu Delivered-To: howarth@bromo.med.uc.edu X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_CX,T_RP_MATCHES_RCVD Date: Thu, 5 May 2011 08:58:26 -0400 From: Jack Howarth To: gcc-patches@gcc.gnu.org Subject: [PATCH][Revised] fix --enable-build-with-cxx on darwin User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Delivered-To: mailing list gcc-patches@gcc.gnu.org Currently the bootstrap with --enable-build-with-cxx is broken due to compiler errors of the form "error: converting 'false' to pointer type 'varpool_node*' [-Werror=conversion-null]". The attached patch changes the last remaing instance of false to NULL and restores the --enable-build-with-cxx bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk? Jack 2011-05-05 Jack Howarth * gcc/varpool.c (varpool_extra_name_alias): Likewise. ----- End forwarded message ----- Index: gcc/varpool.c =================================================================== --- gcc/varpool.c (revision 173423) +++ gcc/varpool.c (working copy) @@ -676,7 +676,7 @@ varpool_extra_name_alias (tree alias, tr #ifndef ASM_OUTPUT_DEF /* If aliases aren't supported by the assembler, fail. */ - return false; + return NULL; #endif gcc_assert (TREE_CODE (decl) == VAR_DECL);