From patchwork Tue Apr 5 14:34:24 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 89877 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D5559B6F8C for ; Wed, 6 Apr 2011 00:36:18 +1000 (EST) Received: (qmail 11727 invoked by alias); 5 Apr 2011 14:36:12 -0000 Received: (qmail 11684 invoked by uid 22791); 5 Apr 2011 14:36:10 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 14:35:29 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id A3EB0CB0282 for ; Tue, 5 Apr 2011 16:35:28 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0fADHTz1dCSj for ; Tue, 5 Apr 2011 16:35:24 +0200 (CEST) Received: from [192.168.1.2] (bon31-9-83-155-120-49.fbx.proxad.net [83.155.120.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id B4F3DCB0358 for ; Tue, 5 Apr 2011 16:35:21 +0200 (CEST) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: Fix accidental reversion Date: Tue, 5 Apr 2011 16:34:24 +0200 User-Agent: KMail/1.9.9 MIME-Version: 1.0 Message-Id: <201104051634.24428.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org In June of last year I installed the change: 2010-06-06 Eric Botcazou * stor-layout.c (self_referential_size): Set UNKNOWN_LOCATION on the newly built CALL_EXPR. but it was accidentally reverted by: 2010-07-13 Nathan Froyd [...] (expand_parallel_call): Call build_call_expr_loc_vec instead of build_function_call_expr. * stor-layout.c (self_referential_size): Likewise. So installed again on mainline and 4.6 branch after testing on i586-suse-linux. This helps coverage info, for example on: procedure To_Upper (Item : in out String) is begin Item := Ada.Characters.Handling.To_Upper (Item); end To_Upper; and only affects the Ada compiler. 2011-04-05 Eric Botcazou * stor-layout.c (self_referential_size): Fix 2010-07-13 commit. Index: stor-layout.c =================================================================== --- stor-layout.c (revision 171942) +++ stor-layout.c (working copy) @@ -367,7 +367,7 @@ self_referential_size (tree size) VEC_safe_push (tree, gc, size_functions, fndecl); /* Replace the original expression with a call to the size function. */ - return build_call_expr_loc_vec (input_location, fndecl, args); + return build_call_expr_loc_vec (UNKNOWN_LOCATION, fndecl, args); } /* Take, queue and compile all the size functions. It is essential that