From patchwork Fri Apr 1 21:18:23 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Ellcey X-Patchwork-Id: 89344 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C8C05B6F7E for ; Sat, 2 Apr 2011 08:18:33 +1100 (EST) Received: (qmail 17940 invoked by alias); 1 Apr 2011 21:18:32 -0000 Received: (qmail 17932 invoked by uid 22791); 1 Apr 2011 21:18:30 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from g4t0017.houston.hp.com (HELO g4t0017.houston.hp.com) (15.201.24.20) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Apr 2011 21:18:25 +0000 Received: from g4t0009.houston.hp.com (g4t0009.houston.hp.com [16.234.32.26]) by g4t0017.houston.hp.com (Postfix) with ESMTP id B000738469 for ; Fri, 1 Apr 2011 21:18:24 +0000 (UTC) Received: from lucas.cup.hp.com (lucas.cup.hp.com [15.244.97.116]) by g4t0009.houston.hp.com (Postfix) with ESMTP id 63FBCC565 for ; Fri, 1 Apr 2011 21:18:24 +0000 (UTC) Received: (from sje@localhost) by lucas.cup.hp.com (8.11.1 (PHNE_35485)/8.11.1) id p31LINP20816 for gcc-patches@gcc.gnu.org; Fri, 1 Apr 2011 14:18:23 -0700 (PDT) Date: Fri, 1 Apr 2011 14:18:23 -0700 (PDT) From: Steve Ellcey Message-Id: <201104012118.p31LINP20816@lucas.cup.hp.com> To: gcc-patches@gcc.gnu.org Subject: [patch, testsuite, ia64] patch for gcc.dg/mtune.c Reply-to: sje@cup.hp.com Mime-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The gcc.dg/mtune.c test is failing on ia64-*-* because in addition to the expected error message that is output it also prints out a note about the valid values for mtune. $ gcc -mtune=foo mtune.c gcc: error: unrecognized argument in option '-mtune=foo' gcc: note: valid arguments to '-mtune=' are: itanium2 mckinley Looking into why this doesn't happen on other systems, it looks like the difference is that IA64 uses -mtune to set an enum variable and most (all?) the other platforms use it to set a string variable. Since the message seems reasonable I propose to just change the test to expect it. The patch was tested on IA64 HP-UX and Linux. If I don't hear any objections I will just check it in as an obvious fix. Steve Ellcey sje@cup.hp.com 2011-04-01 Steve Ellcey * gcc.dg/mtune.c: Add expected note for target ia64-*-*. Index: gcc.dg/mtune.c =================================================================== --- gcc.dg/mtune.c (revision 171815) +++ gcc.dg/mtune.c (working copy) @@ -4,4 +4,5 @@ /* { dg-error "mtune" "" { target *-*-* } 0 } */ /* { dg-bogus "march" "" { target *-*-* } 0 } */ /* { dg-bogus "mcpu" "" { target *-*-* } 0 } */ +/* { dg-message "note: valid arguments" "" { target ia64-*-* } 0 } */ int i;