From patchwork Wed Feb 2 14:41:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Basile Starynkevitch X-Patchwork-Id: 81458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 10515B710F for ; Thu, 3 Feb 2011 01:41:32 +1100 (EST) Received: (qmail 7297 invoked by alias); 2 Feb 2011 14:41:30 -0000 Received: (qmail 7288 invoked by uid 22791); 2 Feb 2011 14:41:29 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp-103-wednesday.noc.nerim.net (HELO mallaury.nerim.net) (62.4.17.103) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Feb 2011 14:41:22 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by mallaury.nerim.net (Postfix) with ESMTPS id 93472153456 for ; Wed, 2 Feb 2011 15:41:20 +0100 (CET) Received: from basile18 by hector.lesours with local (Exim 4.72) (envelope-from ) id 1PkdtX-0001AY-Vi for gcc-patches@gcc.gnu.org; Wed, 02 Feb 2011 15:41:19 +0100 Date: Wed, 2 Feb 2011 15:41:19 +0100 From: Basile Starynkevitch To: gcc-patches@gcc.gnu.org Subject: [patch trunk] improving graphite Cloog sorry messages Message-ID: <20110202144119.GA4419@ours.starynkevitch.net> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello All, I find quite confusing the error messages when asking for graphite related optimization on a GCC where Cloog has been (inadvertently) disabled. I would like the sorry message to explicitly mention Cloog in that case. Here is a trivial patch to trunk 169524. ########### gcc/ChangeLog entry 2011-02-02 Basile Starynkevitch * toplevel.c (process_options): Mention Cloog in error message when don't HAVE_cloog. * graphite.c (graphite_transform_loops): Likewise. ################ ################################################################ Comments or Ok are welcome. Regards. Index: gcc/toplev.c =================================================================== --- gcc/toplev.c (revision 169524) +++ gcc/toplev.c (working copy) @@ -1323,7 +1323,7 @@ process_options (void) sorry ("Graphite loop optimizations cannot be used (-fgraphite, " "-fgraphite-identity, -floop-block, -floop-flatten, " "-floop-interchange, -floop-strip-mine, -floop-parallelize-all, " - "and -ftree-loop-linear)"); + "and -ftree-loop-linear) without Cloog"); #endif /* Unrolling all loops implies that standard loop unrolling must also Index: gcc/graphite.c =================================================================== --- gcc/graphite.c (revision 169524) +++ gcc/graphite.c (working copy) @@ -283,7 +283,7 @@ graphite_transform_loops (void) void graphite_transform_loops (void) { - sorry ("Graphite loop optimizations cannot be used"); + sorry ("Graphite loop optimizations cannot be used without Cloog"); } #endif