From patchwork Wed Jan 12 03:26:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 78501 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8E280B70A3 for ; Wed, 12 Jan 2011 14:26:40 +1100 (EST) Received: (qmail 5714 invoked by alias); 12 Jan 2011 03:26:38 -0000 Received: (qmail 5699 invoked by uid 22791); 12 Jan 2011 03:26:38 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 12 Jan 2011 03:26:34 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id EDA2FB2DB9; Tue, 11 Jan 2011 22:26:31 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id p0C3QVEj019097; Tue, 11 Jan 2011 22:26:31 -0500 Date: Tue, 11 Jan 2011 22:26:31 -0500 From: Jack Howarth To: Jan Hubicka Cc: gcc-patches@gcc.gnu.org, PR46037.diff@bromo.med.uc.edu, mikestump@comcast.net, iains@gcc.gnu.org Subject: Re: [PATCH] Fix PR46037 Message-ID: <20110112032631.GA19061@bromo.med.uc.edu> References: <20110111225251.GA16941@bromo.med.uc.edu> <20110112022309.GG20832@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110112022309.GG20832@kam.mff.cuni.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Honza, Doh! In http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46037#c16, we had the conditional backwards. If I use... ...both the standard and lto-bootstrap complete. I'll regression test both and submit a revised patch. Jack Index: gcc/config/darwin.c =================================================================== --- gcc/config/darwin.c (revision 168683) +++ gcc/config/darwin.c (working copy) @@ -2616,9 +2616,10 @@ darwin_override_options (void) } if (flag_var_tracking - && (generating_for_darwin_version >= 9) - && debug_info_level >= DINFO_LEVEL_NORMAL - && debug_hooks->var_location != do_nothing_debug_hooks.var_location) + && generating_for_darwin_version >= 9 + && (flag_gtoggle ? (debug_info_level == DINFO_LEVEL_NONE) + : (debug_info_level >= DINFO_LEVEL_NORMAL)) + && write_symbols == DWARF2_DEBUG) flag_var_tracking_uninit = 1; if (MACHO_DYNAMIC_NO_PIC_P)