From patchwork Wed Dec 29 17:50:42 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 76931 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 36B1DB70EC for ; Thu, 30 Dec 2010 04:50:52 +1100 (EST) Received: (qmail 23639 invoked by alias); 29 Dec 2010 17:50:50 -0000 Received: (qmail 23629 invoked by uid 22791); 29 Dec 2010 17:50:49 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Wed, 29 Dec 2010 17:50:45 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id CFE42B0074; Wed, 29 Dec 2010 12:50:42 -0500 (EST) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id oBTHogge029577; Wed, 29 Dec 2010 12:50:42 -0500 Date: Wed, 29 Dec 2010 12:50:42 -0500 From: Jack Howarth To: Tobias Grosser Cc: Sven Verdoolaege , Sebastian Pop , gcc-patches@gcc.gnu.org, gcc-graphite@googlegroups.com Subject: Re: [PATCH 1/2] Bump CLooG.org version to 0.16.0. Message-ID: <20101229175042.GA29569@bromo.med.uc.edu> References: <1293614239-3538-1-git-send-email-sebpop@gmail.com> <20101229142029.GA28321@bromo.med.uc.edu> <4D1B466C.2000707@fim.uni-passau.de> <20101229162339.GA28957@bromo.med.uc.edu> <20101229163623.GL4376MdfPADPa@purples> <20101229171244.GA29358@bromo.med.uc.edu> <4D1B704E.6020002@fim.uni-passau.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4D1B704E.6020002@fim.uni-passau.de> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Wed, Dec 29, 2010 at 12:30:54PM -0500, Tobias Grosser wrote: > On 12/29/2010 12:12 PM, Jack Howarth wrote: >> On Wed, Dec 29, 2010 at 05:36:23PM +0100, Sven Verdoolaege wrote: >>> On Wed, Dec 29, 2010 at 11:23:39AM -0500, Jack Howarth wrote: >>>> I was able to build cloog-parma and it passed its testsuite, but the cloog-parma >>>> pre-release doesn't seem to install the stride.h header from the cloog-core subdirectory. >>>> Jack >>> >>> Try this: >>> [..] >> Sven, >> Thanks. This eliminates the problem of uninstalled headers. Unfortunately, cloog-parma still >> confuses configure in gcc trunk though and fails as... >> >> [..] >> Jack >> ps It appears that the version checks for cloog in the graphite branch are signficantly >> different from those in gcc trunk so that today's cloog.org version bump for the graphite >> branch can't be applied to trunk to solve this issue. > > Hi Jack, > > where do you see this huge difference? For me the config/cloog.m4 files > are identical and the section in configure.ac looks in both files like > this: > > if test "x$with_cloog" != "xno"; then > dnl Version check for CLooG-Org > dnl As long as there is no new release of CLooG, > dnl we will check for 0.14.0. > dnl > dnl The first git revision that will work with > dnl GCC is: bd91b845a65805c290d43fc1bef8139864a163fb > dnl This is enforced implictly, as this is the commit that > dnl introduced the versioning information used within our > dnl checks. > dnl > dnl If we're using CLooG-Legacy, the provided version information > dnl will be ignored. > CLOOG_CHECK_VERSION(0,14,0) > > Cheers > Tobias Tobias, My mistake. They are similar but I am confused about the sections that were left unchanged... Shouldn't these tests be using gcc_cv_cloog_ct_0_16_0+set now? Jack --- a/configure +++ b/configure @@ -5971,8 +5971,8 @@ $as_echo "$gcc_cv_cloog_type" >&6; } LDFLAGS="${_cloog_saved_LDFLAGS} ${clooglibs} ${ppllibs}" if test "${cloog_org}" = yes ; then - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.14.0 of CLooG" >&5 -$as_echo_n "checking for version 0.14.0 of CLooG... " >&6; } + { $as_echo "$as_me:${as_lineno-$LINENO}: checking for version 0.16.0 of CLooG" >&5 +$as_echo_n "checking for version 0.16.0 of CLooG... " >&6; } if test "${gcc_cv_cloog_ct_0_14_0+set}" = set; then : $as_echo_n "(cached) " >&6 else @@ -5983,7 +5983,7 @@ int main () { #if CLOOG_VERSION_MAJOR != 0 \ - || CLOOG_VERSION_MINOR != 14 \ + || CLOOG_VERSION_MINOR != 16 \ || CLOOG_VERSION_REVISION < 0 choke me #endif