diff mbox

Ping [PATCH] PR testsuite/41146

Message ID 20101223123312.137AF3BE18@mailhost.lps.ens.fr
State New
Headers show

Commit Message

Dominique d'Humières Dec. 23, 2010, 12:33 p.m. UTC 
This updated patch fixes 4 failures on powerpc-apple-darwin9 because its
assembler needs the r prefix. See
http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00772.html and
http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00776.html .
Is the patch OK for trunk? If yes, please commit (I don't have the rights).


gcc/testsuite/
2010-12-23  Dominique d'Humieres  <dominiq@lps.ens.fr>

	PR testsuite/41146
	* gcc.target/powerpc/asm-es-2.c: Adjust regular expression for 
	powerpc-apple-darwin9.

Comments

Mike Stump Dec. 23, 2010, 8:05 p.m. UTC | #1 
On Dec 23, 2010, at 4:33 AM, dominiq@lps.ens.fr (Dominique Dhumieres) wrote:
> This updated patch fixes 4 failures on powerpc-apple-darwin9 because its
> assembler needs the r prefix. See
> http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00772.html and
> http://gcc.gnu.org/ml/gcc-patches/2009-12/msg00776.html .
> Is the patch OK for trunk?

Ok with me, though, I need a gas/aix person to ensure we don't just fix Darwin at the expense of other systems.
Dominique d'Humières Dec. 23, 2010, 8:37 p.m. UTC | #2 
Mike,

> Ok with me, though, I need a gas/aix person to ensure we don't just fix 
> Darwin at the expense of other systems.

Since the regular expressions only extend the accepted patterns, I cannot 
see how it can break anything (it can only accept invalid ones such as %3).

Thanks for the review,

Dominique

PS. See also http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41146#c1 .
Mike Stump Dec. 24, 2010, 10:37 p.m. UTC | #3 
On Dec 23, 2010, at 12:37 PM, dominiq@lps.ens.fr (Dominique Dhumieres) wrote:

>> Ok with me, though, I need a gas/aix person to ensure we don't just fix 
>> Darwin at the expense of other systems.
> 
> Since the regular expressions only extend the accepted patterns, I cannot 
> see how it can break anything (it can only accept invalid ones such as %3).

Ah,yes, I'd check it in then.
>
Dominique d'Humières Jan. 15, 2011, 10:08 p.m. UTC | #4 
Mike,

> Ah,yes, I'd check it in then.

PING!

TIA

Dominique
Mike Stump Jan. 18, 2011, 8:08 p.m. UTC | #5 
On Jan 15, 2011, at 2:08 PM, Dominique Dhumieres wrote:
>> Ah,yes, I'd check it in then.
> 
> PING!

Oh, you want me to play the role of patch monkey....  :-)  Ok...  checked in.
Dominique d'Humières Jan. 18, 2011, 9:32 p.m. UTC | #6 
> Oh, you want me to play the role of patch monkey....  :-)  Ok...  checked in.

Since I don't have commit rights, i had to find one;-)

Thanks for the commit. I'll close the pr as fixed as soon as regress
has digested it.

Dominique
diff mbox

Patch

--- gcc/testsuite/gcc.target/powerpc/asm-es-2.c	2010-07-27 20:17:32.000000000 +0200
+++ ../gcc-4.6-work/gcc/testsuite/gcc.target/powerpc/asm-es-2.c	2010-07-27 22:01:47.000000000 +0200
@@ -31,7 +31,7 @@  f4 (int *p)
   asm ("asm4 %0" : "=es" (p[100]));
 }
 
-/* { dg-final { scan-assembler "asm1 3,4" } } */
-/* { dg-final { scan-assembler "asm2u 16\\(3\\)" } } */
-/* { dg-final { scan-assembler "asm3 0\\(3\\)" } } */
-/* { dg-final { scan-assembler "asm4 400\\(3\\)" } } */
+/* { dg-final { scan-assembler "asm1 %?r?3,%?r?4" } } */
+/* { dg-final { scan-assembler "asm2u 16\\(%?r?3\\)" } } */
+/* { dg-final { scan-assembler "asm3 0\\(%?r?3\\)" } } */
+/* { dg-final { scan-assembler "asm4 400\\(%?r?3\\)" } } */