From patchwork Wed Dec 8 21:27:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 74781 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 6BE30B70B8 for ; Thu, 9 Dec 2010 08:27:59 +1100 (EST) Received: (qmail 20618 invoked by alias); 8 Dec 2010 21:27:57 -0000 Received: (qmail 20610 invoked by uid 22791); 8 Dec 2010 21:27:56 -0000 X-SWARE-Spam-Status: No, hits=-3.7 required=5.0 tests=AWL, BAYES_00, MEDICAL_SUBJECT, RCVD_IN_DNSWL_HI, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Dec 2010 21:27:52 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oB8LRoJl004624 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Dec 2010 16:27:50 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oB8LRnQg009492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 8 Dec 2010 16:27:50 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id oB8LRnRV017006; Wed, 8 Dec 2010 22:27:49 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id oB8LRnIo017005; Wed, 8 Dec 2010 22:27:49 +0100 Date: Wed, 8 Dec 2010 22:27:49 +0100 From: Jakub Jelinek To: Andreas Krebbel Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] Fix two s390.md nits Message-ID: <20101208212749.GI29412@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi! Two nits I've noticed today, the lgoc -> locg patch left the wrong spelling in comment, and I see new warnings: warning: source missing a mode? (8 times) on the sync_old_ pattern. Ok for trunk? 2010-12-08 Jakub Jelinek * config/s390/s390.md (*movcc): Change lgoc and stgoc to locg and stocg even in comment. (sync_old_): Give mode to UNSPEC_VOLATILE. Jakub --- gcc/config/s390/s390.md.jj 2010-11-17 10:13:17.581278815 +0100 +++ gcc/config/s390/s390.md 2010-12-08 22:19:57.769654839 +0100 @@ -5338,7 +5338,7 @@ "operands[1] = s390_emit_compare (GET_CODE (operands[1]), XEXP (operands[1], 0), XEXP (operands[1], 1));") -; locr, loc, stoc, locgr, lgoc, stgoc +; locr, loc, stoc, locgr, locg, stocg (define_insn_and_split "*movcc" [(set (match_operand:GPR 0 "nonimmediate_operand" "=d,d, d, d,QS,QS,&d") (if_then_else:GPR @@ -8845,7 +8845,7 @@ [(set (match_operand:GPR 0 "register_operand" "=d") (match_operand:GPR 1 "memory_operand" "+QS")) (set (match_dup 1) - (unspec_volatile + (unspec_volatile:GPR [(ATOMIC_Z196:GPR (match_dup 1) (match_operand:GPR 2 "general_operand" "d"))] UNSPECV_ATOMIC_OP))