From patchwork Sat Oct 2 20:20:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jack Howarth X-Patchwork-Id: 66580 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 184B2B70ED for ; Sun, 3 Oct 2010 07:20:47 +1100 (EST) Received: (qmail 32335 invoked by alias); 2 Oct 2010 20:20:29 -0000 Received: (qmail 32324 invoked by uid 22791); 2 Oct 2010 20:20:28 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from bromo.med.uc.edu (HELO bromo.med.uc.edu) (129.137.3.146) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sat, 02 Oct 2010 20:20:22 +0000 Received: from bromo.med.uc.edu (localhost.localdomain [127.0.0.1]) by bromo.med.uc.edu (Postfix) with ESMTP id A0AC0B004B; Sat, 2 Oct 2010 16:20:19 -0400 (EDT) Received: (from howarth@localhost) by bromo.med.uc.edu (8.14.3/8.14.3/Submit) id o92KKJJR016520; Sat, 2 Oct 2010 16:20:19 -0400 Date: Sat, 2 Oct 2010 16:20:18 -0400 From: Jack Howarth To: Dave Korn Cc: Ralf Wildenhues , GCC Patches Subject: Re: [PATCH] LTO plugin for coff, part 1: break out ELF-specific code and enable COFF builds Message-ID: <20101002202018.GA16460@bromo.med.uc.edu> References: <4CA7596D.3040801@gmail.com> <20101002160036.GI11272@gmx.de> <20101002161346.GA15046@bromo.med.uc.edu> <4CA7663E.4010107@gmail.com> <20101002171434.GD11911@gmx.de> <4CA789B0.5090308@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4CA789B0.5090308@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sat, Oct 02, 2010 at 08:36:16PM +0100, Dave Korn wrote: > On 02/10/2010 18:14, Ralf Wildenhues wrote: > > * Dave Korn wrote on Sat, Oct 02, 2010 at 07:05:02PM CEST: > >> On 02/10/2010 17:13, Jack Howarth wrote: > >>> On Sat, Oct 02, 2010 at 06:00:36PM +0200, Ralf Wildenhues wrote: > > Ralf, Jack: your arguments are persuasive. How about if I re-do the > configury so that a) LTO is enabled for windows by default, as it is for > darwin, and b) the lto-plugin is enabled on (both) those platforms? Dave, Part (a) should just require the change... Regarding part (b), I am unclear if this lto-plugin will require the use of binuils on darwin. If so, it will definitely be a niche change for darwin as the vast majority of users will want to build with FSF gcc using the standard darwin cctools from Xcode. IMHO, binutils is not likely to be well supported on darwin for use beyond cross-platform builds of the darwin target. I definitely would not want to see lto require binutils for standard usage. Jack > > (I'll add the Mach-O stub files to the plugin while I'm at it.) > > cheers, > DaveK Index: configure.ac =================================================================== --- configure.ac (revision 164904) +++ configure.ac (working copy) @@ -1788,7 +1788,7 @@ AC_SUBST(libelfinc) fi],[if test x"$default_enable_lto" = x"yes" ; then case $target in - *-apple-darwin*) ;; + *-cygwin*|*-mingw* | *-apple-darwin*) ;; # On other non-ELF platforms, LTO must be explicitly enabled. *) enable_lto=no ;; esac