Message ID | 20100729161942.GH18378@tyan-ft48-01.lab.bos.redhat.com |
---|---|
State | New |
Headers | show |
On 07/29/2010 06:19 PM, Jakub Jelinek wrote: > It unfortunately broke printing of NOTEs, no NOTE_DATA is printed any more. > > Attached is an (untested) patch to fix that, but I think it would be much > better to revert NOTE related changes in your patch. They make things > worse, when the note name is moved before the note data, so the meat > of e.g. NOTE_INSN_VAR_LOCATION is shifted by 23 characters to the right. > So the second patch reverts those changes. Either one is fine. Thanks. Bernd
--- gcc/rtl.def.jj 2010-07-28 10:36:00.000000000 +0200 +++ gcc/rtl.def 2010-07-29 17:40:28.000000000 +0200 @@ -152,8 +152,8 @@ DEF_RTL_EXPR(CODE_LABEL, "code_label", " /* Say where in the code a source line starts, for symbol table's sake. Operand: - 4: note-specific data - 5: enum insn_note + 4: enum insn_note + 5: note-specific data 6: unique number if insn_note == note_insn_deleted_label. */ DEF_RTL_EXPR(NOTE, "note", "iuuBn0i", RTX_EXTRA) --- gcc/print-rtl.c.jj 2010-07-28 10:36:00.000000000 +0200 +++ gcc/print-rtl.c 2010-07-29 17:43:35.000000000 +0200 @@ -245,7 +245,7 @@ print_rtx (const_rtx in_rtx) print_node_brief (outfile, "", decl, dump_flags); } #endif - else if (i == 4 && NOTE_P (in_rtx)) + else if (i == 5 && NOTE_P (in_rtx)) { switch (NOTE_KIND (in_rtx)) {