diff mbox

[GRAPHITE] Fix for P1 bug 58028

Message ID 1739186346.4998092.1393536655802.JavaMail.zimbra@inria.fr
State New
Headers show

Commit Message

Mircea Namolaru Feb. 27, 2014, 9:30 p.m. UTC
Thanks for comments - updated the patch (fixed my e-mail address too :-)).

2014-02-26  Tobias Grosser  <tobias@grosser.es>
            Mircea Namolaru  <mircea.namolaru@inria.fr>
        
     Fix for bug 58028
     * graphite-clast-to-gimple.c (set_cloog_options):
     Don't remove scalar dimensions.


----- Mail original -----
> De: "Rainer Orth" <ro@CeBiTec.Uni-Bielefeld.DE>
> À: "Tobias Burnus" <tobias.burnus@physik.fu-berlin.de>
> Cc: "Tobias Grosser" <tobias@grosser.es>, "Mircea Namolaru" <mircea.namolaru@inria.fr>, gcc-patches@gcc.gnu.org
> Envoyé: Jeudi 27 Février 2014 11:14:30
> Objet: Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
> 
> Tobias Burnus <tobias.burnus@physik.fu-berlin.de> writes:
> 
> > On 02/26/2014 10:09 PM, Mircea Namolaru wrote:
> >> + /* Do not remove scalar dimensions. Cloog be default removes scalar
> >> + dimensions very early from the input schedule. However, they are
> >
> > Small nit: Instead of 'be default' it should be 'by default'
> 
> ... and two spaces after the full stops.  While you're at it, please fix
> the CLooG capitalization ;-)
> 
> 	Rainer
> 
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>

Comments

Rainer Orth Feb. 27, 2014, 10:23 p.m. UTC | #1
Hi Mircea,

two last nits:

> 2014-02-26  Tobias Grosser  <tobias@grosser.es>
>             Mircea Namolaru  <mircea.namolaru@inria.fr>
>         
>      Fix for bug 58028

Please write this as

       PR tree-optimization/58028

instead.  This way, the commit triggers an update to the bugzilla bug.

>      * graphite-clast-to-gimple.c (set_cloog_options):
>      Don't remove scalar dimensions.

Don't insert a line break after the colon, but continue on the same
line, letting it wrap at pos. 75 (Emacs' fill-column).

Thanks.
        Rainer
diff mbox

Patch

Index: gcc/graphite-clast-to-gimple.c
===================================================================
--- gcc/graphite-clast-to-gimple.c	(revision 207298)
+++ gcc/graphite-clast-to-gimple.c	(working copy)
@@ -1522,6 +1522,13 @@ 
      variables.  */
   options->save_domains = 1;
 
+  /* Do not remove scalar dimensions.  CLooG by default removes scalar 
+     dimensions very early from the input schedule.  However, they are 
+     necessary to correctly derive from the saved domains 
+     (options->save_domains) the relationship between the generated loops 
+     and the schedule dimensions they are generated from.  */ 
+  options->noscalars = 1;
+
   /* Disable optimizations and make cloog generate source code closer to the
      input.  This is useful for debugging,  but later we want the optimized
      code.