diff mbox series

libstdc++-v3/libsupc++/eh_call.cc: Avoid warning with -fno-exceptions.

Message ID 1599826987-5240-2-git-send-email-christophe.lyon@linaro.org
State New
Headers show
Series libstdc++-v3/libsupc++/eh_call.cc: Avoid warning with -fno-exceptions. | expand

Commit Message

Christophe Lyon Sept. 11, 2020, 12:23 p.m. UTC
When building with -fno-exceptions, __throw_exception_again expands to
nothing, causing a "suggest braces around empty body in an 'if'
statement" warning.

This patch adds braces, like what was done in eh_personality.cc in svn
r193295 (git g:54ba39f599fc2f3d59fd3cd828a301ce9b731a20)

2020-09-11  Torbjörn SVENSSON  <torbjorn.svensson@st.com>
	Christophe Lyon  <christophe.lyon@linaro.org>

	libstdc++-v3/
	* libsupc++/eh_call.cc: Avoid warning with -fno-exceptions.
---
 libstdc++-v3/libsupc++/eh_call.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Wakely Sept. 11, 2020, 12:55 p.m. UTC | #1
On 11/09/20 12:23 +0000, Christophe Lyon via Libstdc++ wrote:
>When building with -fno-exceptions, __throw_exception_again expands to
>nothing, causing a "suggest braces around empty body in an 'if'
>statement" warning.
>
>This patch adds braces, like what was done in eh_personality.cc in svn
>r193295 (git g:54ba39f599fc2f3d59fd3cd828a301ce9b731a20)

OK, thanks.

>2020-09-11  Torbjörn SVENSSON  <torbjorn.svensson@st.com>
>	Christophe Lyon  <christophe.lyon@linaro.org>
>
>	libstdc++-v3/
>	* libsupc++/eh_call.cc: Avoid warning with -fno-exceptions.
>---
> libstdc++-v3/libsupc++/eh_call.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/libsupc++/eh_call.cc b/libstdc++-v3/libsupc++/eh_call.cc
>index ee44b1a..d50c4fb 100644
>--- a/libstdc++-v3/libsupc++/eh_call.cc
>+++ b/libstdc++-v3/libsupc++/eh_call.cc
>@@ -138,7 +138,7 @@ __cxa_call_unexpected(void* exc_obj_in)
>
> 	  if (__cxa_type_match(&new_xh->unwindHeader, catch_type, false,
> 			       &new_ptr) != ctm_failed)
>-	    __throw_exception_again;
>+	    { __throw_exception_again; }
>
> 	  // If the exception spec allows std::bad_exception, throw that.
> 	  // We don't have a thrown object to compare against, but since
>-- 
>2.7.4
>
diff mbox series

Patch

diff --git a/libstdc++-v3/libsupc++/eh_call.cc b/libstdc++-v3/libsupc++/eh_call.cc
index ee44b1a..d50c4fb 100644
--- a/libstdc++-v3/libsupc++/eh_call.cc
+++ b/libstdc++-v3/libsupc++/eh_call.cc
@@ -138,7 +138,7 @@  __cxa_call_unexpected(void* exc_obj_in)
 
 	  if (__cxa_type_match(&new_xh->unwindHeader, catch_type, false,
 			       &new_ptr) != ctm_failed)
-	    __throw_exception_again;
+	    { __throw_exception_again; }
 
 	  // If the exception spec allows std::bad_exception, throw that.
 	  // We don't have a thrown object to compare against, but since