From patchwork Mon Feb 12 21:35:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: will schmidt X-Patchwork-Id: 872411 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-473107-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="o1lfA0Ty"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zgJr31rZVz9s4q for ; Tue, 13 Feb 2018 08:35:47 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:reply-to:to:cc:content-type:date:mime-version :content-transfer-encoding:message-id; q=dns; s=default; b=XIc7N fDg4MHCFNjVXL0TBNLJdoPR62u9Re+akEG1dl0GfBMmPYycmHyIuI6fw5hMexjkI FelSp/cJ7SmUJe/N2iI5NcqV8hstAbD/Zax0IEiIrXBZQznExTMsocwFrYZQDc90 H9G4zMJfOSg9BEwv9hKkh6qr2dj0Gr9TZUUAjw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:reply-to:to:cc:content-type:date:mime-version :content-transfer-encoding:message-id; s=default; bh=0youiKdbvtx IWzNILhRT+iQDJtc=; b=o1lfA0TycQ7dttKiEzpAXfiHK5QRIvhzEBJK80Lpr/V fESP+PLXD7GZIzbshG3FAN3VjHYk2MSyEdMvbOowU6FodHuqc8kZYiUPuA6HZs+7 Y+7bXrPeBKb7kMrsvXSqoTit8xMX/nQahKAEOFV9baOtI9qZ4MsrjD83FwHtpiOE = Received: (qmail 122751 invoked by alias); 12 Feb 2018 21:35:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 122656 invoked by uid 89); 12 Feb 2018 21:35:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:le-alti, sk:lealti, UD:le-altivec-consts.c, varies X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Feb 2018 21:35:35 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1CLYF9S055361 for ; Mon, 12 Feb 2018 16:35:33 -0500 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g3dpu4xm4-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 12 Feb 2018 16:35:33 -0500 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Feb 2018 16:35:31 -0500 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Feb 2018 16:35:28 -0500 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w1CLZS4s49741876; Mon, 12 Feb 2018 21:35:28 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DF6F4112054; Mon, 12 Feb 2018 16:33:29 -0500 (EST) Received: from [9.10.86.107] (unknown [9.10.86.107]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id 9ED48112040; Mon, 12 Feb 2018 16:33:29 -0500 (EST) Subject: [PATCH, rs6000] fix-up le-altivec-const.c and altivec-const.c tests From: Will Schmidt Reply-To: will_schmidt@vnet.ibm.com To: gcc-patches@gcc.gnu.org Cc: Segher Boessenkool , David Edelsohn , Bill Schmidt Date: Mon, 12 Feb 2018 15:35:27 -0600 Mime-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 18021221-0056-0000-0000-000004196CA3 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008524; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000252; SDB=6.00988811; UDB=6.00502034; IPR=6.00768165; BA=6.00005825; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00019520; XFM=3.00000015; UTC=2018-02-12 21:35:30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18021221-0057-0000-0000-00000850E132 Message-Id: <1518471327.11602.298.camel@brimstone.rchland.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2018-02-12_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1802120273 X-IsSubscribed: yes Hi, Noticed during review of test results. I expect the intent here was to compile in cases where the run command was not valid. But for the scan-assembler stanza to work, need to have compile results in all cases. /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */ /* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */ /* { dg-require-effective-target powerpc_altivec_ok } */ ... /* { dg-final { scan-assembler-not "lvx" { target { powerpc*le-*-* } } } } */ So.. Added some commentary, updated the stanzas, retested on assorted power systems. This fixes "scan-assembler-not lvx" failure as seen in testresults from LE systems. OK for trunk? Thanks -Will [testsuite] 2018-02-12 Will Schmidt * gcc.target/powerpc/altivec-consts.c: Update compile stanzas. * gcc.target/powerpc/le-altivec-consts.c: Same. diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-consts.c b/gcc/testsuite/gcc.target/powerpc/altivec-consts.c index 36cb60c..8ec73e9 100644 --- a/gcc/testsuite/gcc.target/powerpc/altivec-consts.c +++ b/gcc/testsuite/gcc.target/powerpc/altivec-consts.c @@ -1,7 +1,11 @@ +/* altivec-consts.c: + Requires vmx_hw support to run. Requires altivec support to compile. + This test varies from le-altivec-consts.c in the ordering of the + vector elements below. */ /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */ -/* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */ +/* { dg-do compile { target { powerpc*-*-* } } } */ /* { dg-require-effective-target powerpc_altivec_ok } */ /* { dg-options "-maltivec -mabi=altivec -O2" } */ /* Check that "easy" AltiVec constants are correctly synthesized. */ diff --git a/gcc/testsuite/gcc.target/powerpc/le-altivec-consts.c b/gcc/testsuite/gcc.target/powerpc/le-altivec-consts.c index 15ec650..2f81ff7 100644 --- a/gcc/testsuite/gcc.target/powerpc/le-altivec-consts.c +++ b/gcc/testsuite/gcc.target/powerpc/le-altivec-consts.c @@ -1,7 +1,11 @@ +/* le-altivec-consts.c: + Requires vmx_hw support to run. Requires altivec support to compile. + This test varies from altivec-consts.c in the ordering of the + vector elements below. */ /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */ -/* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */ +/* { dg-do compile { target { powerpc*-*-* } } } */ /* { dg-require-effective-target powerpc_altivec_ok } */ /* { dg-options "-maltivec -mabi=altivec -O2" } */ /* Check that "easy" AltiVec constants are correctly synthesized. */