| Message ID | 1517428237.11602.249.camel@brimstone.rchland.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [rs6000] fix-ups for vec-cmpne-long.c runtime tests | expand |
Hi! On Wed, Jan 31, 2018 at 01:50:37PM -0600, Will Schmidt wrote: > The vec-cmpne-long.c tests targets -mcpu=power8, but always dg-do-run, even > on P7 (or earlier) systems. Add a dg-do run requirement for p8vector_hw to > prevent illegal instruction errors. > (noticed during review of test results from a P7). > > Sniff tests look good. > > OK for trunk? Yes please, thanks! Some trivialities: > -/* { dg-do run { target { powerpc64*-*-* } } } */ > +/* { dg-do run { target { powerpc64*-*-* && { p8vector_hw } } } } */ Should this be powerpc*-*-* instead? Which is already implied of course, this is on gcc.target/powerpc. And you don't need braces around p8vector_hw if you put it first. Segher
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c index bf5866a..38ba397 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c @@ -1,6 +1,6 @@ -/* { dg-do run { target { powerpc64*-*-* } } } */ +/* { dg-do run { target { powerpc64*-*-* && { p8vector_hw } } } } */ /* { dg-require-effective-target powerpc_p8vector_ok } */ /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */ /* { dg-options "-mcpu=power8 -mpower8-vector -O3" } */ /* Test that the vec_cmpne builtin works as expected for long long
Hi, The vec-cmpne-long.c tests targets -mcpu=power8, but always dg-do-run, even on P7 (or earlier) systems. Add a dg-do run requirement for p8vector_hw to prevent illegal instruction errors. (noticed during review of test results from a P7). Sniff tests look good. OK for trunk? Thanks -Will [testsuite] 2018-01-31 Will Schmidt <will_schmidt@vnet.ibm.com> * gcc.target/powerpc/vec-cmpne-long.c: Add p8vector_hw require to dg-do run stanza.