From patchwork Mon Oct 23 12:58:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 829292 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-464754-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="BUzwQGZL"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yLGdj40q0z9t6C for ; Mon, 23 Oct 2017 23:57:28 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=R6HN0HePhEK1 TRfn2CCH/wKsETuJmDBAoEBfNibFi4oJxj8NA7eysOunfVx9Z1noefEx3H6yFGR2 /0UqPhc6Y3P2li5sH0ek70x3RU24wc/bznuqixPMFVxZVWq3yKbqS5/+Hv2MPFIE D0usv/cR6hWRv5Yq3ZdVTz5KjjT1OmE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=c3bUmbz8Watipsnlya IR9zgFq5E=; b=BUzwQGZLOKFvsfzSYe2TIgDDpGIF9KQsrRC/kd7gNAHFor9KnV G0Pc8z7CwjNfiVTSkl8BOaHWVh4ItYjsCq6pKsto9csxsoChyWIwRdyO+jIOmecK /uCS6KvIVDGi+CBY+XEDDLoBFTqUxfX3l2e08HiXGzGa4ky9ykIYTmkw8= Received: (qmail 24782 invoked by alias); 23 Oct 2017 12:57:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24762 invoked by uid 89); 23 Oct 2017 12:57:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Oct 2017 12:57:13 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 37B5F8048C; Mon, 23 Oct 2017 12:57:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 37B5F8048C Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dmalcolm@redhat.com Received: from c64.redhat.com (ovpn-112-12.phx2.redhat.com [10.3.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 644705D755; Mon, 23 Oct 2017 12:57:10 +0000 (UTC) From: David Malcolm To: Richard Biener Cc: Gerald Pfeifer , Pedro Alves , gcc-patches@gcc.gnu.org, Trevor Saunders , Jonathan Wakely , David Malcolm Subject: [PATCH] Include from system.h (PR bootstrap/82610) Date: Mon, 23 Oct 2017 08:58:18 -0400 Message-Id: <1508763498-38147-1-git-send-email-dmalcolm@redhat.com> X-IsSubscribed: yes On Sun, 2017-10-22 at 09:28 +0200, Gerald Pfeifer wrote: > On Thu, 19 Oct 2017, David Malcolm wrote: > > > In file included from /scratch/tmp/gerald/gcc-HEAD/gcc/unique- > > > ptr-tests.cc:23: > > > In file included from /scratch/tmp/gerald/gcc- > > > HEAD/gcc/../include/unique-ptr.h:77: > > > In file included from /usr/include/c++/v1/memory:629: > > > /usr/include/c++/v1/typeinfo:199:2: error: no member named > > > 'fancy_abort' in namespace 'std::__1'; did you mean simply > > > 'fancy_abort'? > > > _VSTD::abort(); > > > ^~~~~~~ > > > /usr/include/c++/v1/__config:390:15: note: expanded from macro > > > '_VSTD' > > > #define _VSTD std::_LIBCPP_NAMESPACE > > > > There seem to have been similar problems on OS X: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82610 > > Yes, I believe it's the same actually (unearthed by clang as system > compiler). > > > The proposed fix there is to include in system.h, which > > presumably would fix this also. > > That appears to work around the bootstrap failure on my tester as > well. > > How can we go about fixing this in the tree? > > Gerald Here's the patch by fxcoudert from the PR (plus a ChangeLog entry) Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu; reported by fxcoudert as fixing the issue on darwin and by Gerald as fixing the issue on "newer versions of FreeBSD that use clang 4.0 as system compiler". OK for trunk? Sorry again about the breakage. gcc/ChangeLog: PR bootstrap/82610 * system.h [__cplusplus]: Include . --- gcc/system.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/system.h b/gcc/system.h index f0664e9..d6e1637 100644 --- a/gcc/system.h +++ b/gcc/system.h @@ -233,6 +233,7 @@ extern int errno; # include #endif # include +# include # include # include #endif