diff mbox

[v2] Destroy arguments for _Cilk_spawn calling in the child (PR 80038)

Message ID 1493711779.24177.3.camel@stu.xidian.edu.cn
State New
Headers show

Commit Message

Xi Ruoyao May 2, 2017, 7:56 a.m. UTC 
On 2017-05-02 09:16 +0200, Andreas Schwab wrote:

> This could be related to --enable-checking=release:
> 
> In file included from ../../gcc/c-family/c-common.h:26:0,
>                  from ../../gcc/c-family/cilk.c:28:
> ../../gcc/c-family/cilk.c: In function 'bool cilk_set_spawn_marker(location_t, tree)':
> ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope
>                  CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
>                                           ^
> ../../gcc/c-family/cilk.c:113:9: note: in expansion of macro 'EXPR_CILK_SPAWN'
>          EXPR_CILK_SPAWN (fcall) = 1;
>          ^
> ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope
>                  CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
>                                           ^
> ../../gcc/c-family/cilk.c:115:9: note: in expansion of macro 'EXPR_CILK_SPAWN'
>          EXPR_CILK_SPAWN (TREE_OPERAND (fcall, 1)) = 1;
>          ^
> 
> Andreas.
> 

Sorry T_T.  I've made a stupid mistake in tree.h.

Let's apply following patch, and alert the RM when backporting r247446.

2017-05-02 Xi Ruoyao <ryxi@stu.xidian.edu.cn>

	* tree.h (EXPR_CILK_SPAWN): Use macro TREE_CHECK2 instead of
	function tree_check2.
---
 gcc/tree.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.1

Comments

Jeff Law May 2, 2017, 3:39 p.m. UTC | #1 
On 05/02/2017 01:56 AM, Xi Ruoyao wrote:
> On 2017-05-02 09:16 +0200, Andreas Schwab wrote:
> 
>> This could be related to --enable-checking=release:
>>
>> In file included from ../../gcc/c-family/c-common.h:26:0,
>>                   from ../../gcc/c-family/cilk.c:28:
>> ../../gcc/c-family/cilk.c: In function 'bool cilk_set_spawn_marker(location_t, tree)':
>> ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope
>>                   CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
>>                                            ^
>> ../../gcc/c-family/cilk.c:113:9: note: in expansion of macro 'EXPR_CILK_SPAWN'
>>           EXPR_CILK_SPAWN (fcall) = 1;
>>           ^
>> ../../gcc/tree.h:901:42: error: 'tree_check2' was not declared in this scope
>>                   CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
>>                                            ^
>> ../../gcc/c-family/cilk.c:115:9: note: in expansion of macro 'EXPR_CILK_SPAWN'
>>           EXPR_CILK_SPAWN (TREE_OPERAND (fcall, 1)) = 1;
>>           ^
>>
>> Andreas.
>>
> 
> Sorry T_T.  I've made a stupid mistake in tree.h.
> 
> Let's apply following patch, and alert the RM when backporting r247446.
> 
> 2017-05-02 Xi Ruoyao <ryxi@stu.xidian.edu.cn>
> 
> 	* tree.h (EXPR_CILK_SPAWN): Use macro TREE_CHECK2 instead of
> 	function tree_check2.
THanks.  Installed.

jeff
diff mbox

Patch

diff --git a/gcc/tree.h b/gcc/tree.h
index 3bca90a..fdaa7af 100644
--- a/gcc/tree.h
+++ b/gcc/tree.h
@@ -897,8 +897,8 @@  extern void omp_clause_range_check_failed (const_tree, const char *, int,
 /* If this is true, we should insert a __cilk_detach call just before
    this function call.  */
 #define EXPR_CILK_SPAWN(NODE) \
-  (tree_check2 (NODE, __FILE__, __LINE__, __FUNCTION__, \
-                CALL_EXPR, AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
+  (TREE_CHECK2 (NODE, CALL_EXPR, \
+                AGGR_INIT_EXPR)->base.u.bits.unsigned_flag)
 
 /* In a RESULT_DECL, PARM_DECL and VAR_DECL, means that it is
    passed by invisible reference (and the TREE_TYPE is a pointer to the true