From patchwork Fri May 20 19:22:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 624600 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rBHH10PZPz9sDD for ; Sat, 21 May 2016 04:57:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=wrItv1UG; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; q=dns; s= default; b=q2CbZgwFTXAXaJt/W3k5MBXwLLjAagavQ3i/7MWi7AU9W8NYLmiMA wsQ3F3cYGJlfkUOfOAZ1Q8XSFGZAJ8utjVu3qZDKjCSXxdPTdkuZ1RZFZR0c3ILR sWaafkOu/hb1ZM3zSRVtS2jVK9ks9mYXX1p6qYYG9nAEWTvov9Uyqg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; s= default; bh=mnjytgb57ev2k/l5HBkc2pLK7GA=; b=wrItv1UGSptulvPq/+nX Cn3bvtKE51gs/X2h67BrvZDo9WH0Tr6AWlM9WoIdDpQBCMibmcHb4pD5EeS856Xe JPDu0aHpGNmz7hJMuI+U/WQLboXmX1EaWQvD2RbKgKe+S0UFLVNoKoZ93n3C/wuk Lg6TmXK5iyDAL2OgwKpLCBI= Received: (qmail 11998 invoked by alias); 20 May 2016 18:56:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 11945 invoked by uid 89); 20 May 2016 18:56:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 May 2016 18:56:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B1F263320; Fri, 20 May 2016 18:56:47 +0000 (UTC) Received: from c64.redhat.com (vpn-237-77.phx2.redhat.com [10.3.237.77]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4KIukwA012735; Fri, 20 May 2016 14:56:46 -0400 From: David Malcolm To: Kyrill Tkachov , gcc-patches@gcc.gnu.org, jit@gcc.gnu.org Cc: David Malcolm Subject: [PATCH] calls.c: fix warning on targets without REG_PARM_STACK_SPACE Date: Fri, 20 May 2016 15:22:17 -0400 Message-Id: <1463772137-9323-1-git-send-email-dmalcolm@redhat.com> In-Reply-To: <573F4368.8090902@foss.arm.com> References: <573F4368.8090902@foss.arm.com> X-IsSubscribed: yes On Fri, 2016-05-20 at 18:03 +0100, Kyrill Tkachov wrote: [...snip...] > REG_PARM_STACK_SPACE is not defined on arm, which makes > reg_parm_stack_space > unused in this function and so breaks bootstrap on arm. > Can you please add an ATTRIBUTE_UNUSED to reg_parm_stack_space? > > Thanks, > Kyrill [...snip...] Sorry about the breakage. I manually verified that the following fixes the warning with --target=arm-linux-gnueabi. Successfully bootstrapped®rtested on x86_64-pc-linux-gnu. Committed to trunk as r236527. gcc/ChangeLog: * calls.c (can_implement_as_sibling_call_p): Mark param reg_parm_stack_space with ATTRIBUTE_UNUSED. --- gcc/calls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/calls.c b/gcc/calls.c index 1b12eca..587969f 100644 --- a/gcc/calls.c +++ b/gcc/calls.c @@ -2373,7 +2373,7 @@ static bool can_implement_as_sibling_call_p (tree exp, rtx structure_value_addr, tree funtype, - int reg_parm_stack_space, + int reg_parm_stack_space ATTRIBUTE_UNUSED, tree fndecl, int flags, tree addr,