From patchwork Tue May 17 08:54:51 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Greenhalgh X-Patchwork-Id: 622962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3r8B4W0Xg5z9t4P for ; Tue, 17 May 2016 18:55:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=l2kGxebO; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; q=dns; s=default; b=WCuNjHTRKJ7ou+J8bKCOJ/mZGQyMiPJRVkjH1EWhpr0clvcgPW RgffOgybpuuiBgCWWHmn1JRbj24sERc3n9uy+0LTiUY/BjbXrlb+mKQEXOoRF0cq 2Nw9RObQ0Opx7HuA0AhtNL5TfqYy7HOiXPaR4nudBemTDjXEnooyE8ZnU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:mime-version:content-type; s= default; bh=7qkk1uKZ2ggQRgeAx06u7feAqf0=; b=l2kGxebO9vJdBOexihvd YNxdj+y9lynYD1gM193SBMlQJM9O1HVaO6Ooq7sO+O8LicXdeZj2ht4dF6/dggTZ AAVesCZFISdzUe2sYySj3G3GzAegRwEBg9Txe/w5rQ3wdA9kbju40TsWFHt8leDV sytpxjCjb4BECIBhvs2uaAM= Received: (qmail 80367 invoked by alias); 17 May 2016 08:55:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 80297 invoked by uid 89); 17 May 2016 08:55:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Exchange-Antispam-Report-CFA-Test:102415293, HX-Exchange-Antispam-Report-CFA-Test:102615271 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 May 2016 08:55:17 +0000 Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3lrp0078.outbound.protection.outlook.com [213.199.154.78]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-25-BFDK1d7gS1a0Yf0SYmQMUg-1; Tue, 17 May 2016 09:55:12 +0100 Received: from AM3PR08CA0050.eurprd08.prod.outlook.com (10.163.23.146) by AM2PR08MB0227.eurprd08.prod.outlook.com (10.161.130.28) with Microsoft SMTP Server (TLS) id 15.1.497.12; Tue, 17 May 2016 08:55:10 +0000 Received: from DB3FFO11FD052.protection.gbl (2a01:111:f400:7e04::113) by AM3PR08CA0050.outlook.office365.com (2a01:111:e400:8854::18) with Microsoft SMTP Server (TLS) id 15.1.497.12 via Frontend Transport; Tue, 17 May 2016 08:55:10 +0000 Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD052.mail.protection.outlook.com (10.47.217.83) with Microsoft SMTP Server (TLS) id 15.1.497.8 via Frontend Transport; Tue, 17 May 2016 08:55:10 +0000 Received: from e107456-lin.cambridge.arm.com (10.1.2.79) by mail.arm.com (10.1.105.66) with Microsoft SMTP Server id 14.3.279.2; Tue, 17 May 2016 09:54:59 +0100 From: James Greenhalgh To: CC: , Subject: [AArch64 trivial] Don't define a macro when a variable will do Date: Tue, 17 May 2016 09:54:51 +0100 Message-ID: <1463475291-39979-1-git-send-email-james.greenhalgh@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:217.140.96.140; IPV:CAL; SCL:-1; CTRY:GB; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(438002)(199003)(377424004)(189002)(110136002)(189998001)(84326002)(586003)(33646002)(19580395003)(19580405001)(8676002)(6806005)(92566002)(87936001)(50986999)(86362001)(36756003)(11100500001)(8936002)(5003600100002)(77096005)(2351001)(229853001)(5000100001)(512874002)(4610100001)(106466001)(5890100001)(5008740100001)(4326007)(50226002)(1220700001)(104016004)(568964002)(450100001)(2476003)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR08MB0227; H:nebula.arm.com; FPR:; SPF:Pass; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; DB3FFO11FD052; 1:Zw1q/DQ7eY+FGMEW5Mk3WeanNLdAWmbKw55bfHl5VBRZ9k90tBdOekeQc9mjQjOUuJ8RzdPDJ1cQjKfJjHvwhCSWi6i/dU5sJsKkC5EBSrfnXHFR6twvMRGOHMudHtHhF3CRsbwWCOt0PUOSxUPUOmWvKDRP+q4eFyWrmW2QVZduJE7CuMeOFYbnZwAybUphhdxjdCAy14BSderakSNc+SAauvehYtlp4xeHQNNUynU7GA3TYe8V4eA3KFmlwttShLKOiy3GD5zmhfBk2YwStfrr5IVTnWbFTAEQdyKNG6hlLBnUWHl+U3B+GIyvQ26I6gx+TOJLuWh/Z1RDqxzSflQiVIdhHL6x0GpZ+VTpUUVyvABNXUtQtAr+S0pVKfW8uzt/iGHb9Hmi7KWFcGpSYJjoQKQ8/sVspBjCUQ3deJZsWv9hFYDgLWdxcEWXTGlIYxn0BXzle37+hXyOCW11hzR7drKZMUdZyuI9XQ0MkfRRwG5jdvO73gyN85aaC25h X-MS-Office365-Filtering-Correlation-Id: b4afb428-ef8b-4c53-c4ca-08d37e30f3f2 X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0227; 2:rGZcGiORPGWC66CjzTal2BsI0pZVOIyF6cNepvIKwc6ECna15kFz4lSpM6Y6sbTG3TyTUM95Lx6efMkotJ0OZuAEeY4dPaVyqIYgKHIBYakHeTAdjRb36ItuGy8CU9TzWkeRGAibfhbDOojoWQOGVSI8eni6Wv1qZWYSQqjUZqN08hS9Fa2UFfXZClmPst2q; 3:Ulo8Cb/efa0LNXpg9ZoJYWCmXgPUKXa87R8x6OBCNKPsRo7KOceWHzEBuTZpPETjxEG7QvI0oLnFdn99WKto+borQxSrigM1o7+2LDnJrxH51C+S+RFxvtMwkhlxMpJVCNXDxZQmNG4Wf6dDeIsb/avsCEGjNrjzZLH6SQ2GWDOhlOvV0wSu4TrKL1NrsEWvGINDA4Mu4TBvM7hHNc/T0OdDJB6Sv9cvzx0KOHEGCgmMORdeM4m+o2ri9DaJHwS4XZ1c4KRtjS9hkfveYLsTpg== X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:AM2PR08MB0227; X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0227; 25:mElqr40vHWRmdempKM6yg1i9OJa3BsNfbqdVCQWVOJYFBF12AqoMTlVZm/nN5dh9tEvfJTiWcyCod5MotCiwWK0rIPrgIC2A6PEMV97EmBeAr2i5v4rmcxcxhd7uocFJspIuHNwtsM6j5IHRkUPJdz03hjCQ8lf8PKvJGXgiwMCrox4CYYdPtllxO9Q3mGPqpxL3Y+UT7A8Tfa/dt6oAY+uong61RL/KhurBJseeBdPrf9M+XFxr2a11NQBeWM4cYBG2WWh0G4hHQRhP/CZsanh18pvJIOtTfgJxKoW9JPvo8V3dXd0sSXlMfNuAFiuC9DD3PxUWww0V32bbRu9uCRieFlXyQAPHfGRsHRej1xBqj34aGjVbr1Ovyn218zd9YtHuyUnpm3dUK7K/R+uxzHDGmRa8Jc8PgEaNJFHdpZbyjuazHOkqtO34/ePlShLuhVGyG2sJ9hahwGVYN6qRTtrY2yw2KgAYifR7wLEFjQPxsi5J3syuIYLQGrFTpzr5AP5JZCF1mW9NBRNvecLlmN5ETo+jGAWEydFZBZqv8v2GnkfAfrBpskqPKrufZlCvMvBZA9vCArDIhvDyj8H8BmOXvbmYFGqP37WyIYw7lqjtVz6Mz2a0bSxsw/Y8pnIJGBgcQvXwEosa5WBQsEK6pz7sSrhhDNLjKX46sbbHGOzRAh8bgRfvck+LGhD/WIweuqn9Wl4b/hUtuuhjIE/Fbrh/aZGQ97jcDdZPRDVFvswxQeR9D1+CRhIm5X9fkwlLhkkHb1yDZafojJXWDV1aCe7bbV9a3mmluMg2jDFUsQ/wfXC73GxAp3kIBqMSFQIEeRJNhx8+3xgTn9LNIkuLtNa+55P1vvaTmrzvJQ8IV9bLXkfLFljIWlNgR+f/eTdUvbPtIAeJvGUR2yIAMQq6vBAJHYm/rdScEebnc0e/Hak= NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0227; 20:4xcLA6oteRBrUGGIkqwqQzfKvNljpIBLXAJC8+moI2klNYYL36qr3Rft6f/tzLO4RICaPolIg+Gmill78yx/cSrSvzwIzzX52gdBLPxzapf18n+FFiyu2GIQgGVKZrjrNIuu73LVVYCftZnJTGqy/4h69+PKjf0xqGyRwJycxJSUijmvBJVfibWnf5Yf5oDE7O011WZ3bqjZfRsTSYLdPEu8l0eo0bP9Os/zC1EOFew0TXXdxdJEI8XwxwD7hueT; 4:qQLvh8N0Sc6t9TFisdQ72Nw5zztFhA4NSnKC90rTdbhN4eRP3wn5N6jwfAVJuQ6jp+B7G3vOCbvWM3HpcLp7YCmFrxiuqo4K5GmyxRl3vX3a5rseKSxtlwU3DgNtz5j99D8BC0OZaq+kgreKfVxwIDUjVqsA9vyZv50hj52L4UcBvrIr34IsOO7Qck2tsaCnncpIzgFjakhAq6vPbRxLU9ehxK0IYscoErtELeyL4kexN4orc38B0//CwCezLpjlMoLkO0qTLtNNOcmR/JcTSdvwwtfhFIjPyoIo7O7BwGMCK3twSub6SjRfJWwA80k9Z1kmq2z6wVzvL+F6ypwl61tr2u8zMzBM7bO/d//Ryffea+QteppCW3g1MW/Gv5zlETSJvOrdGN85pu5LzwCh35OC5s/kLBqNH51zjfWnlxtLVkG0RJPEtyTvDBUm+YT3osZcceFbpeSLWvXvlelDUlYHw+sF/2XGETUoK0sDZ9j6x6/62iM1H1EaCdcw4MCR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(102415293)(102615271)(601004)(2401047)(13024025)(13020025)(13023025)(13013025)(8121501046)(5005006)(3002001)(10201501046)(6055026); SRVR:AM2PR08MB0227; BCL:0; PCL:0; RULEID:; SRVR:AM2PR08MB0227; X-Forefront-PRVS: 0945B0CC72 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM2PR08MB0227; 23:dSroTaNnc132KXYK6sY2ruIwq7wmmf81z8xaTN6hU?= =?us-ascii?Q?nE0YbmDHVSzApuUvZrS5GTMrqHAh5/rLyKfZZndcYEztUASWsRjEWxfP3ZXx?= =?us-ascii?Q?NQG0qvJmejCJHr0OOfLCytoFiRLYuJJneYdjAC/GTVvCLUBLotVCqyKe+mBr?= =?us-ascii?Q?8byyKYpqFBrcunsoy2R/EqnQ3gbewg7a7M8d3/W8MqSEuXEvBk5Z0XqOFxPj?= =?us-ascii?Q?Kx5iPzsZ0AVTdNIhGwtYJ94xh+ORbJ2qPWUMOVlRLS7ZyNkBJ3VcqOfUfliL?= =?us-ascii?Q?juc0tF1PCCqri/cC3cdTC8jZ/DqG4MNgRUEreMIhQDlQVt1YJdCxAdgO9jK8?= =?us-ascii?Q?t3n3dJRwRozqXkXn4dG43ATK0xYwcUUGCxA5UFo0BDvFBOWekBHNI04dvesz?= =?us-ascii?Q?YCUIH8gaXHQ4l62mxtU1CAHXZ2P6OyZIPvmSCMqhoIvGoe9MgrBTcW/wwBSV?= =?us-ascii?Q?rQAi0uOhjhkotJ6e3l2nx7B/1KToBp5iboRWKviXj5PxXJCnC2i4ETzfPQiU?= =?us-ascii?Q?YvUsgPTKk1jsO8bybDPDpX3wZJ1KMjmQX3ROLqHuYdUu0jKDGanyuwh0hGg2?= =?us-ascii?Q?mn3HShYd9VDAWbhlfy0D5dXjiuqwVsIfy5CM6xEuOS0dxYpdNMjWYVsZGQ09?= =?us-ascii?Q?2uxa/JhswChIQnX4BKEDvC1ohjvEt8YPXvVIOeUbBPzn3t/FQ/Q4mFUrF0a5?= =?us-ascii?Q?M/jcpJ3XArMkQKGMEae4TwRmMlVR94mJ9HK8rPa2+3t/ejepfNSJU8QIEmD4?= =?us-ascii?Q?NssCbAsvnYw2XGwOeu7Yb5jXf0ZaF80ngdWeWZnHuC/UppAeKkd89hWnADkY?= =?us-ascii?Q?bjAcB3iDfYL0uwegYQToEB3mXojhcrUbxUMSFgA2jf0XFyTxjl19ZpLkRCce?= =?us-ascii?Q?mSa4cbEBxAokf4YoNpsUz+s/aNlpsCFHFZnaks2MtplD15vXrNaVLSHLwa6T?= =?us-ascii?Q?bpr588PjBrapioW0I/YwgvhMDtGMqAoB8VpISwa4vIsFvitWettx7BvdKPys?= =?us-ascii?Q?Dig8ogClxMeiD//aZI0gvi9oYiwaWVgtmxHikZPMZ8OYrjrkGLrhqQZ5nEcQ?= =?us-ascii?Q?X9NmKw=3D?= X-Microsoft-Exchange-Diagnostics: 1; AM2PR08MB0227; 5:EEtHSt1u6t/OCn3UTQs84xXRGw+ELx2brxeKjH8asb1LXgpQfrE5XF3CgRUxiQNZ1ibnMKDPKRGmNkqf+NgEOy+sIjhBnuhiFxKpNYnlAY765W20gd8pN0GlbwdNRrvmBRlRTA5S/L1WTKnCUkSSDg==; 24:1bR8u8RyeUfQ84CDqkpodtMUXqkz19XqZrTaJ4yWvAmaH/DP8JUmu/Wh1g74hZNe5ZS3Jo8pixZQQd4U3xV4+w6Qk3YYqwQaz50XsJnGyWg=; 7:w8sEfI8/kH4jwtlRKFBJfDtnah+EAZ59ymZwUs7/rXvEmrcBT8v92cgRnkwbwOdLwdbWV005suLk7x4LqOkAb10ibx3Y/MLGU8BJBhNpC90j3CIIHr1AcOJXuEmL0IVmdW18pcFg65GVWhfMyiv8S/s5Rkcg2Bd426qxPvcUUxTvU+DQ9D/bOdiaY4gh8F9c; 20:Qq+b5y0xTKQk5zVskZVC6qV+dJAMwpK+ax3U6k+gP0C63FWdavGt0hTnl3HdiG4qx07qdlNSS+B35Bu7CrBbCIGtofBjxY/+gFicdqL4xo/83e4slpDKj7RUpP0s+MIhLrwi7BNvQ6GM1zhYRLmAYjHeGffjEaNdstOig3hT/2w= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 08:55:10.3023 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[217.140.96.140]; Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR08MB0227 X-MC-Unique: BFDK1d7gS1a0Yf0SYmQMUg-1 X-IsSubscribed: yes Hi, As title, this use of macros doesn't make much sense to me. We can just do this as a const unsigned int. Comitted as obvious as revision 236311. OK? Thanks, James --- 2016-05-17 James Greenhalgh * config/aarch64/aarch64.c (aarch64_output_simd_mov_immediate): Make "buf_size" a variable rather than a macro. diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index e081b16..986262b 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -11845,12 +11845,11 @@ aarch64_output_simd_mov_immediate (rtx const_vector, info.value = GEN_INT (0); else { -#define buf_size 20 + const unsigned int buf_size = 20; char float_buf[buf_size] = {'\0'}; real_to_decimal_for_mode (float_buf, CONST_DOUBLE_REAL_VALUE (info.value), buf_size, buf_size, 1, mode); -#undef buf_size if (lane_count == 1) snprintf (templ, sizeof (templ), "fmov\t%%d0, %s", float_buf);