| Message ID | 1457698302-14689-1-git-send-email-alan.lawrence@arm.com |
|---|---|
| State | New |
| Headers | show |
On Fri, Mar 11, 2016 at 12:11:42PM +0000, Alan Lawrence wrote: > On 10/03/16 16:18, Dominique d'Humières wrote: > > > The test gfortran.dg/unconstrained_commons.f fails in the 32 bit mode. It > > needs some regexp > > Indeed, confirmed on ARM, sorry for not spotting this earlier. > > I believe the variable, if there is one, should always be called 'j', as it is > in the source. So how about this, tested on ARM, AArch64, x86_64? > > gcc/testsuite/ChangeLog: > > * gfortran.dg/unconstrained_commons.f: Widen regexp to match j_<N> Ok. > gcc/testsuite/gfortran.dg/unconstrained_commons.f | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gfortran.dg/unconstrained_commons.f b/gcc/testsuite/gfortran.dg/unconstrained_commons.f > index f9fc471..bee67ab 100644 > --- a/gcc/testsuite/gfortran.dg/unconstrained_commons.f > +++ b/gcc/testsuite/gfortran.dg/unconstrained_commons.f > @@ -17,4 +17,4 @@ > ! { dg-final { scan-tree-dump-not "FIND" "dom2" } } > ! We should retain both a read and write of mycommon.x. > ! { dg-final { scan-tree-dump-times " _\[0-9\]+ = mycommon\\.x\\\[_\[0-9\]+\\\];" 1 "dom2" } } > -! { dg-final { scan-tree-dump-times " mycommon\\.x\\\[_\[0-9\]+\\\] = _\[0-9\]+;" 1 "dom2" } } > +! { dg-final { scan-tree-dump-times " mycommon\\.x\\\[j?_\[0-9\]+\\\] = _\[0-9\]+;" 1 "dom2" } } Jakub
diff --git a/gcc/testsuite/gfortran.dg/unconstrained_commons.f b/gcc/testsuite/gfortran.dg/unconstrained_commons.f index f9fc471..bee67ab 100644 --- a/gcc/testsuite/gfortran.dg/unconstrained_commons.f +++ b/gcc/testsuite/gfortran.dg/unconstrained_commons.f @@ -17,4 +17,4 @@ ! { dg-final { scan-tree-dump-not "FIND" "dom2" } } ! We should retain both a read and write of mycommon.x. ! { dg-final { scan-tree-dump-times " _\[0-9\]+ = mycommon\\.x\\\[_\[0-9\]+\\\];" 1 "dom2" } } -! { dg-final { scan-tree-dump-times " mycommon\\.x\\\[_\[0-9\]+\\\] = _\[0-9\]+;" 1 "dom2" } } +! { dg-final { scan-tree-dump-times " mycommon\\.x\\\[j?_\[0-9\]+\\\] = _\[0-9\]+;" 1 "dom2" } }