| Message ID | 1455017097-24724-1-git-send-email-james.greenhalgh@arm.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Feb 9, 2016 at 12:24 PM, James Greenhalgh <james.greenhalgh@arm.com> wrote: > > On Mon, Feb 08, 2016 at 03:24:14PM +0100, Richard Biener wrote: >> On Mon, Feb 8, 2016 at 2:40 PM, James Greenhalgh >> <james.greenhalgh@arm.com> wrote: >> > On Mon, Feb 08, 2016 at 04:29:31PM +0300, Yuri Rumyantsev wrote: >> >> Hi James, >> >> >> >> Thanks for reporting this issue. >> >> I prepared slightly different patch since we don't need to add >> >> tree-vect dump option - it is on by default for all tests in /vect >> >> directory. >> > >> > Hm, I added that line as my test runs were showing: >> > >> > UNRESOLVED: gcc.dg/vect/vect-mask-store-move-1.c: dump file does not exist >> > >> > I would guess the explicit >> > >> > /* { dg-options "-O3" } */ >> > >> > is clobbering the vect.exp setup of flags? >> >> Yes. Use { dg-additional-options "-O3" } instead. > > I don't see why this test needs anything more than the default vect > options anyway... In which case, the patch would look like this. > > Tested on x86-64 where the test passes, and on AArch64 where it is > correctly skipped. > > OK? Ok. Richard. > Thanks, > James > > --- > 2016-02-09 James Greenhalgh <james.greenhalgh@arm.com> > > * gcc.dg/vect/vect-mask-store-move-1.c: Drop dg-options directive, > gate check on x86_64/i?86. >
On Tue, Feb 09, 2016 at 11:24:57AM +0000, James Greenhalgh wrote: Also tested on i686-linux (32-bit), where it previously FAILed too. > 2016-02-09 James Greenhalgh <james.greenhalgh@arm.com> > > * gcc.dg/vect/vect-mask-store-move-1.c: Drop dg-options directive, > gate check on x86_64/i?86. Ok, thanks. > diff --git a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c > index e575f6d..f5cae4f 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c > @@ -1,5 +1,4 @@ > /* { dg-do compile } */ > -/* { dg-options "-O3" } */ > /* { dg-additional-options "-mavx2" { target { i?86-*-* x86_64-*-* } } } */ > > #define N 256 > @@ -16,4 +15,4 @@ void foo (int n) > } > } > > -/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" } } */ > +/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" { target { i?86-*-* x86_64-*-* } } } } */ Jakub
diff --git a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c index e575f6d..f5cae4f 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c +++ b/gcc/testsuite/gcc.dg/vect/vect-mask-store-move-1.c @@ -1,5 +1,4 @@ /* { dg-do compile } */ -/* { dg-options "-O3" } */ /* { dg-additional-options "-mavx2" { target { i?86-*-* x86_64-*-* } } } */ #define N 256 @@ -16,4 +15,4 @@ void foo (int n) } } -/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" } } */ +/* { dg-final { scan-tree-dump-times "Move stmt to created bb" 6 "vect" { target { i?86-*-* x86_64-*-* } } } } */