From patchwork Thu Oct 29 19:18:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Lawrence X-Patchwork-Id: 537986 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 535FE14031C for ; Fri, 30 Oct 2015 06:22:15 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=m69dZKRH; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:in-reply-to:references:content-type :content-transfer-encoding; q=dns; s=default; b=StutnyhBfkUo56Or VHZ6i1EVWhcR3sQdHfRSUgJRo5DUZmNztMsYFb7dJXOsp4KHWykkCnfJFj7SzVb4 h5J0XqHIi9izvlslRp6tNwStKPC+AunZsSqDHYGgSL+LZVXPeersQQUXzq6AmVLx 8b+i5jwwdlG5nul1XVe+nMuPI1Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:in-reply-to:references:content-type :content-transfer-encoding; s=default; bh=NsEZ5/3Re6vTSCZ65Jyi1g KQ3PY=; b=m69dZKRHN9/7oKwCihi6bTSS4UwJ4B8lfl1FZgJzQzT+TXEOUM5FxL b7p2a41HKhTAsQFqIttgi8nwezeOEngGq1JLe5sK726JPcEIgcgENbvfkjLQ3Z/z gIIwdpiPuQv/NNHUAxELwR9XS7zkqG9kErmDALqVphk8XWvSrxCqQ= Received: (qmail 110329 invoked by alias); 29 Oct 2015 19:22:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 110315 invoked by uid 89); 29 Oct 2015 19:22:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Oct 2015 19:22:04 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-7-kKWAiyk1RSGFvaNxlPScbw-11; Thu, 29 Oct 2015 19:20:44 +0000 Received: from arm.com ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 29 Oct 2015 19:20:41 +0000 From: Alan Lawrence To: gcc-patches@gcc.gnu.org Subject: [PATCH 4/6][Trivial] tree-sra.c: A few comment fixes/additions. Date: Thu, 29 Oct 2015 19:18:20 +0000 Message-Id: <1446146302-17002-5-git-send-email-alan.lawrence@arm.com> In-Reply-To: <1446146302-17002-1-git-send-email-alan.lawrence@arm.com> References: <1446146302-17002-1-git-send-email-alan.lawrence@arm.com> X-MC-Unique: kKWAiyk1RSGFvaNxlPScbw-11 X-IsSubscribed: yes gcc/ChangeLog: * tree-sra.c (scalarizable_type_p): Comment variable-length arrays. (completely_scalarize): Comment zero-length arrays. (get_access_replacement): Correct comment re. precondition. --- gcc/tree-sra.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index f851758..e15df1f 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -956,6 +956,7 @@ scalarizable_type_p (tree type) ; else if ((tree_to_shwi (TYPE_SIZE (type)) <= 0) || !tree_fits_shwi_p (TYPE_MAX_VALUE (TYPE_DOMAIN (type)))) + /* Variable-length array, do not allow scalarization. */ return false; tree elem = TREE_TYPE (type); @@ -1005,6 +1006,7 @@ completely_scalarize (tree base, tree decl_type, HOST_WIDE_INT offset, tree ref) tree minidx = TYPE_MIN_VALUE (TYPE_DOMAIN (decl_type)); gcc_assert (TREE_CODE (minidx) == INTEGER_CST); tree maxidx = TYPE_MAX_VALUE (TYPE_DOMAIN (decl_type)); + /* Skip (some) zero-length arrays; others have MAXIDX == MINIDX - 1. */ if (maxidx) { gcc_assert (TREE_CODE (maxidx) == INTEGER_CST); @@ -2146,7 +2148,7 @@ create_access_replacement (struct access *access) return repl; } -/* Return ACCESS scalar replacement, create it if it does not exist yet. */ +/* Return ACCESS scalar replacement, which must exist. */ static inline tree get_access_replacement (struct access *access)