From patchwork Fri Oct 23 20:41:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 535247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 99ECF141364 for ; Sat, 24 Oct 2015 07:25:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=HyNkYGlw; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; q=dns; s= default; b=beVWccNqBd6ITHeseUTZjBYkjxv6Z+x2XwRs+THDUPOyodoTiibmW 1V0rE1FEhbOro2YTiY5VfdQ9y9pZeuSqo7WgNp5P3qdszfWTFbWANvp7r0a/PQux 93HkiPZkUdRhcBIHPKCmvdDuF1IG/jen4dxCaSsYDtyVRzVC6lvB94= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references; s= default; bh=nfyZ4uxS0+xl9TaMKPxp0AMIPxs=; b=HyNkYGlwUH7r3yaS8Qgd t/2JQ+1Y776cdpmD737JRu+kHlid2zwK1w1KEBvt11tJDUeTwrnRjlW3xO/urZTV 5slbBWWMKbUfMJMgFp+iqomSxg6GdCI78ywCjrxeEzj4jXJNe2JVIt0ZOyug3XcS BmLoUDJ2txfnfoTxzAoqvkk= Received: (qmail 9563 invoked by alias); 23 Oct 2015 20:24:24 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9419 invoked by uid 89); 23 Oct 2015 20:24:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 23 Oct 2015 20:24:22 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id A6FFC54 for ; Fri, 23 Oct 2015 20:24:21 +0000 (UTC) Received: from c64.redhat.com (vpn-230-149.phx2.redhat.com [10.3.230.149]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9NKOJgS007382; Fri, 23 Oct 2015 16:24:21 -0400 From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 03/10] libstdc++v3: Explicitly disable carets and colorization within testsuite Date: Fri, 23 Oct 2015 16:41:51 -0400 Message-Id: <1445632918-29617-4-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1445632918-29617-1-git-send-email-dmalcolm@redhat.com> References: <1442957171-22904-1-git-send-email-dmalcolm@redhat.com> <1445632918-29617-1-git-send-email-dmalcolm@redhat.com> X-IsSubscribed: yes Later on in this patch kit, with token range underlining, the libstdc++v3 testsuite starts showing numerous failures of the form: FAIL: 17_intro/using_namespace_std_tr1_neg.cc (test for excess errors) The excess errors turn out to be the source code and caret/underlines emitted after an "error": using namespace std::tr1; // { dg-error "is not a namespace-name" } ^~~ However, looking at the results of a control build of r228618, I see the testsuite emit code and carets (albeit without underlines): using namespace std::tr1; // { dg-error "is not a namespace-name" } ^ and for some reason this is treated by dg.exp as: PASS: 17_intro/using_namespace_std_tr1_neg.cc (test for excess errors) It's not clear to me why the status quo isn't treating the lines of dumped source code and caret as "excess errors", but the attached patch explicitly disables carets and colorization. libstdc++-v3/ChangeLog: * testsuite/lib/libstdc++.exp (v3_target_compile): Add -fno-diagnostics-show-caret -fdiagnostics-color=never to option's additional_flags. --- libstdc++-v3/testsuite/lib/libstdc++.exp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index 88738b7..ac3654b 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -462,6 +462,8 @@ proc v3_target_compile { source dest type options } { global STATIC_LIBCXXFLAGS global tool + lappend options "additional_flags=-fno-diagnostics-show-caret -fdiagnostics-color=never" + if { [target_info needs_status_wrapper] != "" && [info exists gluefile] } { lappend options "libs=${gluefile}" lappend options "ldflags=${wrap_flags}"