diff mbox

[v2] New testcase to check parameter passing bug

Message ID 1426729244-12509-1-git-send-email-hong.gyu.kim@lge.com
State New
Headers show

Commit Message

Honggyu Kim March 19, 2015, 1:40 a.m. UTC 
Hi,

I have modified the test-case to check parameter passing bug based on the
comments from Kyrill Tkachov, Christophe Lyon, and Segher Boessenkool
as follows:
 1. move from "gcc.target/arm" to "gcc.dg"
 2. change "dg-do compile" to "dg-do run"

Please let me know if there's still something to fix more.
Thanks for your comment.

Honggyu
---
 gcc/testsuite/ChangeLog        |    4 ++++
 gcc/testsuite/gcc.dg/pr65358.c |   33 +++++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 gcc/testsuite/gcc.dg/pr65358.c

Comments

Honggyu Kim March 19, 2015, 1:58 a.m. UTC | #1 
On Thu, Mar 19, 2015 at 10:40:44AM +0900, Honggyu Kim wrote:
> ---
>  gcc/testsuite/ChangeLog        |    4 ++++
>  gcc/testsuite/gcc.dg/pr65358.c |   33 +++++++++++++++++++++++++++++++++
>  2 files changed, 37 insertions(+)
>  create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
> 
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 77d24a1..218f908 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> 
I'm kind of new to gcc community and I'm used to send a patch throught
git send-email. If you have other preferable way, please let me know.
I will try to follow the format and style more like other gcc patches.
Thanks you all.

Honggyu
Jeff Law March 25, 2015, 12:27 p.m. UTC | #2 
On 03/18/15 19:40, Honggyu Kim wrote:
> Hi,
>
> I have modified the test-case to check parameter passing bug based on the
> comments from Kyrill Tkachov, Christophe Lyon, and Segher Boessenkool
> as follows:
>   1. move from "gcc.target/arm" to "gcc.dg"
>   2. change "dg-do compile" to "dg-do run"
>
> Please let me know if there's still something to fix more.
> Thanks for your comment.
>
> Honggyu
> ---
>   gcc/testsuite/ChangeLog        |    4 ++++
>   gcc/testsuite/gcc.dg/pr65358.c |   33 +++++++++++++++++++++++++++++++++
>   2 files changed, 37 insertions(+)
>   create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
>
> diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
> index 77d24a1..218f908 100644
> --- a/gcc/testsuite/ChangeLog
> +++ b/gcc/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2015-03-19  Honggyu Kim  <hong.gyu.kim@lge.com>
> +
> +	* gcc.dg/pr65358.c: New test.
This should be included as part of Kyrill's patch.  If the test goes in 
without Kryill's fix, then it'll just create testsuite noise.

Jeff
Kyrylo Tkachov March 25, 2015, 2:05 p.m. UTC | #3 
> -----Original Message-----
> From: Jeff Law [mailto:law@redhat.com]
> Sent: 25 March 2015 12:27
> To: Honggyu Kim; gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov; segher@kernel.crashing.org; christophe.lyon@st.com
> Subject: Re: [PATCH v2] New testcase to check parameter passing bug
> 
> On 03/18/15 19:40, Honggyu Kim wrote:
> > Hi,
> >
> > I have modified the test-case to check parameter passing bug based on
> > the comments from Kyrill Tkachov, Christophe Lyon, and Segher
> > Boessenkool as follows:
> >   1. move from "gcc.target/arm" to "gcc.dg"
> >   2. change "dg-do compile" to "dg-do run"
> >
> > Please let me know if there's still something to fix more.
> > Thanks for your comment.
> >
> > Honggyu
> > ---
> >   gcc/testsuite/ChangeLog        |    4 ++++
> >   gcc/testsuite/gcc.dg/pr65358.c |   33
> +++++++++++++++++++++++++++++++++
> >   2 files changed, 37 insertions(+)
> >   create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
> >
> > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index
> > 77d24a1..218f908 100644
> > --- a/gcc/testsuite/ChangeLog
> > +++ b/gcc/testsuite/ChangeLog
> > @@ -1,3 +1,7 @@
> > +2015-03-19  Honggyu Kim  <hong.gyu.kim@lge.com>
> > +
> > +	* gcc.dg/pr65358.c: New test.
> This should be included as part of Kyrill's patch.  If the test goes in
without
> Kryill's fix, then it'll just create testsuite noise.

I'll make sure to commit this together with my fix (at
https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01014.html)
if it gets approved. I agree that there's no point taking the test in by
itself .

Thanks,
Kyrill

> 
> Jeff
>
Honggyu Kim March 29, 2015, 11:36 a.m. UTC | #4 
On Wed, Mar 25, 2015 at 02:05:37PM -0000, Kyrill Tkachov wrote:
> 
> 
> > -----Original Message-----
> > From: Jeff Law [mailto:law@redhat.com]
> > Sent: 25 March 2015 12:27
> > To: Honggyu Kim; gcc-patches@gcc.gnu.org
> > Cc: Kyrylo Tkachov; segher@kernel.crashing.org; christophe.lyon@st.com
> > Subject: Re: [PATCH v2] New testcase to check parameter passing bug
> > 
> > On 03/18/15 19:40, Honggyu Kim wrote:
> > > Hi,
> > >
> > > I have modified the test-case to check parameter passing bug based on
> > > the comments from Kyrill Tkachov, Christophe Lyon, and Segher
> > > Boessenkool as follows:
> > >   1. move from "gcc.target/arm" to "gcc.dg"
> > >   2. change "dg-do compile" to "dg-do run"
> > >
> > > Please let me know if there's still something to fix more.
> > > Thanks for your comment.
> > >
> > > Honggyu
> > > ---
> > >   gcc/testsuite/ChangeLog        |    4 ++++
> > >   gcc/testsuite/gcc.dg/pr65358.c |   33
> > +++++++++++++++++++++++++++++++++
> > >   2 files changed, 37 insertions(+)
> > >   create mode 100644 gcc/testsuite/gcc.dg/pr65358.c
> > >
> > > diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index
> > > 77d24a1..218f908 100644
> > > --- a/gcc/testsuite/ChangeLog
> > > +++ b/gcc/testsuite/ChangeLog
> > > @@ -1,3 +1,7 @@
> > > +2015-03-19  Honggyu Kim  <hong.gyu.kim@lge.com>
> > > +
> > > +	* gcc.dg/pr65358.c: New test.
> > This should be included as part of Kyrill's patch.  If the test goes in
> without
> > Kryill's fix, then it'll just create testsuite noise.
> 
> I'll make sure to commit this together with my fix (at
> https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01014.html)
> if it gets approved. I agree that there's no point taking the test in by
> itself .
> 
> Thanks,
> Kyrill
> 
> > 
> > Jeff
> > 

I have tested Kyrill's patch and it works fine.
Thanks for all your comments.
Especially, Mikael Pettersson's help for this testcase.

Honggyu
diff mbox

Patch

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 77d24a1..218f908 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@ 
+2015-03-19  Honggyu Kim  <hong.gyu.kim@lge.com>
+
+	* gcc.dg/pr65358.c: New test.
+
 2015-03-18  Paolo Carlini  <paolo.carlini@oracle.com>
 
 	PR c++/59816
diff --git a/gcc/testsuite/gcc.dg/pr65358.c b/gcc/testsuite/gcc.dg/pr65358.c
new file mode 100644
index 0000000..ba89fd4
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr65358.c
@@ -0,0 +1,33 @@ 
+/* { dg-do run } */
+/* { dg-options "-O2" } */
+
+struct pack
+{
+  int fine;
+  int victim;
+  int killer;
+};
+
+int __attribute__ ((__noinline__, __noclone__))
+bar (int a, int b, struct pack p)
+{
+  if (a != 20 || b != 30)
+    __builtin_abort ();
+  if (p.fine != 40 || p.victim != 50 || p.killer != 60)
+    __builtin_abort ();
+  return 0;
+}
+
+int __attribute__ ((__noinline__, __noclone__))
+foo (int arg1, int arg2, int arg3, struct pack p)
+{
+  return bar (arg2, arg3, p);
+}
+
+int main (void)
+{
+  struct pack p = { 40, 50, 60 };
+
+  (void) foo (10, 20, 30, p);
+  return 0;
+}