From patchwork Mon Jan 19 17:28:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 430618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 74C3A14012A for ; Tue, 20 Jan 2015 04:19:06 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; q=dns; s=default; b=nO07qeWeKOZU j7ZMzyVI4cYY3EED1krkUR+SFojhVJXVrf41Yg3ldDKpQQlF2u08YLCjgDaMaOgO ricmiFK7byrqgZkBnRVFz9WWtGKhDwI4BzzNHlcVPbV5212H7uX1hJcNVw3SLLdg 5rm2AYMELErJoHHXmTREvYE0+ryjcN8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id; s=default; bh=3WEyXCvu78UqPwJW9F 4NsT6Tfe4=; b=B9r47mJSiRCSs66eDT5NaaQSjsTAuFZDYwIAdNyPBHnCw3Q2f+ eu/oDRqSps4McU+HenwdYKLHx8BeG7RsE8+t2GfhtYgC3qZwSGh/C3+Xl3/uxkN5 cUT0tUaoMJhmtxzuOmrg+BBj4duvjB9V9cq9Sps4HoScB6c5/pk3asoQo= Received: (qmail 23047 invoked by alias); 19 Jan 2015 17:18:59 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 23026 invoked by uid 89); 19 Jan 2015 17:18:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 19 Jan 2015 17:18:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0JHItXP028544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Jan 2015 12:18:56 -0500 Received: from c64.redhat.com (vpn-227-212.phx2.redhat.com [10.3.227.212]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0JHItM3021155; Mon, 19 Jan 2015 12:18:55 -0500 From: David Malcolm To: jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH, committed] jit: fix crash in memento_of_new_string_literal::make_debug_string Date: Mon, 19 Jan 2015 12:28:00 -0500 Message-Id: <1421688480-21771-1-git-send-email-dmalcolm@redhat.com> X-IsSubscribed: yes Fix a crash due to missing a format string in a printf-style call, when printing a string literal that contains formatting characters. Seen on aarch64, where the patch takes jit.sum to: # of expected passes 7514 and no failures. Committed to trunk as r219851. gcc/jit/ChangeLog: * jit-recording.c (gcc::jit::recording::memento_of_new_string_literal::make_debug_string): Add missing format string. --- gcc/jit/jit-recording.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/jit/jit-recording.c b/gcc/jit/jit-recording.c index 76eabbd..2900e18 100644 --- a/gcc/jit/jit-recording.c +++ b/gcc/jit/jit-recording.c @@ -4012,6 +4012,7 @@ recording::string * recording::memento_of_new_string_literal::make_debug_string () { return string::from_printf (m_ctxt, + "%s", m_value->get_debug_string ()); }