diff mbox

[[ARM/AArch64,testsuite] 02/36] Be more verbose, and actually confirm that a test was checked.

Message ID 1421162314-25779-3-git-send-email-christophe.lyon@linaro.org
State New
Headers show

Commit Message

Christophe Lyon Jan. 13, 2015, 3:18 p.m. UTC 
* gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (CHECK):
	Add trace.
	(CHECK_FP): Likewise.
	(CHECK_CUMULATIVE_SAT): Likewise.

Comments

Tejas Belagod Jan. 16, 2015, 1:43 p.m. UTC | #1 
On 13/01/15 15:18, Christophe Lyon wrote:
> 	* gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (CHECK):
> 	Add trace.
> 	(CHECK_FP): Likewise.
> 	(CHECK_CUMULATIVE_SAT): Likewise.
>
> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
> index 6464c66..2730a66 100644
> --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
> +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
> @@ -79,6 +79,7 @@ extern size_t strlen(const char *);
>   	  abort();							\
>   	}								\
>         }									\
> +    fprintf(stderr, "CHECKED %s\n", MSG);				\
>     }
>
>   /* Floating-point variant.  */
> @@ -107,6 +108,7 @@ extern size_t strlen(const char *);
>   	  abort();							\
>   	}								\
>         }									\
> +    fprintf(stderr, "CHECKED %s\n", MSG);				\
>     }
>
>   /* Clean buffer with a non-zero pattern to help diagnose buffer
> @@ -323,6 +325,7 @@ extern int VECT_VAR(expected_cumulative_sat, uint, 64, 2);
>   	      strlen(COMMENT) > 0 ? " " COMMENT : "");			\
>         abort();								\
>       }									\
> +    fprintf(stderr, "CHECKED CUMULATIVE SAT %s\n", MSG);		\
>     }
>
>   #define CHECK_CUMULATIVE_SAT_NAMED(test_name,EXPECTED,comment)		\
>

Looks OK to me(but I can't approve it).

Tejas.
Marcus Shawcroft Jan. 16, 2015, 5:10 p.m. UTC | #2 
On 13 January 2015 at 15:18, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>         * gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h (CHECK):
>         Add trace.
>         (CHECK_FP): Likewise.
>         (CHECK_CUMULATIVE_SAT): Likewise.

OK, provided no regressions and no new fails for aarch64, aarch64_be and arm.
/Marcus
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
index 6464c66..2730a66 100644
--- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
+++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/arm-neon-ref.h
@@ -79,6 +79,7 @@  extern size_t strlen(const char *);
 	  abort();							\
 	}								\
       }									\
+    fprintf(stderr, "CHECKED %s\n", MSG);				\
   }
 
 /* Floating-point variant.  */
@@ -107,6 +108,7 @@  extern size_t strlen(const char *);
 	  abort();							\
 	}								\
       }									\
+    fprintf(stderr, "CHECKED %s\n", MSG);				\
   }
 
 /* Clean buffer with a non-zero pattern to help diagnose buffer
@@ -323,6 +325,7 @@  extern int VECT_VAR(expected_cumulative_sat, uint, 64, 2);
 	      strlen(COMMENT) > 0 ? " " COMMENT : "");			\
       abort();								\
     }									\
+    fprintf(stderr, "CHECKED CUMULATIVE SAT %s\n", MSG);		\
   }
 
 #define CHECK_CUMULATIVE_SAT_NAMED(test_name,EXPECTED,comment)		\